Fix portability for expr(1) usage #1

Merged
SlavekB merged 1 commits from feat/fix-expr-portability into master 5 years ago
obache commented 5 years ago
Collaborator

"match" operand for expr(1) is GNU extension.
Change to use the standard way to match regex with expr(1).

"match" operand for expr(1) is GNU extension. Change to use the standard way to match regex with expr(1).
SlavekB approved these changes 5 years ago
SlavekB left a comment
Owner

Everything looks good.

Everything looks good.
SlavekB changed title from WIP: Fix portability for expr(1) usage to Fix portability for expr(1) usage 5 years ago
SlavekB closed this pull request 5 years ago
SlavekB deleted branch feat/fix-expr-portability 5 years ago
Owner

Thanks Obata-san.

Just as a reminder, there is no need to add WIP in the title of the PR.

A PR marked as WIP means you intend to do more work on it and should not be merged yet.

I read the TGW guide again and there is no mentioning of WIP, unless I totally missed it.

Thanks Obata-san. Just as a reminder, there is no need to add WIP in the title of the PR.<br> A PR marked as WIP means you intend to do more work on it and should not be merged yet.<br> I read the TGW guide again and there is no mentioning of WIP, unless I totally missed it.
SlavekB added this to the R14.0.6 release milestone 5 years ago
Owner

@obache, you can use a different way. Instead of WIP to the PR name, you can set label PR/rfc. By doing so, you acknowledge that your work is completed and you want us to review the proposed PR.

@obache, you can use a different way. Instead of WIP to the PR name, you can set label PR/rfc. By doing so, you acknowledge that your work is completed and you want us to review the proposed PR.
obache commented 5 years ago
Poster
Collaborator

Have you ever created PR here?

below the title input area:
"Start the title with WIP: to prevent the pull request from being merged accidentally."

Have you ever created PR here? below the title input area: "Start the title with WIP: to prevent the pull request from being merged accidentally."
Owner

Yes, but it does not make sense to keep the WIP tag when you really want to merge 😺

As we said – WIP means that you're still working on PR == is not ready for merge. If PR is ready to merge, the WIP tag is confusing.

Yes, but it does not make sense to keep the WIP tag when you really want to merge :smiley_cat: As we said – WIP means that you're still working on PR == is not ready for merge. If PR is ready to merge, the WIP tag is confusing.
The pull request has been merged as 8b1ffe85f3.
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
3 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/tqca-tls#1
Loading…
There is no content yet.