Add tqca-tls plugin to the tqca package. #3
Merged
SlavekB
merged 1 commits from feat/add_tls_plugin into master 3 years ago
SlavekB
Loading…
Reference in new issue
There is no content yet.
Delete Branch 'feat/add_tls_plugin'
Deleting a branch is permanent. It CANNOT be undone. Continue?
The goal of this PR is to get rid of the tqca-tls module by including the tls plugin since both tqca and tqca-tls share some headers.
Add build options for both tqca shared lib and the tls plugin.
WIP:Add tqca-tls plugin to the tqca package.to Add tqca-tls plugin to the tqca package. 4 years agoIt seems that we both have to make adjustments there.
endif()endif( NOT SSL_FOUND )if( NOT OPENSSL_FOUND )Ha, I'm confused. There seems to be something wrong in tqca-tls. To check and search for the ssl library without the pkg-config file, we use the
SSL_FOUNDvariable, but at the endOPENSSL_FOUNDis tested. That's suspicious! I have to fix it first in tqca-tls.${TQT_LIBRARY_DIRS})add_definitions( -DOSSL_097 -DTQCA_PLUGIN )The
tqca-tls.cppcode seems to lack a commit, which makes the-DOSSL_097definition unnecessary. You should look in the tqca-tls module and compare the current code.Add tqca-tls plugin to the tqca package.to WIP:Add tqca-tls plugin to the tqca package. 4 years agoWIP:Add tqca-tls plugin to the tqca package.to Add tqca-tls plugin to the tqca package. 4 years agoa3a2830354to81025d8ae83 years agoNice! I have had this PR in my observation list for months. Good to see we are moving forward here too!
yes, once the two packages are one, I'll remove the qca folder in tdenetwork.
81025d8ae8to99ec4964d03 years agoIt looks good.
Before merging, I have to prepare an update for deb packaging files.
99ec4964d0into master 3 years agoGood to see this finally done 👍 good job all.
Reviewers
99ec4964d0.