TDE
/
tqt3
9
0
Fork 0
Code Issues 20 Pull Requests 7 Releases Wiki Activity
Labels Milestones

Change tests for glibc version #12

Merged
SlavekB merged 1 commits from feat/reverse-glibc-v2-tests into master 5 years ago
Conversation 2 Commits 1 Files Changed 15
SlavekB commented 5 years ago
Owner

It resolves building with libc libraries other than glibc – for example musl libc.

It resolves building with libc libraries other than glibc – for example [musl libc](https://www.musl-libc.org/).
SlavekB added this to the R14.0.7 release milestone 5 years ago
SlavekB added the PR/rfc label 5 years ago
MicheleC commented 5 years ago
Owner

PR looks good, nevertheless I wonder if it still makes sense to check for glibc < 2. Based on release history, glibc 2 was release on 1997-01-26, so we can safely assume that all the systems we are building TDE with glibc are using a version >=2. IMO we could simplify the code into

#define QT_SOCKLEN_T		socklen_t
PR looks good, nevertheless I wonder if it still makes sense to check for glibc < 2. Based on release history, glibc 2 was release on 1997-01-26, so we can safely assume that all the systems we are building TDE with glibc are using a version >=2. IMO we could simplify the code into ``` #define QT_SOCKLEN_T socklen_t ```
SlavekB commented 5 years ago
Poster
Owner

You're right, we can now assume that using glibc will not be older than version 2.

Patch updated.

You're right, we can now assume that using glibc will not be older than version 2. Patch updated.
Ghost closed this pull request 5 years ago
Ghost reopened this pull request 5 years ago
MicheleC approved these changes 5 years ago
MicheleC left a comment
Owner

LGTM.

LGTM.
SlavekB closed this pull request 5 years ago
SlavekB deleted branch feat/reverse-glibc-v2-tests 5 years ago
SlavekB removed the PR/rfc label 5 years ago
The pull request has been merged as 1aa221a2bc.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
Labels
Apply labels
Clear labels
GE/need-info
General - need additional info from contributor PR/keep-branch
Pull request - do not delete branch after merging PR/not-ok
Pull request - need fixing PR/rfc
Pull request - request for comments PR/update-trans
Pull request - update to translation files needed PR/wip
Pull request - work in progress RS/R14.0.x
Related to R14.0.x series RS/R14.1.x
Related to R14.1.x series SL/critical
Severity level - critical SL/major
Severity level - major SL/minor
Severity level - minor SL/normal
Severity level - normal SL/regression
Severity level - regression from previous version SL/trivial
Severity level - trivial SL/wishlist
Severity level - wishlist request ST/duplicate
Status - duplicate of another issue ST/invalid
Status - invalid report ST/notourproblem
Status - not our problem ST/rejected
Status - rejected ST/wontfix
Status - won't fix ST/worksforme
Status - works for me, unable to reproduce
No Label GE/need-info PR/keep-branch PR/not-ok PR/rfc PR/update-trans PR/wip RS/R14.0.x RS/R14.1.x SL/critical SL/major SL/minor SL/normal SL/regression SL/trivial SL/wishlist ST/duplicate ST/invalid ST/notourproblem ST/rejected ST/wontfix ST/worksforme
Milestone
Set milestone
Clear milestone
No items
No Milestone
R14.0.7 release
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/tqt3#12
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'feat/reverse-glibc-v2-tests'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes