TDE
/
tqt3
9
0
Fork 0
Code Issues 20 Pull Requests 7 Releases Wiki Activity
Labels Milestones

Remove iconview module definition as standalone #47

Merged
SlavekB merged 2 commits from feat/remove-iconview-module-definition into master 3 years ago
Conversation 1 Commits 2 Files Changed 4
SlavekB commented 3 years ago
Owner

IconView widget was moved to Widgets module in commit a41a034902, but there remained the iconview module definition as standalone. This causes incorrect BUILD_KEY and library configuration declaration.

IconView widget was moved to Widgets module in commit a41a034902bb3aa75db4524978a174353b5de2fe, but there remained the iconview module definition as standalone. This causes incorrect `BUILD_KEY` and library configuration declaration.
SlavekB added 1 commit 3 years ago
00318b767a
IconView widget was moved to Widgets module in commit
MicheleC approved these changes 3 years ago
MicheleC left a comment
Owner

LGTM

LGTM
SlavekB added 1 commit 3 years ago
ce03d78623
Return TQT_NO_WORKSPACE setting, according to TQT_MODULE_WORKSPACE,
MicheleC commented 3 years ago
Owner

Second commit looks good too 😄

Second commit looks good too :smile:
SlavekB merged commit ce03d78623 into master 3 years ago
SlavekB added this to the R14.1.0 release milestone 3 years ago
MicheleC deleted branch feat/remove-iconview-module-definition 3 years ago

Reviewers

MicheleC approved these changes 3 years ago
The pull request has been merged as ce03d78623.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
MicheleC
Labels
Apply labels
Clear labels
GE/need-info
General - need additional info from contributor PR/keep-branch
Pull request - do not delete branch after merging PR/not-ok
Pull request - need fixing PR/rfc
Pull request - request for comments PR/update-trans
Pull request - update to translation files needed PR/wip
Pull request - work in progress RS/R14.0.x
Related to R14.0.x series RS/R14.1.x
Related to R14.1.x series SL/critical
Severity level - critical SL/major
Severity level - major SL/minor
Severity level - minor SL/normal
Severity level - normal SL/regression
Severity level - regression from previous version SL/trivial
Severity level - trivial SL/wishlist
Severity level - wishlist request ST/duplicate
Status - duplicate of another issue ST/invalid
Status - invalid report ST/notourproblem
Status - not our problem ST/rejected
Status - rejected ST/wontfix
Status - won't fix ST/worksforme
Status - works for me, unable to reproduce
No Label GE/need-info PR/keep-branch PR/not-ok PR/rfc PR/update-trans PR/wip RS/R14.0.x RS/R14.1.x SL/critical SL/major SL/minor SL/normal SL/regression SL/trivial SL/wishlist ST/duplicate ST/invalid ST/notourproblem ST/rejected ST/wontfix ST/worksforme
Milestone
Set milestone
Clear milestone
No items
No Milestone
R14.1.0 release
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/tqt3#47
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'feat/remove-iconview-module-definition'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes