Everyone will get the same desktop files as well as the same icons.
The desktop files have been taken from your Debian packaging system.
Not sure It will work for the *BSD since they put their files in /usr/local thought.
Tell me what you think about this.
I came up to this in order to fix bug639.
Everyone will get the same desktop files as well as the same icons.
The desktop files have been taken from your Debian packaging system.
Not sure It will work for the *BSD since they put their files in /usr/local thought.
Tell me what you think about this.
Because the prefix will usually be set to /usr, /usr/local, or something similar, I think the default value for QT_INSTALL_SHARE should not contain /usr.
Because the prefix will usually be set to `/usr`, `/usr/local`, or something similar, I think the default value for `QT_INSTALL_SHARE` should not contain `/usr`.
@cethyel, please can you simplify the commit log a bit?
For example, it doesn't make much sense to include in one comment "add a sharedir option…" and then "rename share option to sysshare…", 3× the same "Signed-off-by", etc.
@cethyel, please can you simplify the commit log a bit?
For example, it doesn't make much sense to include in one comment "add a sharedir option…" and then "rename share option to sysshare…", 3× the same "Signed-off-by", etc.
I came up to this in order to fix bug639.
Everyone will get the same desktop files as well as the same icons.
The desktop files have been taken from your Debian packaging system.
Not sure It will work for the *BSD since they put their files in /usr/local thought.
Tell me what you think about this.
add few desktop files, this fixes bug:639to WIP: add few desktop files, this fixes bug:639 5 years agoI've added a sharedir option to configure.
Something to test like:
There are only small comments. Please consider naming the variable "sysshare" instead of "share" because its purpose is similar to "sysconf" variable.
sysconfdir)
QT_INSTALL_SYSCONF="$VAL"
;;
sharedir)
It seems that the indentation is different than the conditions that are in the neighborhood.
# default PREFIX/etc/settings
[ -z "$QT_INSTALL_SYSCONF" ] && QT_INSTALL_SYSCONF=$QT_INSTALL_PREFIX/etc/settings
# default PREFIX/usr/share
[ -z "QT_INSTALL_SHARE" ] && QT_INSTALL_SHARE=$$QT_INSTALL_PREFIX/usr/share
Because the prefix will usually be set to
/usr
,/usr/local
, or something similar, I think the default value forQT_INSTALL_SHARE
should not contain/usr
.@cethyel, please can you simplify the commit log a bit?
For example, it doesn't make much sense to include in one comment "add a sharedir option…" and then "rename share option to sysshare…", 3× the same "Signed-off-by", etc.
There is a small typo that requires correction.
# default PREFIX/etc/settings
[ -z "$QT_INSTALL_SYSCONF" ] && QT_INSTALL_SYSCONF=$QT_INSTALL_PREFIX/etc/settings
# default PREFIX/share
[ -z "QT_INSTALL_SHARE" ] && QT_INSTALL_SHARE=$QT_INSTALL_PREFIX/share
There is no
$
before the variable name in[ -z "QT_INSTALL_SHARE"]
.As a result, the default value is not used.
Tested along with a patch for tde-packaging, there were no problems.
WIP: add few desktop files, this fixes bug:639to Add few desktop files, this fixes bug:639 5 years ago6131b4262e
.