#12 Change tests for glibc version

Merged
SlavekB merged 1 commits from feat/reverse-glibc-v2-tests into master 1 month ago
SlavekB commented 1 month ago

It resolves building with libc libraries other than glibc – for example musl libc.

It resolves building with libc libraries other than glibc – for example [musl libc](https://www.musl-libc.org/).
SlavekB added this to the R14.0.7 release milestone 1 month ago
SlavekB added the
PR/rfc
label 1 month ago
MicheleC commented 1 month ago
Owner

PR looks good, nevertheless I wonder if it still makes sense to check for glibc < 2. Based on release history, glibc 2 was release on 1997-01-26, so we can safely assume that all the systems we are building TDE with glibc are using a version >=2. IMO we could simplify the code into

#define QT_SOCKLEN_T        socklen_t
PR looks good, nevertheless I wonder if it still makes sense to check for glibc < 2. Based on release history, glibc 2 was release on 1997-01-26, so we can safely assume that all the systems we are building TDE with glibc are using a version >=2. IMO we could simplify the code into ``` #define QT_SOCKLEN_T socklen_t ```
SlavekB commented 1 month ago
Owner

You’re right, we can now assume that using glibc will not be older than version 2.

Patch updated.

You're right, we can now assume that using glibc will not be older than version 2. Patch updated.
MicheleC approved these changes 1 month ago
LGTM.
SlavekB deleted branch feat/reverse-glibc-v2-tests 1 month ago
SlavekB removed the
PR/rfc
label 1 month ago

Reviewers

MicheleC approved these changes 1 month ago
The pull request has been merged.
Sign in to join this conversation.
Loading…
Cancel
Save
There is no content yet.