Tunnisteet Merkkipaalut

Change tests for glibc version #12

Yhdistetty

SlavekB yhdistetty 1 committia lähteestä feat/reverse-glibc-v2-tests kohteeseen master 5 vuotta sitten

Keskustelu 2 Commitit 1 Muuttuneet tiedostot 15

SlavekB kommentoi 5 vuotta sitten

Omistaja

It resolves building with libc libraries other than glibc – for example musl libc.

It resolves building with libc libraries other than glibc – for example [musl libc](https://www.musl-libc.org/).

SlavekB lisäsi tämän merkkipaaluun R14.0.7 release 5 vuotta sitten

SlavekB added the PR/rfc label 5 vuotta sitten

MicheleC kommentoi 5 vuotta sitten

Omistaja

PR looks good, nevertheless I wonder if it still makes sense to check for glibc < 2. Based on release history, glibc 2 was release on 1997-01-26, so we can safely assume that all the systems we are building TDE with glibc are using a version >=2. IMO we could simplify the code into

#define QT_SOCKLEN_T		socklen_t

PR looks good, nevertheless I wonder if it still makes sense to check for glibc < 2. Based on release history, glibc 2 was release on 1997-01-26, so we can safely assume that all the systems we are building TDE with glibc are using a version >=2. IMO we could simplify the code into ``` #define QT_SOCKLEN_T socklen_t ```

SlavekB kommentoi 5 vuotta sitten

Tekijä

Omistaja

You're right, we can now assume that using glibc will not be older than version 2.

Patch updated.

You're right, we can now assume that using glibc will not be older than version 2. Patch updated.

Ghost closed this pull request 5 vuotta sitten

Ghost reopened this pull request 5 vuotta sitten

MicheleC hyväksyi nämä muutokset 5 vuotta sitten

MicheleC jätti kommentin

Omistaja

LGTM.

LGTM.

SlavekB closed this pull request 5 vuotta sitten

SlavekB poisti haaran feat/reverse-glibc-v2-tests 5 vuotta sitten

SlavekB removed the PR/rfc label 5 vuotta sitten

The pull request has been merged as 1aa221a2bc.

Sign in to join this conversation.

Reviewers

Request review

No reviewers

Tunnisteet

Aseta tunniste

Tyhjennä tunnisteet

GE/need-info
General - need additional info from contributor PR/keep-branch
Pull request - do not delete branch after merging PR/not-ok
Pull request - need fixing PR/rfc
Pull request - request for comments PR/update-trans
Pull request - update to translation files needed PR/wip
Pull request - work in progress RS/R14.0.x
Related to R14.0.x series RS/R14.1.x
Related to R14.1.x series SL/critical
Severity level - critical SL/major
Severity level - major SL/minor
Severity level - minor SL/normal
Severity level - normal SL/regression
Severity level - regression from previous version SL/trivial
Severity level - trivial SL/wishlist
Severity level - wishlist request ST/duplicate
Status - duplicate of another issue ST/invalid
Status - invalid report ST/notourproblem
Status - not our problem ST/rejected
Status - rejected ST/wontfix
Status - won't fix ST/worksforme
Status - works for me, unable to reproduce

Ei tunnistetta GE/need-info PR/keep-branch PR/not-ok PR/rfc PR/update-trans PR/wip RS/R14.0.x RS/R14.1.x SL/critical SL/major SL/minor SL/normal SL/regression SL/trivial SL/wishlist ST/duplicate ST/invalid ST/notourproblem ST/rejected ST/wontfix ST/worksforme

Merkkipaalu

Aseta merkkipaalu

Tyhjennä merkkipaalu

Ei kohteita

Ei merkkipaalua

R14.0.7 release

Käsittelijä

Osoita käyttäjille

Tyhjennä käsittelijä

Ei käsittelijää

2 osallistujaa

Ilmoitukset

Tilaa

Määräpäivä

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

Määräpäivää ei asetettu.

Riippuvuudet

Riippuvuuksia ei asetettu.

Reference: TDE/tqt3#12

Kirjoita Esikatselu

Ladataan…

Peruuta

Tallenna

Sisältöä ei vielä ole.