Etichette Traguardi

Change tests for glibc version #12

Unito

SlavekB ha unito 1 commit da feat/reverse-glibc-v2-tests a master 5 anni fa

Conversazione 2 Commit 1 File modificati 15

SlavekB 5 anni fa ha commentato

Proprietario

It resolves building with libc libraries other than glibc – for example musl libc.

It resolves building with libc libraries other than glibc – for example [musl libc](https://www.musl-libc.org/).

SlavekB aggiunta alle pietre miliari R14.0.7 release 5 anni fa

SlavekB ha aggiunto l'etichetta PR/rfc 5 anni fa

MicheleC 5 anni fa ha commentato

Proprietario

PR looks good, nevertheless I wonder if it still makes sense to check for glibc < 2. Based on release history, glibc 2 was release on 1997-01-26, so we can safely assume that all the systems we are building TDE with glibc are using a version >=2. IMO we could simplify the code into

#define QT_SOCKLEN_T		socklen_t

PR looks good, nevertheless I wonder if it still makes sense to check for glibc < 2. Based on release history, glibc 2 was release on 1997-01-26, so we can safely assume that all the systems we are building TDE with glibc are using a version >=2. IMO we could simplify the code into ``` #define QT_SOCKLEN_T socklen_t ```

SlavekB 5 anni fa ha commentato

Autore

Proprietario

You're right, we can now assume that using glibc will not be older than version 2.

Patch updated.

You're right, we can now assume that using glibc will not be older than version 2. Patch updated.

Ghost chiusa questa pull request 5 anni fa

Ghost riaperta questa pull request 5 anni fa

MicheleC hanno approvato queste modifiche 5 anni fa

MicheleC lascia un commento

Proprietario

LGTM.

LGTM.

SlavekB chiusa questa pull request 5 anni fa

SlavekB branch feat/reverse-glibc-v2-tests eliminato 5 anni fa

SlavekB rimosso l'etichetta PR/rfc 5 anni fa

La pull request è stata unita come 1aa221a2bc.

Effettua l'accesso per partecipare alla conversazione.

Revisori

Richiedi revisione

Nessun revisore

Etichette

Applica etichette

Pulisci le etichette

GE/need-info
General - need additional info from contributor PR/keep-branch
Pull request - do not delete branch after merging PR/not-ok
Pull request - need fixing PR/rfc
Pull request - request for comments PR/update-trans
Pull request - update to translation files needed PR/wip
Pull request - work in progress RS/R14.0.x
Related to R14.0.x series RS/R14.1.x
Related to R14.1.x series SL/critical
Severity level - critical SL/major
Severity level - major SL/minor
Severity level - minor SL/normal
Severity level - normal SL/regression
Severity level - regression from previous version SL/trivial
Severity level - trivial SL/wishlist
Severity level - wishlist request ST/duplicate
Status - duplicate of another issue ST/invalid
Status - invalid report ST/notourproblem
Status - not our problem ST/rejected
Status - rejected ST/wontfix
Status - won't fix ST/worksforme
Status - works for me, unable to reproduce

Nessuna etichetta GE/need-info PR/keep-branch PR/not-ok PR/rfc PR/update-trans PR/wip RS/R14.0.x RS/R14.1.x SL/critical SL/major SL/minor SL/normal SL/regression SL/trivial SL/wishlist ST/duplicate ST/invalid ST/notourproblem ST/rejected ST/wontfix ST/worksforme

Traguardo

Imposta traguardo

Milestone pulita

Nessun elemento

Nessuna milestone

R14.0.7 release

Assegnatari

Assegna utenti

Cancella assegnatari

Nessuna assegnatario

2 Partecipanti

Notifiche

Iscriviti

Data di scadenza

La data di scadenza non è valida o fuori intervallo. Si prega di utilizzare il formato 'aaaa-mm-dd'.

Nessuna data di scadenza impostata.

Dipendenze

Nessuna dipendenza impostata.

Riferimento: TDE/tqt3#12

Scrivi Anteprima

Caricamento…

Annulla

Salva

Non ci sono ancora contenuti.