Change tests for glibc version #12
マージ済み
SlavekB
が 1 個のコミットを feat/reverse-glibc-v2-tests
から master
へマージ 5年前
読み込み中…
新しいイシューから参照
まだ内容がありません
ブランチ 'feat/reverse-glibc-v2-tests' の削除
ブランチの削除は恒久的で、元に戻すことはできません。 続行しますか?
It resolves building with libc libraries other than glibc – for example musl libc.
PR looks good, nevertheless I wonder if it still makes sense to check for glibc < 2. Based on release history, glibc 2 was release on 1997-01-26, so we can safely assume that all the systems we are building TDE with glibc are using a version >=2. IMO we could simplify the code into
You're right, we can now assume that using glibc will not be older than version 2.
Patch updated.
LGTM.
1aa221a2bc
でマージされています。