標籤 里程碑

Change tests for glibc version #12

已合併

SlavekB 於 5 年之前 將 1 次代碼提交從 feat/reverse-glibc-v2-tests 合併至 master

對話內容 2 程式碼提交 1 Files Changed 15

SlavekB 評論 5 年之前

所有者

It resolves building with libc libraries other than glibc – for example musl libc.

It resolves building with libc libraries other than glibc – for example [musl libc](https://www.musl-libc.org/).

SlavekB 新增至R14.0.7 release 里程碑 5 年之前

SlavekB added the PR/rfc label 5 年之前

MicheleC 評論 5 年之前

所有者

PR looks good, nevertheless I wonder if it still makes sense to check for glibc < 2. Based on release history, glibc 2 was release on 1997-01-26, so we can safely assume that all the systems we are building TDE with glibc are using a version >=2. IMO we could simplify the code into

#define QT_SOCKLEN_T		socklen_t

PR looks good, nevertheless I wonder if it still makes sense to check for glibc < 2. Based on release history, glibc 2 was release on 1997-01-26, so we can safely assume that all the systems we are building TDE with glibc are using a version >=2. IMO we could simplify the code into ``` #define QT_SOCKLEN_T socklen_t ```

SlavekB 評論 5 年之前

發佈者

所有者

You're right, we can now assume that using glibc will not be older than version 2.

Patch updated.

You're right, we can now assume that using glibc will not be older than version 2. Patch updated.

Ghost closed this pull request 5 年之前

Ghost reopened this pull request 5 年之前

MicheleC approved these changes 5 年之前

MicheleC left a comment

所有者

LGTM.

LGTM.

SlavekB closed this pull request 5 年之前

SlavekB 刪除分支 feat/reverse-glibc-v2-tests 5 年之前

SlavekB removed the PR/rfc label 5 年之前

The pull request has been merged as 1aa221a2bc.

登入 才能加入這對話。

Reviewers

Request review

No reviewers

標籤

Apply labels

清除已選取標籤

GE/need-info
General - need additional info from contributor PR/keep-branch
Pull request - do not delete branch after merging PR/not-ok
Pull request - need fixing PR/rfc
Pull request - request for comments PR/update-trans
Pull request - update to translation files needed PR/wip
Pull request - work in progress RS/R14.0.x
Related to R14.0.x series RS/R14.1.x
Related to R14.1.x series SL/critical
Severity level - critical SL/major
Severity level - major SL/minor
Severity level - minor SL/normal
Severity level - normal SL/regression
Severity level - regression from previous version SL/trivial
Severity level - trivial SL/wishlist
Severity level - wishlist request ST/duplicate
Status - duplicate of another issue ST/invalid
Status - invalid report ST/notourproblem
Status - not our problem ST/rejected
Status - rejected ST/wontfix
Status - won't fix ST/worksforme
Status - works for me, unable to reproduce

未選擇標籤 GE/need-info PR/keep-branch PR/not-ok PR/rfc PR/update-trans PR/wip RS/R14.0.x RS/R14.1.x SL/critical SL/major SL/minor SL/normal SL/regression SL/trivial SL/wishlist ST/duplicate ST/invalid ST/notourproblem ST/rejected ST/wontfix ST/worksforme

里程碑

Set milestone

清除已選取里程碑

No items

未選擇里程碑

R14.0.7 release

Assignees

Assign users

Clear assignees

No Assignees

2 參與者

訊息

訂閱

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: TDE/tqt3#12

Write Preview

Loading…

取消

儲存

尚未有任何內容