Change tests for glibc version #12

已合併
SlavekB 將 1 次提交從 feat/reverse-glibc-v2-tests 合併至 master 5 年前
擁有者

It resolves building with libc libraries other than glibc – for example musl libc.

It resolves building with libc libraries other than glibc – for example [musl libc](https://www.musl-libc.org/).
SlavekB 新增到 R14.0.7 release 里程碑 5 年前
SlavekB 加入了 PR/rfc 標籤 5 年前
擁有者

PR looks good, nevertheless I wonder if it still makes sense to check for glibc < 2. Based on release history, glibc 2 was release on 1997-01-26, so we can safely assume that all the systems we are building TDE with glibc are using a version >=2. IMO we could simplify the code into

#define QT_SOCKLEN_T		socklen_t
PR looks good, nevertheless I wonder if it still makes sense to check for glibc < 2. Based on release history, glibc 2 was release on 1997-01-26, so we can safely assume that all the systems we are building TDE with glibc are using a version >=2. IMO we could simplify the code into ``` #define QT_SOCKLEN_T socklen_t ```
發布者
擁有者

You're right, we can now assume that using glibc will not be older than version 2.

Patch updated.

You're right, we can now assume that using glibc will not be older than version 2. Patch updated.
Ghost 關閉了這個合併請求 5 年前
Ghost 重新開放了這個合併請求 5 年前
MicheleC 核可了這些變更 5 年前
MicheleC 留下了回應
擁有者

LGTM.

LGTM.
SlavekB 關閉了這個合併請求 5 年前
SlavekB 刪除分支 feat/reverse-glibc-v2-tests 5 年前
SlavekB 移除了 PR/rfc 標籤 5 年前
此合併請求已被合併為 1aa221a2bc
登入 才能加入這對話。
沒有審核者
未選擇里程碑
沒有負責人
2 參與者
通知
截止日期

未設定截止日期。

先決條件

未設定先決條件。

參考: TDE/tqt3#12
載入中…
尚未有任何內容