Add few desktop files, this fixes bug:639 #9

Συγχωνευμένα
Ghost συγχώνευσε 1 υποβολές από bug/639 σε master 5 έτη πριν
Ghost σχολίασε 5 έτη πριν

I came up to this in order to fix bug639.

Everyone will get the same desktop files as well as the same icons.
The desktop files have been taken from your Debian packaging system.

Not sure It will work for the *BSD since they put their files in /usr/local thought.

Tell me what you think about this.

I came up to this in order to fix bug639. Everyone will get the same desktop files as well as the same icons. The desktop files have been taken from your Debian packaging system. Not sure It will work for the *BSD since they put their files in /usr/local thought. Tell me what you think about this.
Ghost πρόσθεσε τη σήμανση PR/rfc 5 έτη πριν
Ghost πρόσθεσε τη σήμανση PR/wip 5 έτη πριν
MicheleC άλλαξε το τίτλο από add few desktop files, this fixes bug:639 σε WIP: add few desktop files, this fixes bug:639 5 έτη πριν
Ghost σχολίασε 5 έτη πριν
Συντάκτης

I've added a sharedir option to configure.

Something to test like:

./configure \
     -prefix "/usr" \
     -sysshare "/usr/share"
I've added a sharedir option to configure. Something to test like: ``` ./configure \ -prefix "/usr" \ -sysshare "/usr/share" ```
SlavekB αξιολόγησε 5 έτη πριν
SlavekB άφησε ένα σχόλιο
Ιδιοκτήτης

There are only small comments. Please consider naming the variable "sysshare" instead of "share" because its purpose is similar to "sysconf" variable.

There are only small comments. Please consider naming the variable "sysshare" instead of "share" because its purpose is similar to "sysconf" variable.
configure Παρωχημένο
sysconfdir)
QT_INSTALL_SYSCONF="$VAL"
;;
sharedir)
SlavekB σχολίασε 5 έτη πριν
Ιδιοκτήτης

It seems that the indentation is different than the conditions that are in the neighborhood.

It seems that the indentation is different than the conditions that are in the neighborhood.
configure Παρωχημένο
# default PREFIX/etc/settings
[ -z "$QT_INSTALL_SYSCONF" ] && QT_INSTALL_SYSCONF=$QT_INSTALL_PREFIX/etc/settings
# default PREFIX/usr/share
[ -z "QT_INSTALL_SHARE" ] && QT_INSTALL_SHARE=$$QT_INSTALL_PREFIX/usr/share
SlavekB σχολίασε 5 έτη πριν
Ιδιοκτήτης

Because the prefix will usually be set to /usr, /usr/local, or something similar, I think the default value for QT_INSTALL_SHARE should not contain /usr.

Because the prefix will usually be set to `/usr`, `/usr/local`, or something similar, I think the default value for `QT_INSTALL_SHARE` should not contain `/usr`.
SlavekB σχολίασε 5 έτη πριν
Ιδιοκτήτης

@cethyel, please can you simplify the commit log a bit?

For example, it doesn't make much sense to include in one comment "add a sharedir option…" and then "rename share option to sysshare…", 3× the same "Signed-off-by", etc.

@cethyel, please can you simplify the commit log a bit? For example, it doesn't make much sense to include in one comment "add a sharedir option…" and then "rename share option to sysshare…", 3× the same "Signed-off-by", etc.
SlavekB αξιολόγησε 5 έτη πριν
SlavekB άφησε ένα σχόλιο
Ιδιοκτήτης

There is a small typo that requires correction.

There is a small typo that requires correction.
configure Παρωχημένο
# default PREFIX/etc/settings
[ -z "$QT_INSTALL_SYSCONF" ] && QT_INSTALL_SYSCONF=$QT_INSTALL_PREFIX/etc/settings
# default PREFIX/share
[ -z "QT_INSTALL_SHARE" ] && QT_INSTALL_SHARE=$QT_INSTALL_PREFIX/share
SlavekB σχολίασε 5 έτη πριν
Ιδιοκτήτης

There is no $ before the variable name in [ -z "QT_INSTALL_SHARE"].
As a result, the default value is not used.

There is no `$` before the variable name in `[ -z "QT_INSTALL_SHARE"]`. As a result, the default value is not used.
SlavekB ενέκρινε αυτές τις αλλαγές 5 έτη πριν
SlavekB άφησε ένα σχόλιο
Ιδιοκτήτης

Tested along with a patch for tde-packaging, there were no problems.

Tested along with a patch for tde-packaging, there were no problems.
SlavekB άλλαξε το τίτλο από WIP: add few desktop files, this fixes bug:639 σε Add few desktop files, this fixes bug:639 5 έτη πριν
SlavekB αφαίρεσε τα PR/wip PR/rfc σήματα 5 έτη πριν
Ghost έκλεισε αυτό το pull request 5 έτη πριν
Ghost διέγραψε το κλάδο bug/639 5 έτη πριν
SlavekB το πρόσθεσε στο R14.0.7 release ορόσημο 5 έτη πριν
Το pull request έχει συγχωνευθεί ως 6131b4262e.
Συνδεθείτε για να συμμετάσχετε σε αυτή τη συνομιλία.
Δεν υπάρχουν εξεταστές
Χωρίς Ορόσημο
Χωρίς Αποδέκτη
2 Συμμετέχοντες
Ειδοποιήσεις
Ημερομηνία Παράδοσης

Δεν ορίστηκε ημερομηνία παράδοσης.

Εξαρτήσεις

Δεν έχουν οριστεί εξαρτήσεις.

Αναφορά: TDE/tqt3#9
Φόρτωση…
Δεν υπάρχει ακόμα περιεχόμενο.