Prevent to use GNU sed extension feature #2

Merged
SlavekB merged 1 commits from bug/2986/prevent-to-use-gnu-sed-extension-feature into master 3 years ago
obache commented 3 years ago
Collaborator

GNU sed extension feature (using "\n" in insert string) is used, but it should not be used for portability.

GNU sed extension feature (using "\n" in insert string) is used, but it should not be used for portability.
Owner

Very good work!

Patch is clean and functional, branch name is very well, commit log is excellent. It is a pleasure to see such a job.

Please make one small modification – add a line like this to the commit log: "This resolves bug 2986." So the reference to the corresponding bug report will also be in the changelog. To change an existing commit, use:

git commit --amend
git push -f origin HEAD

Thank you.

Very good work! Patch is clean and functional, branch name is very well, commit log is excellent. It is a pleasure to see such a job. Please make one small modification – add a line like this to the commit log: "This resolves bug 2986." So the reference to the corresponding bug report will also be in the changelog. To change an existing commit, use: ``` git commit --amend git push -f origin HEAD ``` Thank you.
Poster
Collaborator

changed and pushed

changed and pushed
SlavekB approved these changes 3 years ago
SlavekB left a comment

Everything looks good, there is nothing to prevent merging. Good work!

SlavekB changed title from WIP: Prevent to use GNU sed extension feature to Prevent to use GNU sed extension feature 3 years ago
SlavekB closed this pull request 3 years ago
SlavekB deleted branch bug/2986/prevent-to-use-gnu-sed-extensio 3 years ago
SlavekB added this to the R14.0.6 release milestone 3 years ago
The pull request has been merged as eee820646d.
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Loading…
There is no content yet.