#2 Prevent to use GNU sed extension feature

Merged
SlavekB merged 1 commits from bug/2986/prevent-to-use-gnu-sed-extension-feature into master 9 months ago
obache commented 9 months ago

GNU sed extension feature (using “\n” in insert string) is used, but it should not be used for portability.

GNU sed extension feature (using "\n" in insert string) is used, but it should not be used for portability.
SlavekB commented 9 months ago
Owner

Very good work!

Patch is clean and functional, branch name is very well, commit log is excellent. It is a pleasure to see such a job.

Please make one small modification – add a line like this to the commit log: “This resolves bug 2986.” So the reference to the corresponding bug report will also be in the changelog. To change an existing commit, use:

git commit --amend
git push -f origin HEAD

Thank you.

Very good work! Patch is clean and functional, branch name is very well, commit log is excellent. It is a pleasure to see such a job. Please make one small modification – add a line like this to the commit log: "This resolves bug 2986." So the reference to the corresponding bug report will also be in the changelog. To change an existing commit, use: ``` git commit --amend git push -f origin HEAD ``` Thank you.
obache commented 9 months ago
Poster

changed and pushed

changed and pushed
SlavekB approved these changes 9 months ago
Everything looks good, there is nothing to prevent merging. Good work!
SlavekB changed title from WIP: Prevent to use GNU sed extension feature to Prevent to use GNU sed extension feature 9 months ago
SlavekB deleted branch bug/2986/prevent-to-use-gnu-sed-extensio 9 months ago
SlavekB added this to the R14.0.6 release milestone 9 months ago

Reviewers

SlavekB approved these changes 9 months ago
The pull request has been merged.
Sign in to join this conversation.
Loading…
Cancel
Save
There is no content yet.