Prevent to use GNU sed extension feature #2
Merged
SlavekB
merged 1 commits from bug/2986/prevent-to-use-gnu-sed-extension-feature
into master
5 years ago
Loading…
Reference in new issue
There is no content yet.
Delete Branch 'bug/2986/prevent-to-use-gnu-sed-extension-feature'
Deleting a branch is permanent. It CANNOT be undone. Continue?
GNU sed extension feature (using "\n" in insert string) is used, but it should not be used for portability.
Very good work!
Patch is clean and functional, branch name is very well, commit log is excellent. It is a pleasure to see such a job.
Please make one small modification – add a line like this to the commit log: "This resolves bug 2986." So the reference to the corresponding bug report will also be in the changelog. To change an existing commit, use:
Thank you.
changed and pushed
Everything looks good, there is nothing to prevent merging. Good work!
WIP: Prevent to use GNU sed extension featureto Prevent to use GNU sed extension feature 5 years agoeee820646d
.