reduce scope of pointer variables #2

zavřený
otevřeno před 6 roky uživatelem Ghost · 3 komentářů
Ghost okomentoval před 6 roky

According to cppcheck the scope of 'item' and 'skin' in "yakuake/yakuake/src/skin_settings.cpp" could be reduced:

[skin_settings.cpp:151]: (style) The scope of the variable 'item' can be reduced.

[skin_settings.cpp:418]: (style) The scope of the variable 'skin' can be reduced.

I suggest 'item' to be moved in the "while (it2.current())" scope.

and

'skin' to be moved in the while "(it.current())" scope.

What do you think about?

According to cppcheck the scope of 'item' and 'skin' in "yakuake/yakuake/src/skin_settings.cpp" could be reduced: [skin_settings.cpp:151]: (style) The scope of the variable 'item' can be reduced. [skin_settings.cpp:418]: (style) The scope of the variable 'skin' can be reduced. I suggest 'item' to be moved in the "while (it2.current())" scope. and 'skin' to be moved in the while "(it.current())" scope. What do you think about?
MicheleC okomentoval před 6 roky
Vlastník

Yes, it sounds like a good idea. Please create PR and we will merge, so commit is with your name 😄

Yes, it sounds like a good idea. Please create PR and we will merge, so commit is with your name :smile:
MicheleC okomentoval před 6 roky
Vlastník

one more thing: in the commit message please make sure to add something like "This resolves issue#2", so that gitea can pick it up and automatically link issue and commit in code.

one more thing: in the commit message please make sure to add something like "This resolves issue#2", so that gitea can pick it up and automatically link issue and commit in code.
MicheleC přidal/a toto do milníku R14.0.6 release před 6 roky
MicheleC okomentoval před 6 roky
Vlastník

Resolved by PR #3

Resolved by PR https://mirror.git.trinitydesktop.org/gitea/TDE/yakuake/pulls/3
MicheleC uzavřel/a tento úkol před 6 roky
Přihlaste se pro zapojení do konverzace.
Bez milníku
Bez zpracovatelů
2 účastníků
Oznámení
Termín dokončení

Žádný termín dokončení.

Závislosti

Nejsou nastaveny žádné závislosti.

Reference: TDE/yakuake#2
Načítá se…
Není zde žádný obsah.