reduce scope of pointer variables #2
Cerrada
abierta hace 6 años por Ghost
·
3 comentarios
Sin etiquetas
No asignados
2 participantes
Notificaciones
Fecha de vencimiento
Sin fecha de vencimiento.
Dependencias
No se han establecido dependencias.
Referencia: TDE/yakuake#2
Cargando…
Referencia en una nueva incidencia
Aún no existe contenido.
Eliminar la rama con el nombre '%!s(<nil>)'
Eliminar una rama es permanente. NO PUEDE deshacerse. ¿Continuar?
According to cppcheck the scope of 'item' and 'skin' in "yakuake/yakuake/src/skin_settings.cpp" could be reduced:
[skin_settings.cpp:151]: (style) The scope of the variable 'item' can be reduced.
[skin_settings.cpp:418]: (style) The scope of the variable 'skin' can be reduced.
I suggest 'item' to be moved in the "while (it2.current())" scope.
and
'skin' to be moved in the while "(it.current())" scope.
What do you think about?
Yes, it sounds like a good idea. Please create PR and we will merge, so commit is with your name 😄
one more thing: in the commit message please make sure to add something like "This resolves issue#2", so that gitea can pick it up and automatically link issue and commit in code.
Resolved by PR #3