reduce scope of pointer variables #2

已關閉
opened 6 年之前 by Ghost · 3 條評論

According to cppcheck the scope of 'item' and 'skin' in "yakuake/yakuake/src/skin_settings.cpp" could be reduced:

[skin_settings.cpp:151]: (style) The scope of the variable 'item' can be reduced.

[skin_settings.cpp:418]: (style) The scope of the variable 'skin' can be reduced.

I suggest 'item' to be moved in the "while (it2.current())" scope.

and

'skin' to be moved in the while "(it.current())" scope.

What do you think about?

According to cppcheck the scope of 'item' and 'skin' in "yakuake/yakuake/src/skin_settings.cpp" could be reduced: [skin_settings.cpp:151]: (style) The scope of the variable 'item' can be reduced. [skin_settings.cpp:418]: (style) The scope of the variable 'skin' can be reduced. I suggest 'item' to be moved in the "while (it2.current())" scope. and 'skin' to be moved in the while "(it.current())" scope. What do you think about?
所有者

Yes, it sounds like a good idea. Please create PR and we will merge, so commit is with your name 😄

Yes, it sounds like a good idea. Please create PR and we will merge, so commit is with your name :smile:
所有者

one more thing: in the commit message please make sure to add something like "This resolves issue#2", so that gitea can pick it up and automatically link issue and commit in code.

one more thing: in the commit message please make sure to add something like "This resolves issue#2", so that gitea can pick it up and automatically link issue and commit in code.
MicheleC 新增至R14.0.6 release 里程碑 6 年之前
所有者

Resolved by PR #3

Resolved by PR https://mirror.git.trinitydesktop.org/gitea/TDE/yakuake/pulls/3
MicheleC closed this issue 6 年之前
登入 才能加入這對話。
未選擇里程碑
No Assignees
2 參與者
訊息
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/yakuake#2
Loading…
尚未有任何內容