#3 This resolves issue#2

Merged
MicheleC merged 2 commits from feat/reduScope into master 8 months ago
cethyel commented 8 months ago
There is no content yet.
MicheleC commented 8 months ago
Owner

Merged and pushed upstream.

Small note on code: it is not necessary to leave the old code commented out, since git tracks all changes and it is easy to see the difference with the previous version. This is just to keep the code cleaner, otherwise overtime the entire code base would become full of commented old code :smile:

Merged and pushed upstream. Small note on code: it is not necessary to leave the old code commented out, since git tracks all changes and it is easy to see the difference with the previous version. This is just to keep the code cleaner, otherwise overtime the entire code base would become full of commented old code :smile:
MicheleC deleted branch feat/reduScope 8 months ago
MicheleC commented 8 months ago
Owner

Resolves #2

Resolves #2
cethyel commented 8 months ago
Poster

Hi Michele,

I know it’s not a very good ideas to leave old code, but I’m still not comfortable with git, as a result I though that I could leave a comment and remove It few months later when some people have used/tested my changes.

Hi Michele, I know it's not a very good ideas to leave old code, but I'm still not comfortable with git, as a result I though that I could leave a comment and remove It few months later when some people have used/tested my changes.
MicheleC commented 8 months ago
Owner

no problem Greg :smile:

By the way have you noticed how the commit was automatically pickup up and referenced by gitea in the issue page? That is thanks to #2 in the commit comment :wink:

no problem Greg :smile: By the way have you noticed how the commit was automatically pickup up and referenced by gitea in the issue page? That is thanks to #2 in the commit comment :wink:
cethyel commented 8 months ago
Poster

Yes, that’s nice.

I’m not worry anymore with my changes, I’ll make sure to open issues with them and add details about It.

Yes, that's nice. I'm not worry anymore with my changes, I'll make sure to open issues with them and add details about It.
MicheleC commented 8 months ago
Owner

:+1:

:+1:
SlavekB added this to the R14.0.6 release milestone 6 months ago
The pull request has been merged.
Sign in to join this conversation.
Loading…
Cancel
Save
There is no content yet.