Merged and pushed upstream.
Small note on code: it is not necessary to leave the old code commented out, since git tracks all changes and it is easy to see the difference with the previous version. This is just to keep the code cleaner, otherwise overtime the entire code base would become full of commented old code :smile:
I know it’s not a very good ideas to leave old code, but I’m still not comfortable with git, as a result I though that I could leave a comment and remove It few months later when some people have used/tested my changes.
no problem Greg :smile:
By the way have you noticed how the commit was automatically pickup up and referenced by gitea in the issue page? That is thanks to #2 in the commit comment :wink:
Yes, that’s nice.
I’m not worry anymore with my changes, I’ll make sure to open issues with them and add details about It.
No due date set.
This pull request currently doesn't have any dependencies.
Deleting a branch is permanent. It CANNOT be undone. Continue?