This resolves issue#2 #3

Обединени
MicheleC обедини 1 ревизии от feat/reduScope във master преди 6 години
Ghost коментира преди 6 години
Все още няма съдържание.
MicheleC closed this pull request преди 6 години
Притежател

Merged and pushed upstream.

Small note on code: it is not necessary to leave the old code commented out, since git tracks all changes and it is easy to see the difference with the previous version. This is just to keep the code cleaner, otherwise overtime the entire code base would become full of commented old code 😄

Merged and pushed upstream. Small note on code: it is not necessary to leave the old code commented out, since git tracks all changes and it is easy to see the difference with the previous version. This is just to keep the code cleaner, otherwise overtime the entire code base would become full of commented old code :smile:
MicheleC deleted branch feat/reduScope преди 6 години
Притежател

Resolves #2

Resolves #2
Ghost коментира преди 6 години
Участник

Hi Michele,

I know it's not a very good ideas to leave old code, but I'm still not comfortable with git, as a result I though that I could leave a comment and remove It few months later when some people have used/tested my changes.

Hi Michele, I know it's not a very good ideas to leave old code, but I'm still not comfortable with git, as a result I though that I could leave a comment and remove It few months later when some people have used/tested my changes.
Притежател

no problem Greg 😄

By the way have you noticed how the commit was automatically pickup up and referenced by gitea in the issue page? That is thanks to #2 in the commit comment 😉

no problem Greg :smile: By the way have you noticed how the commit was automatically pickup up and referenced by gitea in the issue page? That is thanks to #2 in the commit comment :wink:
Ghost коментира преди 6 години
Участник

Yes, that's nice.

I'm not worry anymore with my changes, I'll make sure to open issues with them and add details about It.

Yes, that's nice. I'm not worry anymore with my changes, I'll make sure to open issues with them and add details about It.
Притежател

👍

:+1:
SlavekB added this to the R14.0.6 release milestone преди 6 години
Тази заявка за сливане е била обединена като bc7abd22d0.
Впишете се за да се присъедините към разговора.
No reviewers
Няма етап
Няма изпълнители
2 участника
Известия
Due Date

No due date set.

Зависимости

No dependencies set.

Reference: TDE/yakuake#3
Зареждане…
Все още няма съдържание.