This resolves issue#2 #3

Merged
MicheleC merged 1 commits from feat/reduScope into master 6 years ago
Ghost commented 6 years ago
There is no content yet.
MicheleC closed this pull request 6 years ago
Owner

Merged and pushed upstream.

Small note on code: it is not necessary to leave the old code commented out, since git tracks all changes and it is easy to see the difference with the previous version. This is just to keep the code cleaner, otherwise overtime the entire code base would become full of commented old code 😄

Merged and pushed upstream. Small note on code: it is not necessary to leave the old code commented out, since git tracks all changes and it is easy to see the difference with the previous version. This is just to keep the code cleaner, otherwise overtime the entire code base would become full of commented old code :smile:
MicheleC deleted branch feat/reduScope 6 years ago
Owner

Resolves #2

Resolves #2
Ghost commented 6 years ago
Poster

Hi Michele,

I know it's not a very good ideas to leave old code, but I'm still not comfortable with git, as a result I though that I could leave a comment and remove It few months later when some people have used/tested my changes.

Hi Michele, I know it's not a very good ideas to leave old code, but I'm still not comfortable with git, as a result I though that I could leave a comment and remove It few months later when some people have used/tested my changes.
Owner

no problem Greg 😄

By the way have you noticed how the commit was automatically pickup up and referenced by gitea in the issue page? That is thanks to #2 in the commit comment 😉

no problem Greg :smile: By the way have you noticed how the commit was automatically pickup up and referenced by gitea in the issue page? That is thanks to #2 in the commit comment :wink:
Ghost commented 6 years ago
Poster

Yes, that's nice.

I'm not worry anymore with my changes, I'll make sure to open issues with them and add details about It.

Yes, that's nice. I'm not worry anymore with my changes, I'll make sure to open issues with them and add details about It.
Owner

👍

:+1:
SlavekB added this to the R14.0.6 release milestone 6 years ago
The pull request has been merged as bc7abd22d0.
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/yakuake#3
Loading…
There is no content yet.