This resolves issue#2 #3

Злито
MicheleC злито 1 комітів з feat/reduScope до master 6 роки тому
Ghost прокоментував(ла) 6 роки тому
Тут ще немає жодного змісту.
MicheleC закрив цей запит на злиття 6 роки тому
MicheleC прокоментував(ла) 6 роки тому
Власник

Merged and pushed upstream.

Small note on code: it is not necessary to leave the old code commented out, since git tracks all changes and it is easy to see the difference with the previous version. This is just to keep the code cleaner, otherwise overtime the entire code base would become full of commented old code 😄

Merged and pushed upstream. Small note on code: it is not necessary to leave the old code commented out, since git tracks all changes and it is easy to see the difference with the previous version. This is just to keep the code cleaner, otherwise overtime the entire code base would become full of commented old code :smile:
MicheleC видалена гілка feat/reduScope 6 роки тому
MicheleC прокоментував(ла) 6 роки тому
Власник

Resolves #2

Resolves #2
Ghost прокоментував(ла) 6 роки тому
Автор

Hi Michele,

I know it's not a very good ideas to leave old code, but I'm still not comfortable with git, as a result I though that I could leave a comment and remove It few months later when some people have used/tested my changes.

Hi Michele, I know it's not a very good ideas to leave old code, but I'm still not comfortable with git, as a result I though that I could leave a comment and remove It few months later when some people have used/tested my changes.
MicheleC прокоментував(ла) 6 роки тому
Власник

no problem Greg 😄

By the way have you noticed how the commit was automatically pickup up and referenced by gitea in the issue page? That is thanks to #2 in the commit comment 😉

no problem Greg :smile: By the way have you noticed how the commit was automatically pickup up and referenced by gitea in the issue page? That is thanks to #2 in the commit comment :wink:
Ghost прокоментував(ла) 6 роки тому
Автор

Yes, that's nice.

I'm not worry anymore with my changes, I'll make sure to open issues with them and add details about It.

Yes, that's nice. I'm not worry anymore with my changes, I'll make sure to open issues with them and add details about It.
MicheleC прокоментував(ла) 6 роки тому
Власник

👍

:+1:
SlavekB додав(ла) до R14.0.6 release етапу 6 роки тому
Запит на злиття був влитиий як bc7abd22d0.
Підпишіться щоб приєднатися до обговорення.
Немає рецензентів
Етап відсутній
Немає виконавця
2 учасників
Сповіщення
Дата завершення

Термін виконання не встановлений.

Залежності

No dependencies set.

Reference: TDE/yakuake#3
Завантаження…
Тут ще немає жодного змісту.