Mavridis Philippe blu.256
  • Joined on May 03, 2019
Loading Heatmap…

blu.256 commented on pull request TDE/tdetoys#18

KWeather XDG icon names and icon theme support

@MicheleC >Great, we are all aligned here. Should default be old behavior (original icons) or new behavior (system icons)? I'm in favour of the new behaviour since: a) The default icon theme is…

2 weeks ago

blu.256 commented on pull request TDE/tdetoys#18

KWeather XDG icon names and icon theme support

Souds like a good idea.

2 weeks ago

blu.256 pushed to feat/kweather-std-icons at TDE/tdetoys

  • 56d015533a KWeather: Added fallbacks to "weather-snow"

2 weeks ago

blu.256 pushed to feat/kweather-std-icons at TDE/tdetoys

  • 0d1d4c5bfc KWeather: Use TDEIconLoader with absolute path to load icons.

2 weeks ago

blu.256 commented on pull request TDE/tdetoys#18

KWeather XDG icon names and icon theme support

Another problem: KWeather does not display scalable (SVG) icons. This is also probably related to your problem, @MicheleC: ``` icon:…

2 weeks ago

blu.256 commented on pull request TDE/tdetoys#18

KWeather XDG icon names and icon theme support

The new fallback code is ready for testing. It is now also (IMO) much cleaner an implementation, is easily extendable and provides enough alternatives/closest matches for every case.

2 weeks ago

blu.256 pushed to feat/kweather-std-icons at TDE/tdetoys

  • d8a52e2665 KWeather: improved fallback mechanism.

2 weeks ago

blu.256 pushed to feat/kweather-std-icons at TDE/tdetoys

2 weeks ago

blu.256 commented on pull request TDE/tdetoys#18

KWeather XDG icon names and icon theme support

Now that I'm looking through the rest of `metar_parser.cpp`, there isn't any possibility of this being < 0. So maybe this case should really be dismissed.

2 weeks ago

blu.256 commented on pull request TDE/tdetoys#18

KWeather XDG icon names and icon theme support

If you notice, wherever I use `iconName` instead of `name` I also use `return` instead of `break`. This is done in cases where there is no need for further execution (e.g. to append "-night" or…

2 weeks ago

blu.256 commented on pull request TDE/tdetoys#18

KWeather XDG icon names and icon theme support

I put it in a brackets block as suggested. Does it look clearer?

2 weeks ago

blu.256 pushed to feat/kweather-std-icons at TDE/tdetoys

2 weeks ago

blu.256 pushed to master at blu.256/tdetimer

2 weeks ago

blu.256 pushed to feat/kweather-std-icons at TDE/tdetoys

  • 156b6b597b KWeather: Fixed fallback to default icons

2 weeks ago

blu.256 commented on pull request TDE/tdetoys#18

KWeather XDG icon names and icon theme support

Tested on another machine, it seems broken here too except for one icon theme. I'll be looking into this regression. > Is it the log that can be enabled from KWeather applet config? No, I…

2 weeks ago

blu.256 commented on pull request TDE/tdetoys#18

KWeather XDG icon names and icon theme support

Hello, could you please report the debugging output of `kweatherservice`? It seemed to work on my machine. I'll be testing this on a clean VM later in the day, but your input coild prove valuable.

3 weeks ago

blu.256 pushed to master at blu.256/tdetimer

3 weeks ago

blu.256 created branch master in blu.256/tdetimer

3 weeks ago

blu.256 created repository blu.256/tdetimer

3 weeks ago

blu.256 pushed to feat/kweather-std-icons at TDE/tdetoys

3 weeks ago