OBATA Akio obache
  • Joined on Nov 11, 2018
Loading Heatmap…

obache commented on pull request TDE/libcarddav#4

Fix lock error handling

Just build fine without warning now.

1 month ago

obache pushed to feat/fix-lock-error-handling at TDE/libcarddav

  • ec688a1de7 Fix memory leak of lock error messages Signed-off-by: OBATA Akio <obache@wizdas.com>
  • 3baa47b7f2 Fix to set error code and message properly Signed-off-by: OBATA Akio <obache@wizdas.com>
  • e20690fb65 Fix memory leak of lock error messages Signed-off-by: OBATA Akio <obache@wizdas.com>
  • 489ec18bf0 Fix to set error code and message properly Signed-off-by: OBATA Akio <obache@wizdas.com>
  • Compare 4 commits »

1 month ago

obache pushed to feat/fix-lock-error-handling at TDE/libcarddav

  • e20690fb65 Fix memory leak of lock error messages Signed-off-by: OBATA Akio <obache@wizdas.com>

1 month ago

obache commented on pull request TDE/libcarddav#4

Fix lock error handling

work in progress, one commit per week, slowly :-P

1 month ago

obache pushed to feat/fix-lock-error-handling at TDE/libcarddav

  • 489ec18bf0 Fix to set error code and message properly Signed-off-by: OBATA Akio <obache@wizdas.com>
  • 1a35e5eb76 Simplify lock condition Change to handle as LOCK is not suuported for the case response of LOCK is unimplemented. Then * LOCKSUPPORT == FALSE: LOCK is not suuported * LOCKSUPPORT == TRUE: LOCK is supported * lock == 0: no LOCK error * lock == -1: failed to LOCK Signed-off-by: OBATA Akio <obache@wizdas.com>
  • 9897f19cf7 Simplify lock condition Change to handle as LOCK is not suuported for the case response of LOCK is unimplemented. Then * LOCKSUPPORT==FALSE: LOCK is not suuported * LOCKSUPPORT==TRUE: LOCK is supported * lock == 0: succeed to LOCK * lock == -1: failed to LOCK Signed-off-by: OBATA Akio <obache@wizdas.com>
  • Compare 3 commits »

1 month ago

obache created pull request TDE/libcarddav#4

WIP: Fix lock error handling

1 month ago

obache pushed to feat/fix-lock-error-handling at TDE/libcarddav

  • 9897f19cf7 Simplify lock condition Change to handle as LOCK is not suuported for the case response of LOCK is unimplemented. Then * LOCKSUPPORT==FALSE: LOCK is not suuported * LOCKSUPPORT==TRUE: LOCK is supported * lock == 0: succeed to LOCK * lock == -1: failed to LOCK Signed-off-by: OBATA Akio <obache@wizdas.com>

1 month ago

obache closed pull request TDE/libcaldav#2

Remove unwanted memory allocation for response

1 month ago

obache created pull request TDE/libcaldav#2

Remove unwanted memory allocation for response

1 month ago

obache pushed to feat/fix-malloc-memset-size at TDE/libcaldav

  • 9578e366c2 Remove unwanted memory allocation for response It is expected as pointer to struct response with size fo the struct, not pointer to the pointer, but never returned to the caller. It should be allocated by the caller. Signed-off-by: OBATA Akio <obache@wizdas.com>

1 month ago

obache closed pull request TDE/libcarddav#3

Clean up codes

1 month ago

obache created pull request TDE/libcarddav#3

Clean up codes

1 month ago

obache pushed to feat/clean-up-codes at TDE/libcarddav

  • 52200a5d4d Prevent to disclose static function in the header file Signed-off-by: OBATA Akio <obache@wizdas.com>
  • c4f584b28d Simplify string duplication Signed-off-by: OBATA Akio <obache@wizdas.com>
  • 5c66fbf273 Purge unused variables Signed-off-by: OBATA Akio <obache@wizdas.com>
  • Compare 3 commits »

1 month ago

obache pushed to feat/clean-up-codes at TDE/libcarddav

1 month ago

obache commented on issue TDE/libcarddav#2

Remove unwanted memory allocation for response

I've found some another questionable codes too, I wll try to send PR later.

1 month ago

obache closed pull request TDE/libcarddav#2

Remove unwanted memory allocation for response

1 month ago

obache commented on issue TDE/libcarddav#2

Remove unwanted memory allocation for response

`g_return_val_if_fail()` should return immediately if fail unless `G_DISABLE_CHECKS` is defined.

1 month ago

obache created pull request TDE/libcarddav#2

Remove unwanted memory allocation for response

1 month ago