Add man pages from TDE packaging repository. #8

Merged
MicheleC merged 2 commits from feat/man-pages into master 2 years ago
Owner

Man pages taken from TDE packaging repo.

In deb distros, to be built with TDE/tde-packaging#136

Man pages taken from TDE packaging repo. In deb distros, to be built with TDE/tde-packaging#136
MicheleC added 1 commit 2 years ago
eefd31eb46
Add man pages from TDE packaging repository.
MicheleC added this to the R14.0.13 release milestone 2 years ago
SlavekB reviewed 2 years ago
SlavekB left a comment
Owner

This looks good, but I believe that other changes in CMake rules should be mentioned in commit log – for example, a change that affects the way we use INCLUDE_INSTALL_DIR.

This looks good, but I believe that other changes in CMake rules should be mentioned in commit log – for example, a change that affects the way we use `INCLUDE_INSTALL_DIR`.
Poster
Owner

Should I split the changes over two commits? One for the cmake rules and one for the man files? Or simply reword the commit message?

Should I split the changes over two commits? One for the cmake rules and one for the man files? Or simply reword the commit message?
Owner

Originally, I only assumed to reword commit message. But it is true that these changes are independent of each other and that split into two commits seems to be a good idea.

Originally, I only assumed to reword commit message. But it is true that these changes are independent of each other and that split into two commits seems to be a good idea.
Poster
Owner

Ok, I will prepare that later today or this week.

Ok, I will prepare that later today or this week.
MicheleC force-pushed feat/man-pages from eefd31eb46 to 10a0510943 2 years ago
Poster
Owner

I splitted the changes into two commits, one for the path and one for the man pages.

I splitted the changes into two commits, one for the path and one for the man pages.
SlavekB approved these changes 2 years ago
SlavekB left a comment
Owner

It looks good.

It looks good.
MicheleC merged commit 10a0510943 into master 2 years ago
MicheleC deleted branch feat/man-pages 2 years ago

Reviewers

SlavekB approved these changes 2 years ago
The pull request has been merged as 10a0510943.
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Reference: TDE/arts#8
Loading…
There is no content yet.