Conversion to the cmake building system. #2

Merged
SlavekB merged 1 commits from feat/cmakeConv into master 2 years ago
Owner
There is no content yet.
SlavekB added this to the R14.0.13 release milestone 2 years ago
SlavekB added 1 commit 2 years ago
2239151696
Conversion to the cmake building system.
MicheleC reviewed 2 years ago
CMakeLists.txt Outdated
###### global compiler settings
add_definitions( -DHAVE_CONFIG_H -UTQT_NO_STL )
Owner

Any particular reason on having "-UTQT_NO_STL"?

Any particular reason on having "-UTQT_NO_STL"?
Poster
Owner

You are right – there was a good idea to look at each case in more detail, so that it was only two cases where it was enough to add .c_str(). I originally worried that there would be more problems. At the same time, there have been cases for which it seems better to use local8Bit() instead of latin1(). Patch updated.

You are right – there was a good idea to look at each case in more detail, so that it was only two cases where it was enough to add `.c_str()`. I originally worried that there would be more problems. At the same time, there have been cases for which it seems better to use `local8Bit()` instead of `latin1()`. Patch updated.
MicheleC reviewed 2 years ago
tqtcairopainter.cpp
LINK
tdeui-shared
Owner

Different indentation between lines 26 and 29

Different indentation between lines 26 and 29
MicheleC reviewed 2 years ago
tdegtk-theme.cpp
LINK
tdecore-shared
Owner

Different indentation between sources and link libraries

Different indentation between sources and link libraries
MicheleC reviewed 2 years ago
tde_add_check_executable( test-widgets AUTOMOC
SOURCES
test-widgets.c
Owner

Different indentation between sources and link libraries

Different indentation between sources and link libraries
MicheleC reviewed 2 years ago
tde_add_check_executable( test-painter AUTOMOC
SOURCES
test-painter.cpp
Owner

Different indentation between sources and link libraries

Different indentation between sources and link libraries
Owner

We usually indent by 2 spaces under SOURCES/LINK, so it would be good to keep the same indentation

We usually indent by 2 spaces under SOURCES/LINK, so it would be good to keep the same indentation
SlavekB force-pushed feat/cmakeConv from 2239151696 to ab1ffd3b58 2 years ago
Poster
Owner

We usually indent by 2 spaces under SOURCES/LINK, so it would be good to keep the same indentation

I used a template from the code from Greg, where he used different levels of indentation, although it is the same meaning. I edited it to make it the same.

> We usually indent by 2 spaces under SOURCES/LINK, so it would be good to keep the same indentation I used a template from the code from Greg, where he used different levels of indentation, although it is the same meaning. I edited it to make it the same.
SlavekB force-pushed feat/cmakeConv from ab1ffd3b58 to fe56f701d7 2 years ago
MicheleC approved these changes 2 years ago
MicheleC left a comment
Owner

Looks good.

Looks good.
SlavekB merged commit fe56f701d7 into master 2 years ago
SlavekB deleted branch feat/cmakeConv 2 years ago

Reviewers

MicheleC approved these changes 2 years ago
The pull request has been merged as fe56f701d7.
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/gtk3-tqt-engine#2
Loading…
There is no content yet.