Conversion to the cmake building system. #2
Merged
SlavekB
merged 1 commits from feat/cmakeConv
into master
2 years ago
Loading…
Reference in new issue
There is no content yet.
Delete Branch 'feat/cmakeConv'
Deleting a branch is permanent. It CANNOT be undone. Continue?
###### global compiler settings
add_definitions( -DHAVE_CONFIG_H -UTQT_NO_STL )
Any particular reason on having "-UTQT_NO_STL"?
You are right – there was a good idea to look at each case in more detail, so that it was only two cases where it was enough to add
.c_str()
. I originally worried that there would be more problems. At the same time, there have been cases for which it seems better to uselocal8Bit()
instead oflatin1()
. Patch updated.tqtcairopainter.cpp
LINK
tdeui-shared
Different indentation between lines 26 and 29
tdegtk-theme.cpp
LINK
tdecore-shared
Different indentation between sources and link libraries
tde_add_check_executable( test-widgets AUTOMOC
SOURCES
test-widgets.c
Different indentation between sources and link libraries
tde_add_check_executable( test-painter AUTOMOC
SOURCES
test-painter.cpp
Different indentation between sources and link libraries
We usually indent by 2 spaces under SOURCES/LINK, so it would be good to keep the same indentation
2239151696
toab1ffd3b58
2 years agoI used a template from the code from Greg, where he used different levels of indentation, although it is the same meaning. I edited it to make it the same.
ab1ffd3b58
tofe56f701d7
2 years agoLooks good.
fe56f701d7
into master 2 years agoReviewers
fe56f701d7
.