Labels Milestones

Fix problems for older ffmpeg versions #16

Merged

SlavekB merged 1 commits from ffmpeg-fix into master 2 years ago

Conversation 3 Commits 1 Files Changed 1

aneejit1 commented 2 years ago

Collaborator

Fix the following issues when building against older ffmpeg versions

• the call to avcodec_free_context exceptions as avformat_close_input already performs cleanup of the AVCodecContext, so link the calling of avcodec_free_context in k3bffmpegwrapper.cpp to the version of libavformat in which codecpar appeared rather than when avcodec_free_context appeared.
• avcodec_decode_audio4 was deprecated in libavcodec 57.106.100, not 57.12.100, so the version has been corrected.

Signed-off-by: aneejit1 aneejit1@gmail.com

Fix the following issues when building against older ffmpeg versions - the call to avcodec_free_context exceptions as avformat_close_input already performs cleanup of the AVCodecContext, so link the calling of avcodec_free_context in k3bffmpegwrapper.cpp to the version of libavformat in which codecpar appeared rather than when avcodec_free_context appeared. - avcodec_decode_audio4 was deprecated in libavcodec 57.106.100, not 57.12.100, so the version has been corrected. Signed-off-by: aneejit1 <aneejit1@gmail.com>

aneejit1 added 1 commit 2 years ago

6547c2d255 Fix problems for older ffmpeg versions ...

Fix the following issues when building against older ffmpeg versions

- the call to avcodec_free_context exceptions as avformat_close_input
  already performs cleanup of the AVCodecContext, so link the calling of
  avcodec_free_context in the close method of k3bffmpegwrapper.cpp to
  the version of libavformat in which codecpar appeared rather than when
  avcodec_free_context appeared.
- avcodec_decode_audio4 was deprecated in libavcodec 57.106.100, not
  57.12.100, so the version has been corrected.

Signed-off-by: aneejit1 <aneejit1@gmail.com>

Ray-V commented 2 years ago

Collaborator

That works for ffmpeg-3.0.9

Builds, runs, and tested ffmpeg decoder by converting a .wma to .wav and .flac

That works for ffmpeg-3.0.9 Builds, runs, and tested ffmpeg decoder by converting a .wma to .wav and .flac

aneejit1 force-pushed ffmpeg-fix from 6547c2d255 to 18ea1e7a94 2 years ago

aneejit1 commented 2 years ago

Poster

Collaborator

Super! I've updated the avcodec_receive_frame/avcodec_send_packet on k9copy and I'll start looking at doing the same to akode.

Latest push here is just to correct the commit message.

Super! I've updated the avcodec_receive_frame/avcodec_send_packet on k9copy and I'll start looking at doing the same to akode. Latest push here is just to correct the commit message.

aneejit1 commented 2 years ago

Poster

Collaborator

I've done the update for akode.

I've done the update for akode.

SlavekB approved these changes 2 years ago

SlavekB left a comment

Owner

Thank you, it looks good.

Thank you, it looks good.

SlavekB merged commit 18ea1e7a94 into master 2 years ago

SlavekB deleted branch ffmpeg-fix 2 years ago

SlavekB added this to the R14.0.13 release milestone 2 years ago

MicheleC referenced this pull request from TDE/tde 2 years ago

R14.0.13 release notes #83

Reviewers

SlavekB approved these changes 2 years ago

The pull request has been merged as 18ea1e7a94.

Sign in to join this conversation.

Reviewers

Request review

No reviewers

SlavekB

Labels

Apply labels

Clear labels

GE/need-info
General - need additional info from contributor PR/keep-branch
Pull request - do not delete branch after merging PR/not-ok
Pull request - need fixing PR/rfc
Pull request - request for comments PR/update-trans
Pull request - update to translation files needed PR/wip
Pull request - work in progress RS/R14.0.x
Related to R14.0.x series RS/R14.1.x
Related to R14.1.x series SL/critical
Severity level - critical SL/major
Severity level - major SL/minor
Severity level - minor SL/normal
Severity level - normal SL/regression
Severity level - regression from previous version SL/trivial
Severity level - trivial SL/wishlist
Severity level - wishlist request ST/duplicate
Status - duplicate of another issue ST/invalid
Status - invalid report ST/notourproblem
Status - not our problem ST/rejected
Status - rejected ST/wontfix
Status - won't fix ST/worksforme
Status - works for me, unable to reproduce

No Label GE/need-info PR/keep-branch PR/not-ok PR/rfc PR/update-trans PR/wip RS/R14.0.x RS/R14.1.x SL/critical SL/major SL/minor SL/normal SL/regression SL/trivial SL/wishlist ST/duplicate ST/invalid ST/notourproblem ST/rejected ST/wontfix ST/worksforme

Milestone

Set milestone

Clear milestone

No items

No Milestone

R14.0.13 release

Assignees

Assign users

Clear assignees

No Assignees

3 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: TDE/k3b#16

Write Preview

Loading…

Cancel

Save

There is no content yet.