Make sip_api_get_address a public API function #8
Merged
SlavekB
merged 1 commits from public-get-address into master 2 years ago
SlavekB
Loading…
Reference in new issue
There is no content yet.
Delete Branch 'public-get-address'
Deleting a branch is permanent. It CANNOT be undone. Continue?
The sipGetAddress function has been renamed as sip_api_get_address and made available as part of the public API.
Signed-off-by: aneejit1 aneejit1@gmail.com
Just a question: what is the reason behind this change? Is the function used by other modules? I am not saying the change is wrong, just want to have some understanding.
The function is needed as part of the resolution to the "underlying C/C++ object has been deleted" problem with python-tqt. I needed to be able to access the CppPtr but that process is not a simple one and required the function call in order to do it properly without duplicating the code. Part of this was already implemented in the form of the "sipGetAddress" macro that tried to access a field that wasn't in the API struct, it's just that the work to make the actual function public hadn't been done.
Ok, thanks for explanation :-)
It looks good.
b92a3b0a4einto master 2 years agoReviewers
b92a3b0a4e.