TDE
/
tde-packaging
9
1
Fork 1
Code Issues 10 Pull Requests Releases Wiki Activity
Labels Milestones

DEB kstreamripper: switched to cmake. #64

Merged
MicheleC merged 1 commits from feat/kstreamripper-cmake into master 4 years ago
Conversation 2 Commits 1 Files Changed 20
MicheleC commented 4 years ago
Owner

To be used with TDE/kstreamripper#2

To be used with TDE/kstreamripper#2
MicheleC added this to the R14.0.8 release milestone 4 years ago
SlavekB reviewed 4 years ago
SlavekB left a comment
Owner

There are a few other things that can be done here – see comments.

There are a few other things that can be done here – see comments.
debian/_base/applications/kstreamripper/debian/control Outdated
Priority: optional
Maintainer: Michael Ablassmeier <abi@debian.org>
Build-Depends: debhelper (>= 9~), cdbs, libxmu-dev, libjpeg-dev, tdelibs14-trinity-dev, scons
Build-Depends: debhelper (>= 9~), cdbs, libxmu-dev, libjpeg-dev, tdelibs14-trinity-dev, cmake, quilt
SlavekB commented 4 years ago
Owner

It seems that explicit libxmu-dev and libjpeg-dev dependencies are not needed because they are installed automatically due to TQt3 dependencies.

It seems that explicit `libxmu-dev` and `libjpeg-dev` dependencies are not needed because they are installed automatically due to TQt3 dependencies.
SlavekB commented 4 years ago
Owner
  1. AUTHORS can be added to docs to match the original package.
  2. The kstreamripper.desktop is part of the source package. Therefore, I think that a similar file can be removed from DEB packaging. Then we will no longer need kstreamripper-trinity.install.
1. `AUTHORS` can be added to `docs` to match the original package. 2. The `kstreamripper.desktop` is part of the source package. Therefore, I think that a similar file can be removed from DEB packaging. Then we will no longer need `kstreamripper-trinity.install`.
MicheleC commented 4 years ago
Poster
Owner
  1. AUTHORS can be added to docs to match the original package.
  2. The kstreamripper.desktop is part of the source package. Therefore, I think that a similar file can be removed from DEB packaging. Then we will no longer need kstreamripper-trinity.install.

PR updated as per comments.

> 1. `AUTHORS` can be added to `docs` to match the original package. > 2. The `kstreamripper.desktop` is part of the source package. Therefore, I think that a similar file can be removed from DEB packaging. Then we will no longer need `kstreamripper-trinity.install`. PR updated as per comments.
MicheleC closed this pull request 4 years ago
MicheleC deleted branch feat/kstreamripper-cmake 4 years ago
The pull request has been merged as 0038f7fc68.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
Labels
Apply labels
Clear labels
GE/need-info
General - need additional info from contributor PR/keep-branch
Pull request - do not delete branch after merging PR/not-ok
Pull request - need fixing PR/rfc
Pull request - request for comments PR/update-trans
Pull request - update to translation files needed PR/wip
Pull request - work in progress RS/R14.0.x
Related to R14.0.x series RS/R14.1.x
Related to R14.1.x series SL/critical
Severity level - critical SL/major
Severity level - major SL/minor
Severity level - minor SL/normal
Severity level - normal SL/regression
Severity level - regression from previous version SL/trivial
Severity level - trivial SL/wishlist
Severity level - wishlist request ST/duplicate
Status - duplicate of another issue ST/invalid
Status - invalid report ST/notourproblem
Status - not our problem ST/rejected
Status - rejected ST/wontfix
Status - won't fix ST/worksforme
Status - works for me, unable to reproduce
No Label GE/need-info PR/keep-branch PR/not-ok PR/rfc PR/update-trans PR/wip RS/R14.0.x RS/R14.1.x SL/critical SL/major SL/minor SL/normal SL/regression SL/trivial SL/wishlist ST/duplicate ST/invalid ST/notourproblem ST/rejected ST/wontfix ST/worksforme
Milestone
Set milestone
Clear milestone
No items
No Milestone
R14.0.8 release
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/tde-packaging#64
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'feat/kstreamripper-cmake'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes