Drop support for python2. #12

Merged
MicheleC merged 2 commits from feat/drop-python-2 into master 1 year ago
Owner

Needs TDE/tde-common-admin#15.

On deb distro, to be built with TDE/tde-packaging#187

Needs TDE/tde-common-admin#15. On deb distro, to be built with TDE/tde-packaging#187
MicheleC added this to the R14.1.0 release milestone 1 year ago
MicheleC added 1 commit 1 year ago
0cd2cccdce
Drop support for python2.
MicheleC requested review from SlavekB 1 year ago
SlavekB reviewed 1 year ago
SlavekB left a comment
Owner

It looks good and building is successful. Only there I am not sure about changing the default location for Python modules – see the comment below.

It looks good and building is successful. Only there I am not sure about changing the default location for Python modules – see the comment below.
pyt_DATA = pydcop.py
pytdir = $(PYTHONMODDIR)/site-packages
pytdir = $(PYTHONMODDIR)/dist-packages
SlavekB commented 1 year ago
Owner

I believe that the default location should be site-packages, because this is the case when the package is built by an ordinary user. Placement in dist-packages should be provided either to enter the build option or by relocation within the packaging. We have to verify how it is done in other packages.

I believe that the default location should be `site-packages`, because this is the case when the package is built by an ordinary user. Placement in `dist-packages` should be provided either to enter the build option or by relocation within the packaging. We have to verify how it is done in other packages.
SlavekB commented 1 year ago
Owner

I've added a second commit, which instead of the hard-coded site-packages / dist-packages, uses detection of the configuration from detected Python. When building a Debian package it returns the path to dist-packages as we need.

I've added a second commit, which instead of the hard-coded `site-packages` / `dist-packages`, uses detection of the configuration from detected Python. When building a Debian package it returns the path to `dist-packages` as we need.
Poster
Owner

It looks good.

It looks good.
SlavekB marked this conversation as resolved
SlavekB added 1 commit 1 year ago
SlavekB force-pushed feat/drop-python-2 from 3c426c3906 to d85bd77116 1 year ago
SlavekB commented 1 year ago
Owner

Rebased to the current head and reversed the order of commits.

Rebased to the current head and reversed the order of commits.
SlavekB approved these changes 1 year ago
SlavekB left a comment
Owner

Now everything looks as needed.

Now everything looks as needed.
MicheleC merged commit d85bd77116 into master 1 year ago
MicheleC deleted branch feat/drop-python-2 1 year ago

Reviewers

SlavekB approved these changes 1 year ago
The pull request has been merged as d85bd77116.
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Depends on
Reference: TDE/tdebindings#12
Loading…
There is no content yet.