WIP: Fixed support for freeze/standby/suspend/hybrid suspend/hibernate #2

Draft
MicheleC wants to merge 10 commits from feat/fix-suspend-code into master
Owner
Suggest to compile TDE/tdebase#16 after this. Based on info from here: https://www.kernel.org/doc/Documentation/power/states.txt https://www.kernel.org/doc/Documentation/power/interface.txt
MicheleC added this to the R14.1.0 release milestone 6 years ago
Owner

It looks like /sys/power/mem_sleep is new from kernel >= 4.14. We need functionality even for older versions of kernels. The code needs to be changed.

It looks like /sys/power/mem_sleep is new from kernel >= 4.14. We need functionality even for older versions of kernels. The code needs to be changed.
SlavekB added the PR/not-ok label 6 years ago
Poster
Owner

yes, as I mentioned yesterday on the chat, I need to fix support for when mem_sleep is not available. I will work on this during the weekend.

In the current PR, it only affects "Suspend".

yes, as I mentioned yesterday on the chat, I need to fix support for when mem_sleep is not available. I will work on this during the weekend. In the current PR, it only affects "Suspend".
MicheleC added PR/wip and removed PR/not-ok labels 6 years ago
MicheleC removed the PR/wip label 6 years ago
Poster
Owner

PR should now be able to support both older and newer kernel.

PR should now be able to support both older and newer kernel.
Poster
Owner

I have tested this (together with TDE/tdebase#16) under Slackware in a VirtualBox machines.

The options displayed on the shutdown dialog are consistent with the content of /sys/power/state and /sys/power/disk and their functionality works fine.

I could test freeze, hibernate and hybrid hibernate. The last two behaves the same in this system, since there is no support for suspend-to-RAM but /sys/power/disk contains "suspend"

I have tested this (together with TDE/tdebase#16) under Slackware in a VirtualBox machines. The options displayed on the shutdown dialog are consistent with the content of /sys/power/state and /sys/power/disk and their functionality works fine. I could test freeze, hibernate and hybrid hibernate. The last two behaves the same in this system, since there is no support for suspend-to-RAM but /sys/power/disk contains "suspend"
Poster
Owner

Rebased to latest master. IMO, this PR is ready for merging.

Rebased to latest master. IMO, this PR is ready for merging.
Poster
Owner

as per discussion on jabber, more work is required to allow user hibernation

as per discussion on jabber, more work is required to allow user hibernation
Poster
Owner

This is hopefully the final one 😄

Tested as simple user and as root, all available actions are possible. Actions tested are freeze, suspend, hydrid suspend and hibernate

This is hopefully the final one :smile: Tested as simple user and as root, all available actions are possible. Actions tested are freeze, suspend, hydrid suspend and hibernate
MicheleC changed title from Fixed support for freeze/standby/suspend/hybrid suspend/hibernate to WIP: Fixed support for freeze/standby/suspend/hybrid suspend/hibernate 5 years ago
MicheleC changed title from WIP: Fixed support for freeze/standby/suspend/hybrid suspend/hibernate to Fixed support for freeze/standby/suspend/hybrid suspend/hibernate 5 years ago
Poster
Owner

new version with polkit support

new version with polkit support
Poster
Owner

I have added DBus standard interface Introspect, Peer and Properties to the tde hw daemon. This should solve issue #9 and #12.

I have added DBus standard interface Introspect, Peer and Properties to the tde hw daemon. This should solve issue #9 and #12.
MicheleC changed title from Fixed support for freeze/standby/suspend/hybrid suspend/hibernate to WIP: Fixed support for freeze/standby/suspend/hybrid suspend/hibernate 5 years ago
Poster
Owner

I see two potential side effect, but need further testing to make sure they are related to this PR. Further testing is needed before merge. Core functionality is there though.

I see two potential side effect, but need further testing to make sure they are related to this PR. Further testing is needed before merge. Core functionality is there though.
SlavekB modified the milestone from R14.1.0 release to R14.1.x 1 year ago
This pull request has changes conflicting with the target branch.
tdecore/tdehw/hwlibdaemons/dbus/org.trinitydesktop.hardwarecontrol.conf
tdecore/tdehw/tderootsystemdevice.cpp
tdecore/tdehw/tderootsystemdevice.h
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/tdelibs#2
Loading…
There is no content yet.