dcopclient: Fix TQMap/TQValueList display #168

Merged
blu.256 merged 2 commits from issue/166 into master 2 years ago
Collaborator

This was caused by dcopclient not taking into account that the length of some classes was changed due to the renaming (e.g. QMap->TQMap => 4->5).

This fixes issue #166.

This was caused by dcopclient not taking into account that the length of some classes was changed due to the renaming (e.g. QMap->TQMap => 4->5). This fixes issue #166.
blu.256 added this to the R14.0.13 release milestone 2 years ago
blu.256 added 1 commit 2 years ago
46435f6c1c
dcopclient: Fixed TQMap/TQValueList display.
blu.256 requested review from MicheleC 2 years ago
Poster
Collaborator

Tested sucessfully with the following DCOP calls:

  • dcop $(dcopfind konqueror-\* konqueror-mainwindow#1) actions
    (type TQValueList<TQCString>)
  • dcop $(dcopfind konqueror-\* konqueror-mainwindow#1) actionMap
    (type TQMap<TQCString,DCOPRef>)
Tested sucessfully with the following DCOP calls: * `dcop $(dcopfind konqueror-\* konqueror-mainwindow#1) actions` (type `TQValueList<TQCString>`) * `dcop $(dcopfind konqueror-\* konqueror-mainwindow#1) actionMap` (type `TQMap<TQCString,DCOPRef>`)
Owner

It looks better. But maybe still something to look at. Try:
dcop kded mediamanager fullList
or
dcop kded mediamanager properties /dev/sda1 (or other partition...)
It prints a lot of empty lines while instead in KDCOP you can see the actual output.

It looks better. But maybe still something to look at. Try: ```dcop kded mediamanager fullList``` or ```dcop kded mediamanager properties /dev/sda1 (or other partition...)``` It prints a lot of empty lines while instead in KDCOP you can see the actual output.
blu.256 added 1 commit 2 years ago
5bd33795a7
dcopclient: Fix TQStringList handling.
Owner

Works like a charm now! Well done.

Works like a charm now! Well done.
MicheleC approved these changes 2 years ago
Owner

When you backport, please check whether any changes are required for R14.0.x. I think we may have made some changes in master to dcop that we didn't backport, but not sure 100%. That would have been several years ago.

When you backport, please check whether any changes are required for R14.0.x. I think we may have made some changes in master to dcop that we didn't backport, but not sure 100%. That would have been several years ago.
blu.256 merged commit 5bd33795a7 into master 2 years ago
blu.256 deleted branch issue/166 2 years ago
Owner

@blu.256 is it okay that backported for r14.0.x was only one of the three commits that were the subject of this PR?

@blu.256 is it okay that backported for r14.0.x was only one of the three commits that were the subject of this PR?
Owner

@blu.256 is it okay that backported for r14.0.x was only one of the three commits that were the subject of this PR?

@blu.256 I think commit 46435f6c needs to be backported as well.

@SlavekB Commit 8d0bae40 does not need to be backported because TQStringVariantMap does not exist in R14.0.x

> @blu.256 is it okay that backported for r14.0.x was only one of the three commits that were the subject of this PR? @blu.256 I think commit 46435f6c needs to be backported as well. @SlavekB Commit 8d0bae40 does not need to be backported because TQStringVariantMap does not exist in R14.0.x
Poster
Collaborator

Backported 46435f6c too (I thought I had backported both though?).

Backported 46435f6c too (I thought I had backported both though?).
Owner

Great, thanks

Great, thanks
Owner

Great, now also in r14.0.x it behaves as expected.

Great, now also in r14.0.x it behaves as expected.

Reviewers

MicheleC approved these changes 2 years ago
The pull request has been merged as 5bd33795a7.
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
3 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/tdelibs#168
Loading…
There is no content yet.