TDE
/
tdelibs
7
1
Fork 0
Code Issues 16 Pull Requests 8 Releases Wiki Activity
Labels Milestones

KSSL: Add names for OpenSSL 3.x libraries to SSL libraries search. #177

Merged
SlavekB merged 1 commits from issue/176/search-for-openssl-3.x into master 2 years ago
Conversation 1 Commits 1 Files Changed 1
SlavekB commented 2 years ago
Owner

This relates to issue #176.

I do not know whether it makes sense to make an effort to search for various libssl.so.[0-9], because the names do not change too often.

This relates to issue #176. I do not know whether it makes sense to make an effort to search for various `libssl.so.[0-9]`, because the names do not change too often.
MicheleC approved these changes 2 years ago
MicheleC left a comment
Owner

Looks good.

Looks good.
SlavekB force-pushed issue/176/search-for-openssl-3.x from 8f314ced69 to cb87252f7d 2 years ago
SlavekB commented 2 years ago
Poster
Owner

I examined the problem further and found that the openssl < 3.x defines the SHLIB_VERSION_NUMBER, which is used in the KSSL for the default name in the search for a library. In openssl >= 3.x this constant not exists and there is a new constant OPENSSL_SHLIB_VERSION. Therefore I added the use of this new constant for the default name in search of the library.

I examined the problem further and found that the openssl < 3.x defines the `SHLIB_VERSION_NUMBER`, which is used in the KSSL for the default name in the search for a library. In openssl >= 3.x this constant not exists and there is a new constant `OPENSSL_SHLIB_VERSION`. Therefore I added the use of this new constant for the default name in search of the library.
SlavekB requested review from MicheleC 2 years ago
MicheleC approved these changes 2 years ago
MicheleC left a comment
Owner

This looks even better!

This looks even better!
SlavekB merged commit cb87252f7d into master 2 years ago
SlavekB deleted branch issue/176/search-for-openssl-3.x 2 years ago
SlavekB added this to the R14.0.13 release milestone 2 years ago

Reviewers

MicheleC approved these changes 2 years ago
The pull request has been merged as cb87252f7d.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
MicheleC
Labels
Apply labels
Clear labels
GE/need-info
General - need additional info from contributor PR/keep-branch
Pull request - do not delete branch after merging PR/not-ok
Pull request - need fixing PR/rfc
Pull request - request for comments PR/update-trans
Pull request - update to translation files needed PR/wip
Pull request - work in progress RS/R14.0.x
Related to R14.0.x series RS/R14.1.x
Related to R14.1.x series SL/critical
Severity level - critical SL/major
Severity level - major SL/minor
Severity level - minor SL/normal
Severity level - normal SL/regression
Severity level - regression from previous version SL/trivial
Severity level - trivial SL/wishlist
Severity level - wishlist request ST/duplicate
Status - duplicate of another issue ST/invalid
Status - invalid report ST/notourproblem
Status - not our problem ST/rejected
Status - rejected ST/wontfix
Status - won't fix ST/worksforme
Status - works for me, unable to reproduce
No Label GE/need-info PR/keep-branch PR/not-ok PR/rfc PR/update-trans PR/wip RS/R14.0.x RS/R14.1.x SL/critical SL/major SL/minor SL/normal SL/regression SL/trivial SL/wishlist ST/duplicate ST/invalid ST/notourproblem ST/rejected ST/wontfix ST/worksforme
Milestone
Set milestone
Clear milestone
No items
No Milestone
R14.0.13 release
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/tdelibs#177
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'issue/176/search-for-openssl-3.x'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes