CMake conversion #4

As per title. Builds and seems to works fine.

In DEB distros, to be built with TDE/tde-packaging#126

In addition to the comments below, there is a note on all translations:

The CMake code used works well, but as you can see in tde_add_project_translations, we now take into account the variable LINGUAS to influence what translations will be installed. This is mainly used by distributions that build from the source code instead of binary packages. We could consider the way to use tde_add_project_translations to make the behavior identical. This could be achieved for plugins when the translations were placed in a subdirectory according to the name of the generated file. For example plugins/alsa-sound/po/tderadio-alsa-sound/.... Such a location would allow easy use of macro tde_add_project_translations and thus gain the same behavior. For the translation of the application as such, this macro can be used immediately, without the need to change the location.

All point addressed.

To install translations, we should take into account the variable LINGUAS. Therefore, either we have to add its processing to CMake rules in all plugins, such as is in tde_add_project_translations macro or change the location of translations in plugins, as mentioned in the previous review.

Updated based on the feedback received.

To properly use a variable LINGUAS for plugins translations (and convert-presets), one of the following is needed:

Change the translation location so that they are in the subfolder by name of the target file – for example plugins/alsa-sound/po/tderadio-alsa-sound/, and then can be used macro tde_add_project_translations().
Edit the CMakeLists.txt in all plugins to include the processing of variable LINGUAS such as in tde_add_project_translations – for example in plugins/alsa-sound/po:

  file( GLOB po_files RELATIVE ${CMAKE_CURRENT_SOURCE_DIR} *.po )  
  string( REGEX REPLACE "[ \r\n\t]+" ";" _linguas "$ENV{LINGUAS}" )

  foreach( _po ${po_files} )
    get_filename_component( _lang ${_po} NAME_WE )
    if( "${_linguas}" MATCHES "^;*$" OR ";${_linguas};" MATCHES ";${_lang};" )
      tde_create_translation( FILES ${_po} LANG ${_lang} OUTPUT_NAME tderadio-alsa-sound )
    endif( )
  endforeach( )

Thanks for the feedback @SlavekB. PR updated as per option 1. I have made a separate commit since moving files around also affects makefiles.

Thanks for the feedback @SlavekB. PR updated as per option 1. I have made a separate commit since moving files around also affects makefiles.

Yes, it makes sense and it looks good. The last small thing remains – adjust all CMakeL10n rules and add / for all the names of the catalogs. For example, CATALOG "tderadio-alsa-sound" change to CATALOG "tderdio-alsa-sound/". This ensures that the POT files will be generated into the newly created subfolder.

Thanks for the feedback @SlavekB. PR updated as per option 1. I have made a separate commit since moving files around also affects makefiles.

Oh, I forgot one thing – to avoid losing history in TWTW, we need translations and catalogs first copy to a new location, then edit TWTW configuration and only then remove files from the original location.

Yes, it makes sense and it looks good. The last small thing remains – adjust all CMakeL10n rules and add / for all the names of the catalogs. For example, CATALOG "tderadio-alsa-sound" change to CATALOG "tderdio-alsa-sound/". This ensures that the POT files will be generated into the newly created subfolder.

yeah, my bad for not testing that part :-(

Oh, I forgot one thing – to avoid losing history in TWTW, we need translations and catalogs first copy to a new location, then edit TWTW configuration and only then remove files from the original location.

yes, I may actually do the move of the files first as a separate task, then the cmake conversion on top of that. I will have a look later.

Rebased on top of current master and issues mentioned above addressed.

Everything looks good.

 if( WITH_ALSA )
   find_package( ALSA )
   if( NOT ALSA_FOUND )
     message(FATAL_ERROR "\nalsa support is requested, but was not found on your system" )

 if( WITH_LIRC )
   pkg_search_module( LIRC lirc )
   if( NOT LIRC_FOUND )
     message(FATAL_ERROR "\nlirc support is requested, but was not found on your system" )

   SOURCES
     streaming.cpp streaming-configuration-ui.ui
     streaming-configuration.cpp streaming-job.cpp
   LINK tderadio-shared

 option( BUILD_ALL          "Build all"           ON           )
 option( BUILD_DOC          "Build documentation" ${BUILD_ALL} )
 option( BUILD_OSS_PLUGIN   "Build OSS plugin"    ${BUILD_ALL} )

 pkg_search_module( SNDFILE sndfile )
 if( NOT SNDFILE_FOUND )
   tde_message_fatal( "sndfile is requested, but was not found on your system" )

 #cmakedefine WORDS_BIGENDIAN @WORDS_BIGENDIAN@
 // Defined if ALSA support found
 #cmakedefine HAVE_ALSA

 #cmakedefine HAVE_LAME
 // Defined if LIRC support found
 #cmakedefine HAVE_LIRC

     recording-monitor.cpp encoder_mp3.cpp encoder_ogg.cpp encoder_pcm.cpp
   LINK tderadio-shared ${LAME_LIBRARIES} ${OGG_LIBRARIES} ${VORBIS_LIBRARIES}
   ${VORBISFILE_LIBRARIES} ${VORBISENC_LIBRARIES} ${SNDFILE_LIBRARIES}

 ##### other data
 INSTALL(
   FILES tderadio.desktop

 tde_create_translated_desktop(
   SOURCE tderadio.desktop
   DESTINATION ${XDG_APPS_INSTALL_DIR}

 file( GLOB _srcs RELATIVE ${CMAKE_CURRENT_SOURCE_DIR} *.po )
 if( _srcs )
    tde_create_translation( LANG auto OUTPUT_NAME tderadio )

				`add_definitions (`
				`-UTQT_NO_ASCII_CAST`

CMake conversion #4

Reviewers