Labels Milestones

New Issue

Build issue: FTBFS on Fedora 40 #23

Closed

opened 2 weeks ago by Francois · 14 comments

Francois commented 2 weeks ago

Collaborator

Basic information

• TDE version: 14.1.2
• Distribution: Fedora 40
• Hardware: amd64

Description

FTBFS

Steps to reproduce

Build

Screenshots

open.c: At top level:
open.c:276:1: error: return type defaults to 'int' [-Wimplicit-int]
  276 | fk_open(int seq, int fmt, ftnint n)
      | ^~~~~~~
open.c: In function 'fk_open':
open.c:286:15: warning: assignment discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
  286 |         a.oacc= seq==SEQ?"s":"d";
      |               ^
open.c:287:15: warning: assignment discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
  287 |         a.ofm = fmt==FMT?"f":"u";
      |               ^
open.c: In function 'f_open':
open.c:232:20: warning: this statement may fall through [-Wimplicit-fallthrough=]
  232 |                 if (!access(buf,0))
      |                    ^
open.c:236:9: note: here
  236 |         case 'r':       /* Fortran 90 replace option */
      |         ^~~~
make[7]: *** [Makefile:677: open.lo] Error 1
make[7]: Leaving directory '/tmp/BUILD.fc40.x86_64/trinity-digikam-14.1.2~pre17+8f0b4a3a/digikam/imageplugins/coreplugin/sharpnesseditor/clapack'
make[6]: *** [Makefile:699: all-recursive] Error 1
make[6]: Leaving directory '/tmp/BUILD.fc40.x86_64/trinity-digikam-14.1.2~pre17+8f0b4a3a/digikam/imageplugins/coreplugin/sharpnesseditor'
make[5]: *** [Makefile:837: all-recursive] Error 1
make[5]: Leaving directory '/tmp/BUILD.fc40.x86_64/trinity-digikam-14.1.2~pre17+8f0b4a3a/digikam/imageplugins/coreplugin'
make[4]: *** [Makefile:562: all-recursive] Error 1
make[4]: Leaving directory '/tmp/BUILD.fc40.x86_64/trinity-digikam-14.1.2~pre17+8f0b4a3a/digikam/imageplugins'
make[3]: *** [Makefile:615: all-recursive] Error 1
make[3]: Leaving directory '/tmp/BUILD.fc40.x86_64/trinity-digikam-14.1.2~pre17+8f0b4a3a/digikam'
make[2]: *** [Makefile:615: all-recursive] Error 1
make[2]: Leaving directory '/tmp/BUILD.fc40.x86_64/trinity-digikam-14.1.2~pre17+8f0b4a3a'
make[1]: *** [Makefile:532: all] Error 2
make[1]: Leaving directory '/tmp/BUILD.fc40.x86_64/trinity-digikam-14.1.2~pre17+8f0b4a3a'

<!-- This is a comment. Please fill in the required fields below. The comments provide instructions on how to do so. Note: You do not need to remove comments. --> ## Basic information - TDE version: 14.1.2 - Distribution: Fedora 40 - Hardware: amd64 <!-- Use SL/* labels to set the severity level. Please do not set a milestone. --> ## Description FTBFS ## Steps to reproduce Build ## Screenshots <!-- If it seems useful, please provide provide one or more screenshots. --> ``` open.c: At top level: open.c:276:1: error: return type defaults to 'int' [-Wimplicit-int] 276 | fk_open(int seq, int fmt, ftnint n) | ^~~~~~~ open.c: In function 'fk_open': open.c:286:15: warning: assignment discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers] 286 | a.oacc= seq==SEQ?"s":"d"; | ^ open.c:287:15: warning: assignment discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers] 287 | a.ofm = fmt==FMT?"f":"u"; | ^ open.c: In function 'f_open': open.c:232:20: warning: this statement may fall through [-Wimplicit-fallthrough=] 232 | if (!access(buf,0)) | ^ open.c:236:9: note: here 236 | case 'r': /* Fortran 90 replace option */ | ^~~~ make[7]: *** [Makefile:677: open.lo] Error 1 make[7]: Leaving directory '/tmp/BUILD.fc40.x86_64/trinity-digikam-14.1.2~pre17+8f0b4a3a/digikam/imageplugins/coreplugin/sharpnesseditor/clapack' make[6]: *** [Makefile:699: all-recursive] Error 1 make[6]: Leaving directory '/tmp/BUILD.fc40.x86_64/trinity-digikam-14.1.2~pre17+8f0b4a3a/digikam/imageplugins/coreplugin/sharpnesseditor' make[5]: *** [Makefile:837: all-recursive] Error 1 make[5]: Leaving directory '/tmp/BUILD.fc40.x86_64/trinity-digikam-14.1.2~pre17+8f0b4a3a/digikam/imageplugins/coreplugin' make[4]: *** [Makefile:562: all-recursive] Error 1 make[4]: Leaving directory '/tmp/BUILD.fc40.x86_64/trinity-digikam-14.1.2~pre17+8f0b4a3a/digikam/imageplugins' make[3]: *** [Makefile:615: all-recursive] Error 1 make[3]: Leaving directory '/tmp/BUILD.fc40.x86_64/trinity-digikam-14.1.2~pre17+8f0b4a3a/digikam' make[2]: *** [Makefile:615: all-recursive] Error 1 make[2]: Leaving directory '/tmp/BUILD.fc40.x86_64/trinity-digikam-14.1.2~pre17+8f0b4a3a' make[1]: *** [Makefile:532: all] Error 2 make[1]: Leaving directory '/tmp/BUILD.fc40.x86_64/trinity-digikam-14.1.2~pre17+8f0b4a3a' ```

Francois added the SL/critical label 2 weeks ago

SlavekB referenced this issue from a commit 2 weeks ago

Add missing return type in fk_open function implementation.

SlavekB referenced this issue 2 weeks ago

Add missing return type in function implementations. #24

SlavekB commented 2 weeks ago

Owner

@Francois, please test patch from #24.

@Francois, please test patch from #24.

Francois commented 2 weeks ago

Poster

Collaborator

Thanks @SlavekB , new FTBFS below:

make[6]: Entering directory '/tmp/BUILD.fc40.x86_64/trinity-digikam-14.1.2~pre17+8f0b4a3a/digikam/imageplugins/coreplugin/sharpnesseditor/clapack'
/bin/sh ../../../../../libtool  --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I. -I../../../../..   -DTQT_THREAD_SUPPORT  -D_REENTRANT  -W -Wall -Wchar-subscripts -Wshadow -Wpointer-arith -Wmissing-prototypes -Wwrite-strings -D_DEFAULT_SOURCE -DNDEBUG -O2  -O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-U_FORTIFY_SOURCE,-D_FORTIFY_SOURCE=3 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1  -m64 -march=x86-64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer  -Wformat-security -Wmissing-format-attribute -I/usr/include/tqt -c -o wref.lo wref.c
libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I../../../../.. -DTQT_THREAD_SUPPORT -D_REENTRANT -W -Wall -Wchar-subscripts -Wshadow -Wpointer-arith -Wmissing-prototypes -Wwrite-strings -D_DEFAULT_SOURCE -DNDEBUG -O2 -O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-U_FORTIFY_SOURCE,-D_FORTIFY_SOURCE=3 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -march=x86-64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -Wformat-security -Wmissing-format-attribute -I/usr/include/tqt -c wref.c  -fPIC -DPIC -o .libs/wref.o
wref.c:21:1: error: return type defaults to 'int' [-Wimplicit-int]
   21 | wrt_E(ufloat *p, int w, int d, int e, ftnlen len)
      | ^~~~~
wref.c: In function 'wrt_E':
wref.c:131:45: warning: suggest parentheses around assignment used as truth value [-Wparentheses]
  131 |                         for(s -= 2, e1 = 2; s[0] = s[1]; s++)
      |                                             ^
wref.c: At top level:
wref.c:197:1: error: return type defaults to 'int' [-Wimplicit-int]
  197 | wrt_F(ufloat *p, int w, int d, ftnlen len)
      | ^~~~~
wref.c: In function 'wrt_F':
wref.c:221:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses]
  221 |         if (n = f__scale)
      |             ^
wref.c:221:12: warning: suggest explicit braces to avoid ambiguous 'else' [-Wdangling-else]
  221 |         if (n = f__scale)
      |            ^
wref.c:271:15: warning: suggest parentheses around assignment used as truth value [-Wparentheses]
  271 |         while(n = *b++)
      |               ^
make[6]: *** [Makefile:677: wref.lo] Error 1
make[6]: Leaving directory '/tmp/BUILD.fc40.x86_64/trinity-digikam-14.1.2~pre17+8f0b4a3a/digikam/imageplugins/coreplugin/sharpnesseditor/clapack'
make[5]: *** [Makefile:699: all-recursive] Error 1
make[5]: Leaving directory '/tmp/BUILD.fc40.x86_64/trinity-digikam-14.1.2~pre17+8f0b4a3a/digikam/imageplugins/coreplugin/sharpnesseditor'
make[4]: *** [Makefile:837: all-recursive] Error 1
make[4]: Leaving directory '/tmp/BUILD.fc40.x86_64/trinity-digikam-14.1.2~pre17+8f0b4a3a/digikam/imageplugins/coreplugin'
make[3]: *** [Makefile:562: all-recursive] Error 1
make[3]: Leaving directory '/tmp/BUILD.fc40.x86_64/trinity-digikam-14.1.2~pre17+8f0b4a3a/digikam/imageplugins'
make[2]: *** [Makefile:615: all-recursive] Error 1
make[2]: Leaving directory '/tmp/BUILD.fc40.x86_64/trinity-digikam-14.1.2~pre17+8f0b4a3a/digikam'
make[1]: *** [Makefile:615: all-recursive] Error 1
make[1]: Leaving directory '/tmp/BUILD.fc40.x86_64/trinity-digikam-14.1.2~pre17+8f0b4a3a'
make: *** [Makefile:532: all] Error 2

Thanks @SlavekB , new FTBFS below: ``` make[6]: Entering directory '/tmp/BUILD.fc40.x86_64/trinity-digikam-14.1.2~pre17+8f0b4a3a/digikam/imageplugins/coreplugin/sharpnesseditor/clapack' /bin/sh ../../../../../libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I../../../../.. -DTQT_THREAD_SUPPORT -D_REENTRANT -W -Wall -Wchar-subscripts -Wshadow -Wpointer-arith -Wmissing-prototypes -Wwrite-strings -D_DEFAULT_SOURCE -DNDEBUG -O2 -O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-U_FORTIFY_SOURCE,-D_FORTIFY_SOURCE=3 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -march=x86-64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -Wformat-security -Wmissing-format-attribute -I/usr/include/tqt -c -o wref.lo wref.c libtool: compile: gcc -DHAVE_CONFIG_H -I. -I../../../../.. -DTQT_THREAD_SUPPORT -D_REENTRANT -W -Wall -Wchar-subscripts -Wshadow -Wpointer-arith -Wmissing-prototypes -Wwrite-strings -D_DEFAULT_SOURCE -DNDEBUG -O2 -O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-U_FORTIFY_SOURCE,-D_FORTIFY_SOURCE=3 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -march=x86-64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -Wformat-security -Wmissing-format-attribute -I/usr/include/tqt -c wref.c -fPIC -DPIC -o .libs/wref.o wref.c:21:1: error: return type defaults to 'int' [-Wimplicit-int] 21 | wrt_E(ufloat *p, int w, int d, int e, ftnlen len) | ^~~~~ wref.c: In function 'wrt_E': wref.c:131:45: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 131 | for(s -= 2, e1 = 2; s[0] = s[1]; s++) | ^ wref.c: At top level: wref.c:197:1: error: return type defaults to 'int' [-Wimplicit-int] 197 | wrt_F(ufloat *p, int w, int d, ftnlen len) | ^~~~~ wref.c: In function 'wrt_F': wref.c:221:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 221 | if (n = f__scale) | ^ wref.c:221:12: warning: suggest explicit braces to avoid ambiguous 'else' [-Wdangling-else] 221 | if (n = f__scale) | ^ wref.c:271:15: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 271 | while(n = *b++) | ^ make[6]: *** [Makefile:677: wref.lo] Error 1 make[6]: Leaving directory '/tmp/BUILD.fc40.x86_64/trinity-digikam-14.1.2~pre17+8f0b4a3a/digikam/imageplugins/coreplugin/sharpnesseditor/clapack' make[5]: *** [Makefile:699: all-recursive] Error 1 make[5]: Leaving directory '/tmp/BUILD.fc40.x86_64/trinity-digikam-14.1.2~pre17+8f0b4a3a/digikam/imageplugins/coreplugin/sharpnesseditor' make[4]: *** [Makefile:837: all-recursive] Error 1 make[4]: Leaving directory '/tmp/BUILD.fc40.x86_64/trinity-digikam-14.1.2~pre17+8f0b4a3a/digikam/imageplugins/coreplugin' make[3]: *** [Makefile:562: all-recursive] Error 1 make[3]: Leaving directory '/tmp/BUILD.fc40.x86_64/trinity-digikam-14.1.2~pre17+8f0b4a3a/digikam/imageplugins' make[2]: *** [Makefile:615: all-recursive] Error 1 make[2]: Leaving directory '/tmp/BUILD.fc40.x86_64/trinity-digikam-14.1.2~pre17+8f0b4a3a/digikam' make[1]: *** [Makefile:615: all-recursive] Error 1 make[1]: Leaving directory '/tmp/BUILD.fc40.x86_64/trinity-digikam-14.1.2~pre17+8f0b4a3a' make: *** [Makefile:532: all] Error 2 ```

SlavekB referenced this issue from a commit 2 weeks ago

Add missing return type in function implementations.

SlavekB referenced this issue from a commit 2 weeks ago

Add missing return type in function implementations.

SlavekB commented 2 weeks ago

Owner

PR updated, please test it.

PR updated, please test it.

Francois commented 2 weeks ago

Poster

Collaborator

Thanks @SlavekB , new FTBFS below.

make[7]: Entering directory '/tmp/BUILD.fc40.x86_64/trinity-digikam-14.1.2~pre17+8f0b4a3a/digikam/imageplugins/coreplugin/sharpnesseditor/clapack'
/bin/sh ../../../../../libtool  --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I. -I../../../../..   -DTQT_THREAD_SUPPORT  -D_REENTRANT  -W -Wall -Wchar-subscripts -Wshadow -Wpointer-arith -Wmissing-prototypes -Wwrite-strings -D_DEFAULT_SOURCE -DNDEBUG -O2  -O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-U_FORTIFY_SOURCE,-D_FORTIFY_SOURCE=3 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1  -m64 -march=x86-64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer  -Wformat-security -Wmissing-format-attribute -I/usr/include/tqt -c -o err.lo err.c
libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I../../../../.. -DTQT_THREAD_SUPPORT -D_REENTRANT -W -Wall -Wchar-subscripts -Wshadow -Wpointer-arith -Wmissing-prototypes -Wwrite-strings -D_DEFAULT_SOURCE -DNDEBUG -O2 -O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-U_FORTIFY_SOURCE,-D_FORTIFY_SOURCE=3 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -march=x86-64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -Wformat-security -Wmissing-format-attribute -I/usr/include/tqt -c err.c  -fPIC -DPIC -o .libs/err.o
err.c:50:9: warning: initialization discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
   50 |         "error in format",                              /* 100 */
      |         ^~~~~~~~~~~~~~~~~
err.c:51:9: warning: initialization discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
   51 |         "illegal unit number",                          /* 101 */
      |         ^~~~~~~~~~~~~~~~~~~~~
err.c:52:9: warning: initialization discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
   52 |         "formatted io not allowed",                     /* 102 */
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~~
err.c:53:9: warning: initialization discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
   53 |         "unformatted io not allowed",                   /* 103 */
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
err.c:54:9: warning: initialization discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
   54 |         "direct io not allowed",                        /* 104 */
      |         ^~~~~~~~~~~~~~~~~~~~~~~
err.c:55:9: warning: initialization discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
   55 |         "sequential io not allowed",                    /* 105 */
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~
err.c:56:9: warning: initialization discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
   56 |         "can't backspace file",                         /* 106 */
      |         ^~~~~~~~~~~~~~~~~~~~~~
err.c:57:9: warning: initialization discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
   57 |         "null file name",                               /* 107 */
      |         ^~~~~~~~~~~~~~~~
err.c:58:9: warning: initialization discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
   58 |         "can't stat file",                              /* 108 */
      |         ^~~~~~~~~~~~~~~~~
err.c:59:9: warning: initialization discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
   59 |         "unit not connected",                           /* 109 */
      |         ^~~~~~~~~~~~~~~~~~~~
err.c:60:9: warning: initialization discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
   60 |         "off end of record",                            /* 110 */
      |         ^~~~~~~~~~~~~~~~~~~
err.c:61:9: warning: initialization discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
   61 |         "truncation failed in endfile",                 /* 111 */
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
err.c:62:9: warning: initialization discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
   62 |         "incomprehensible list input",                  /* 112 */
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
err.c:63:9: warning: initialization discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
   63 |         "out of free space",                            /* 113 */
      |         ^~~~~~~~~~~~~~~~~~~
err.c:64:9: warning: initialization discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
   64 |         "unit not connected",                           /* 114 */
      |         ^~~~~~~~~~~~~~~~~~~~
err.c:65:9: warning: initialization discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
   65 |         "read unexpected character",                    /* 115 */
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~
err.c:66:9: warning: initialization discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
   66 |         "bad logical input field",                      /* 116 */
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~
err.c:67:9: warning: initialization discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
   67 |         "bad variable type",                            /* 117 */
      |         ^~~~~~~~~~~~~~~~~~~
err.c:68:9: warning: initialization discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
   68 |         "bad namelist name",                            /* 118 */
      |         ^~~~~~~~~~~~~~~~~~~
err.c:69:9: warning: initialization discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
   69 |         "variable not in namelist",                     /* 119 */
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~~
err.c:70:9: warning: initialization discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
   70 |         "no end record",                                /* 120 */
      |         ^~~~~~~~~~~~~~~
err.c:71:9: warning: initialization discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
   71 |         "variable count incorrect",                     /* 121 */
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~~
err.c:72:9: warning: initialization discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
   72 |         "subscript for scalar variable",                /* 122 */
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
err.c:73:9: warning: initialization discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
   73 |         "invalid array section",                        /* 123 */
      |         ^~~~~~~~~~~~~~~~~~~~~~~
err.c:74:9: warning: initialization discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
   74 |         "substring out of bounds",                      /* 124 */
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~
err.c:75:9: warning: initialization discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
   75 |         "subscript out of bounds",                      /* 125 */
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~
err.c:76:9: warning: initialization discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
   76 |         "can't read file",                              /* 126 */
      |         ^~~~~~~~~~~~~~~~~
err.c:77:9: warning: initialization discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
   77 |         "can't write file",                             /* 127 */
      |         ^~~~~~~~~~~~~~~~~~
err.c:78:9: warning: initialization discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
   78 |         "'new' file exists",                            /* 128 */
      |         ^~~~~~~~~~~~~~~~~~~
err.c:79:9: warning: initialization discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
   79 |         "can't append to file",                         /* 129 */
      |         ^~~~~~~~~~~~~~~~~~~~~~
err.c:80:9: warning: initialization discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
   80 |         "non-positive record number"                    /* 130 */
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
err.c:87:1: error: return type defaults to 'int' [-Wimplicit-int]
   87 | f__canseek(FILE *f) /*SYSDEP*/
      | ^~~~~~~~~~
err.c:87:1: warning: no previous prototype for 'f__canseek' [-Wmissing-prototypes]
err.c: In function 'f__fatal':
err.c:165:17: warning: passing argument 1 of 'sig_die' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
  165 |         sig_die(" IO", 1);
      |                 ^~~~~
In file included from err.c:16:
fio.h:66:21: note: expected 'char *' but argument is of type 'const char *'
   66 | extern void sig_die(char*,int);
      |                     ^~~~~
err.c: At top level:
err.c:192:1: error: return type defaults to 'int' [-Wimplicit-int]
  192 | f__nowreading(unit *x)
      | ^~~~~~~~~~~~~
err.c:223:1: error: return type defaults to 'int' [-Wimplicit-int]
  223 | f__nowwriting(unit *x)
      | ^~~~~~~~~~~~~
make[7]: *** [Makefile:677: err.lo] Error 1
make[7]: Leaving directory '/tmp/BUILD.fc40.x86_64/trinity-digikam-14.1.2~pre17+8f0b4a3a/digikam/imageplugins/coreplugin/sharpnesseditor/clapack'
make[6]: *** [Makefile:699: all-recursive] Error 1
make[6]: Leaving directory '/tmp/BUILD.fc40.x86_64/trinity-digikam-14.1.2~pre17+8f0b4a3a/digikam/imageplugins/coreplugin/sharpnesseditor'
make[5]: *** [Makefile:837: all-recursive] Error 1
make[5]: Leaving directory '/tmp/BUILD.fc40.x86_64/trinity-digikam-14.1.2~pre17+8f0b4a3a/digikam/imageplugins/coreplugin'
make[4]: *** [Makefile:562: all-recursive] Error 1
make[4]: Leaving directory '/tmp/BUILD.fc40.x86_64/trinity-digikam-14.1.2~pre17+8f0b4a3a/digikam/imageplugins'
make[3]: *** [Makefile:615: all-recursive] Error 1
make[3]: Leaving directory '/tmp/BUILD.fc40.x86_64/trinity-digikam-14.1.2~pre17+8f0b4a3a/digikam'
make[2]: *** [Makefile:615: all-recursive] Error 1
make[2]: Leaving directory '/tmp/BUILD.fc40.x86_64/trinity-digikam-14.1.2~pre17+8f0b4a3a'
make[1]: *** [Makefile:532: all] Error 2
make[1]: Leaving directory '/tmp/BUILD.fc40.x86_64/trinity-digikam-14.1.2~pre17+8f0b4a3a'

Thanks @SlavekB , new FTBFS below. ``` make[7]: Entering directory '/tmp/BUILD.fc40.x86_64/trinity-digikam-14.1.2~pre17+8f0b4a3a/digikam/imageplugins/coreplugin/sharpnesseditor/clapack' /bin/sh ../../../../../libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I../../../../.. -DTQT_THREAD_SUPPORT -D_REENTRANT -W -Wall -Wchar-subscripts -Wshadow -Wpointer-arith -Wmissing-prototypes -Wwrite-strings -D_DEFAULT_SOURCE -DNDEBUG -O2 -O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-U_FORTIFY_SOURCE,-D_FORTIFY_SOURCE=3 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -march=x86-64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -Wformat-security -Wmissing-format-attribute -I/usr/include/tqt -c -o err.lo err.c libtool: compile: gcc -DHAVE_CONFIG_H -I. -I../../../../.. -DTQT_THREAD_SUPPORT -D_REENTRANT -W -Wall -Wchar-subscripts -Wshadow -Wpointer-arith -Wmissing-prototypes -Wwrite-strings -D_DEFAULT_SOURCE -DNDEBUG -O2 -O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-U_FORTIFY_SOURCE,-D_FORTIFY_SOURCE=3 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -march=x86-64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -Wformat-security -Wmissing-format-attribute -I/usr/include/tqt -c err.c -fPIC -DPIC -o .libs/err.o err.c:50:9: warning: initialization discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers] 50 | "error in format", /* 100 */ | ^~~~~~~~~~~~~~~~~ err.c:51:9: warning: initialization discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers] 51 | "illegal unit number", /* 101 */ | ^~~~~~~~~~~~~~~~~~~~~ err.c:52:9: warning: initialization discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers] 52 | "formatted io not allowed", /* 102 */ | ^~~~~~~~~~~~~~~~~~~~~~~~~~ err.c:53:9: warning: initialization discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers] 53 | "unformatted io not allowed", /* 103 */ | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ err.c:54:9: warning: initialization discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers] 54 | "direct io not allowed", /* 104 */ | ^~~~~~~~~~~~~~~~~~~~~~~ err.c:55:9: warning: initialization discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers] 55 | "sequential io not allowed", /* 105 */ | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ err.c:56:9: warning: initialization discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers] 56 | "can't backspace file", /* 106 */ | ^~~~~~~~~~~~~~~~~~~~~~ err.c:57:9: warning: initialization discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers] 57 | "null file name", /* 107 */ | ^~~~~~~~~~~~~~~~ err.c:58:9: warning: initialization discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers] 58 | "can't stat file", /* 108 */ | ^~~~~~~~~~~~~~~~~ err.c:59:9: warning: initialization discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers] 59 | "unit not connected", /* 109 */ | ^~~~~~~~~~~~~~~~~~~~ err.c:60:9: warning: initialization discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers] 60 | "off end of record", /* 110 */ | ^~~~~~~~~~~~~~~~~~~ err.c:61:9: warning: initialization discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers] 61 | "truncation failed in endfile", /* 111 */ | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ err.c:62:9: warning: initialization discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers] 62 | "incomprehensible list input", /* 112 */ | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ err.c:63:9: warning: initialization discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers] 63 | "out of free space", /* 113 */ | ^~~~~~~~~~~~~~~~~~~ err.c:64:9: warning: initialization discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers] 64 | "unit not connected", /* 114 */ | ^~~~~~~~~~~~~~~~~~~~ err.c:65:9: warning: initialization discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers] 65 | "read unexpected character", /* 115 */ | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ err.c:66:9: warning: initialization discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers] 66 | "bad logical input field", /* 116 */ | ^~~~~~~~~~~~~~~~~~~~~~~~~ err.c:67:9: warning: initialization discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers] 67 | "bad variable type", /* 117 */ | ^~~~~~~~~~~~~~~~~~~ err.c:68:9: warning: initialization discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers] 68 | "bad namelist name", /* 118 */ | ^~~~~~~~~~~~~~~~~~~ err.c:69:9: warning: initialization discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers] 69 | "variable not in namelist", /* 119 */ | ^~~~~~~~~~~~~~~~~~~~~~~~~~ err.c:70:9: warning: initialization discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers] 70 | "no end record", /* 120 */ | ^~~~~~~~~~~~~~~ err.c:71:9: warning: initialization discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers] 71 | "variable count incorrect", /* 121 */ | ^~~~~~~~~~~~~~~~~~~~~~~~~~ err.c:72:9: warning: initialization discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers] 72 | "subscript for scalar variable", /* 122 */ | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ err.c:73:9: warning: initialization discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers] 73 | "invalid array section", /* 123 */ | ^~~~~~~~~~~~~~~~~~~~~~~ err.c:74:9: warning: initialization discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers] 74 | "substring out of bounds", /* 124 */ | ^~~~~~~~~~~~~~~~~~~~~~~~~ err.c:75:9: warning: initialization discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers] 75 | "subscript out of bounds", /* 125 */ | ^~~~~~~~~~~~~~~~~~~~~~~~~ err.c:76:9: warning: initialization discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers] 76 | "can't read file", /* 126 */ | ^~~~~~~~~~~~~~~~~ err.c:77:9: warning: initialization discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers] 77 | "can't write file", /* 127 */ | ^~~~~~~~~~~~~~~~~~ err.c:78:9: warning: initialization discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers] 78 | "'new' file exists", /* 128 */ | ^~~~~~~~~~~~~~~~~~~ err.c:79:9: warning: initialization discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers] 79 | "can't append to file", /* 129 */ | ^~~~~~~~~~~~~~~~~~~~~~ err.c:80:9: warning: initialization discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers] 80 | "non-positive record number" /* 130 */ | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ err.c:87:1: error: return type defaults to 'int' [-Wimplicit-int] 87 | f__canseek(FILE *f) /*SYSDEP*/ | ^~~~~~~~~~ err.c:87:1: warning: no previous prototype for 'f__canseek' [-Wmissing-prototypes] err.c: In function 'f__fatal': err.c:165:17: warning: passing argument 1 of 'sig_die' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers] 165 | sig_die(" IO", 1); | ^~~~~ In file included from err.c:16: fio.h:66:21: note: expected 'char *' but argument is of type 'const char *' 66 | extern void sig_die(char*,int); | ^~~~~ err.c: At top level: err.c:192:1: error: return type defaults to 'int' [-Wimplicit-int] 192 | f__nowreading(unit *x) | ^~~~~~~~~~~~~ err.c:223:1: error: return type defaults to 'int' [-Wimplicit-int] 223 | f__nowwriting(unit *x) | ^~~~~~~~~~~~~ make[7]: *** [Makefile:677: err.lo] Error 1 make[7]: Leaving directory '/tmp/BUILD.fc40.x86_64/trinity-digikam-14.1.2~pre17+8f0b4a3a/digikam/imageplugins/coreplugin/sharpnesseditor/clapack' make[6]: *** [Makefile:699: all-recursive] Error 1 make[6]: Leaving directory '/tmp/BUILD.fc40.x86_64/trinity-digikam-14.1.2~pre17+8f0b4a3a/digikam/imageplugins/coreplugin/sharpnesseditor' make[5]: *** [Makefile:837: all-recursive] Error 1 make[5]: Leaving directory '/tmp/BUILD.fc40.x86_64/trinity-digikam-14.1.2~pre17+8f0b4a3a/digikam/imageplugins/coreplugin' make[4]: *** [Makefile:562: all-recursive] Error 1 make[4]: Leaving directory '/tmp/BUILD.fc40.x86_64/trinity-digikam-14.1.2~pre17+8f0b4a3a/digikam/imageplugins' make[3]: *** [Makefile:615: all-recursive] Error 1 make[3]: Leaving directory '/tmp/BUILD.fc40.x86_64/trinity-digikam-14.1.2~pre17+8f0b4a3a/digikam' make[2]: *** [Makefile:615: all-recursive] Error 1 make[2]: Leaving directory '/tmp/BUILD.fc40.x86_64/trinity-digikam-14.1.2~pre17+8f0b4a3a' make[1]: *** [Makefile:532: all] Error 2 make[1]: Leaving directory '/tmp/BUILD.fc40.x86_64/trinity-digikam-14.1.2~pre17+8f0b4a3a' ```

SlavekB referenced this issue from a commit 2 weeks ago

Add missing return type in function implementations.

SlavekB commented 2 weeks ago

Owner

PR updated, other iterations can continue.

PR updated, other iterations can continue.

Francois commented 2 weeks ago

Poster

Collaborator

New FTBFS:

make[6]: Entering directory '/tmp/BUILD.fc40.x86_64/trinity-digikam-14.1.2~pre17+8f0b4a3a/digikam/imageplugins/coreplugin/sharpnesseditor/clapack'
/bin/sh ../../../../../libtool  --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I. -I../../../../..   -DTQT_THREAD_SUPPORT  -D_REENTRANT  -W -Wall -Wchar-subscripts -Wshadow -Wpointer-arith -Wmissing-prototypes -Wwrite-strings -D_DEFAULT_SOURCE -DNDEBUG -O2  -O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-U_FORTIFY_SOURCE,-D_FORTIFY_SOURCE=3 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1  -m64 -march=x86-64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer  -Wformat-security -Wmissing-format-attribute -I/usr/include/tqt -c -o fmt.lo fmt.c
libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I../../../../.. -DTQT_THREAD_SUPPORT -D_REENTRANT -W -Wall -Wchar-subscripts -Wshadow -Wpointer-arith -Wmissing-prototypes -Wwrite-strings -D_DEFAULT_SOURCE -DNDEBUG -O2 -O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-U_FORTIFY_SOURCE,-D_FORTIFY_SOURCE=3 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -march=x86-64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -Wformat-security -Wmissing-format-attribute -I/usr/include/tqt -c fmt.c  -fPIC -DPIC -o .libs/fmt.o
fmt.c: In function 'ap_end':
fmt.c:40:23: warning: passing argument 2 of 'f__fatal' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
   40 |         f__fatal(100, "bad string");
      |                       ^~~~~~~~~~~~
In file included from fmt.c:2:
fio.h:67:26: note: expected 'char *' but argument is of type 'const char *'
   67 | extern void f__fatal(int,char*);
      |                          ^~~~~
fmt.c: At top level:
fmt.c:47:1: error: return type defaults to 'int' [-Wimplicit-int]
   47 | op_gen(int a, int b, int c, int d)
      | ^~~~~~
fmt.c:114:1: error: return type defaults to 'int' [-Wimplicit-int]
  114 | ne_d(char *s, char **p)
      | ^~~~
fmt.c:206:1: error: return type defaults to 'int' [-Wimplicit-int]
  206 | e_d(char *s, char **p)
      | ^~~
fmt.c:365:1: error: return type defaults to 'int' [-Wimplicit-int]
  365 | pars_f(char *s)
      | ^~~~~~
fmt.c:383:1: error: return type defaults to 'int' [-Wimplicit-int]
  383 | type_f(int n)
      | ^~~~~~
fmt.c:415:9: warning: no previous prototype for 'do_fio' [-Wmissing-prototypes]
  415 | integer do_fio(ftnint *number, char *ptr, ftnlen len)
      |         ^~~~~~
fmt.c: In function 'do_fio':
fmt.c:426:41: warning: passing argument 2 of 'f__fatal' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
  426 |                 err(f__elist->cierr,100,"do_fio");
      |                                         ^~~~~~~~
fio.h:88:53: note: in definition of macro 'err'
   88 | #define err(f,m,s) {if(f) errno= m; else f__fatal(m,s); return(m);}
      |                                                     ^
fio.h:67:26: note: expected 'char *' but argument is of type 'const char *'
   67 | extern void f__fatal(int,char*);
      |                          ^~~~~
fmt.c:445:53: warning: passing argument 3 of 'err__fl' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
  445 |                         errfl(f__elist->cierr,errno,"fmt");
      |                                                     ^~~~~
fio.h:89:46: note: in definition of macro 'errfl'
   89 | #define errfl(f,m,s) return err__fl((int)f,m,s)
      |                                              ^
fio.h:77:28: note: expected 'char *' but argument is of type 'const char *'
   77 | extern int err__fl(int,int,char*);
      |                            ^~~~~
fmt.c:447:51: warning: passing argument 2 of 'f__fatal' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
  447 |                         err(f__elist->ciend,(EOF),"fmt");
      |                                                   ^~~~~
fio.h:88:53: note: in definition of macro 'err'
   88 | #define err(f,m,s) {if(f) errno= m; else f__fatal(m,s); return(m);}
      |                                                     ^
fio.h:67:26: note: expected 'char *' but argument is of type 'const char *'
   67 | extern void f__fatal(int,char*);
      |                          ^~~~~
fmt.c: At top level:
fmt.c:507:1: error: return type defaults to 'int' [-Wimplicit-int]
  507 | en_fio(Void)
      | ^~~~~~
fmt.c: In function 'ne_d':
fmt.c:144:23: warning: this statement may fall through [-Wimplicit-fallthrough=]
  144 |         case '-': sign=1;
      |                   ~~~~^~
fmt.c:145:9: note: here
  145 |         case '+':       s++;    /*OUTRAGEOUS CODING TRICK*/
      |         ^~~~
fmt.c:145:26: warning: this statement may fall through [-Wimplicit-fallthrough=]
  145 |         case '+':       s++;    /*OUTRAGEOUS CODING TRICK*/
      |                         ~^~
fmt.c:146:9: note: here
  146 |         case '0': case '1': case '2': case '3': case '4':
      |         ^~~~
fmt.c: In function 'e_d':
fmt.c:216:26: warning: this statement may fall through [-Wimplicit-fallthrough=]
  216 |         case 'e':       x=1;
      |                         ~^~
fmt.c:217:9: note: here
  217 |         case 'G':
      |         ^~~~
make[6]: *** [Makefile:677: fmt.lo] Error 1
make[6]: Leaving directory '/tmp/BUILD.fc40.x86_64/trinity-digikam-14.1.2~pre17+8f0b4a3a/digikam/imageplugins/coreplugin/sharpnesseditor/clapack'
make[5]: *** [Makefile:699: all-recursive] Error 1
make[5]: Leaving directory '/tmp/BUILD.fc40.x86_64/trinity-digikam-14.1.2~pre17+8f0b4a3a/digikam/imageplugins/coreplugin/sharpnesseditor'
make[4]: *** [Makefile:837: all-recursive] Error 1
make[4]: Leaving directory '/tmp/BUILD.fc40.x86_64/trinity-digikam-14.1.2~pre17+8f0b4a3a/digikam/imageplugins/coreplugin'
make[3]: *** [Makefile:562: all-recursive] Error 1
make[3]: Leaving directory '/tmp/BUILD.fc40.x86_64/trinity-digikam-14.1.2~pre17+8f0b4a3a/digikam/imageplugins'
make[2]: *** [Makefile:615: all-recursive] Error 1
make[2]: Leaving directory '/tmp/BUILD.fc40.x86_64/trinity-digikam-14.1.2~pre17+8f0b4a3a/digikam'
make[1]: *** [Makefile:615: all-recursive] Error 1
make[1]: Leaving directory '/tmp/BUILD.fc40.x86_64/trinity-digikam-14.1.2~pre17+8f0b4a3a'
make: *** [Makefile:532: all] Error 2

New FTBFS: ``` make[6]: Entering directory '/tmp/BUILD.fc40.x86_64/trinity-digikam-14.1.2~pre17+8f0b4a3a/digikam/imageplugins/coreplugin/sharpnesseditor/clapack' /bin/sh ../../../../../libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I../../../../.. -DTQT_THREAD_SUPPORT -D_REENTRANT -W -Wall -Wchar-subscripts -Wshadow -Wpointer-arith -Wmissing-prototypes -Wwrite-strings -D_DEFAULT_SOURCE -DNDEBUG -O2 -O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-U_FORTIFY_SOURCE,-D_FORTIFY_SOURCE=3 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -march=x86-64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -Wformat-security -Wmissing-format-attribute -I/usr/include/tqt -c -o fmt.lo fmt.c libtool: compile: gcc -DHAVE_CONFIG_H -I. -I../../../../.. -DTQT_THREAD_SUPPORT -D_REENTRANT -W -Wall -Wchar-subscripts -Wshadow -Wpointer-arith -Wmissing-prototypes -Wwrite-strings -D_DEFAULT_SOURCE -DNDEBUG -O2 -O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-U_FORTIFY_SOURCE,-D_FORTIFY_SOURCE=3 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -march=x86-64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -Wformat-security -Wmissing-format-attribute -I/usr/include/tqt -c fmt.c -fPIC -DPIC -o .libs/fmt.o fmt.c: In function 'ap_end': fmt.c:40:23: warning: passing argument 2 of 'f__fatal' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers] 40 | f__fatal(100, "bad string"); | ^~~~~~~~~~~~ In file included from fmt.c:2: fio.h:67:26: note: expected 'char *' but argument is of type 'const char *' 67 | extern void f__fatal(int,char*); | ^~~~~ fmt.c: At top level: fmt.c:47:1: error: return type defaults to 'int' [-Wimplicit-int] 47 | op_gen(int a, int b, int c, int d) | ^~~~~~ fmt.c:114:1: error: return type defaults to 'int' [-Wimplicit-int] 114 | ne_d(char *s, char **p) | ^~~~ fmt.c:206:1: error: return type defaults to 'int' [-Wimplicit-int] 206 | e_d(char *s, char **p) | ^~~ fmt.c:365:1: error: return type defaults to 'int' [-Wimplicit-int] 365 | pars_f(char *s) | ^~~~~~ fmt.c:383:1: error: return type defaults to 'int' [-Wimplicit-int] 383 | type_f(int n) | ^~~~~~ fmt.c:415:9: warning: no previous prototype for 'do_fio' [-Wmissing-prototypes] 415 | integer do_fio(ftnint *number, char *ptr, ftnlen len) | ^~~~~~ fmt.c: In function 'do_fio': fmt.c:426:41: warning: passing argument 2 of 'f__fatal' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers] 426 | err(f__elist->cierr,100,"do_fio"); | ^~~~~~~~ fio.h:88:53: note: in definition of macro 'err' 88 | #define err(f,m,s) {if(f) errno= m; else f__fatal(m,s); return(m);} | ^ fio.h:67:26: note: expected 'char *' but argument is of type 'const char *' 67 | extern void f__fatal(int,char*); | ^~~~~ fmt.c:445:53: warning: passing argument 3 of 'err__fl' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers] 445 | errfl(f__elist->cierr,errno,"fmt"); | ^~~~~ fio.h:89:46: note: in definition of macro 'errfl' 89 | #define errfl(f,m,s) return err__fl((int)f,m,s) | ^ fio.h:77:28: note: expected 'char *' but argument is of type 'const char *' 77 | extern int err__fl(int,int,char*); | ^~~~~ fmt.c:447:51: warning: passing argument 2 of 'f__fatal' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers] 447 | err(f__elist->ciend,(EOF),"fmt"); | ^~~~~ fio.h:88:53: note: in definition of macro 'err' 88 | #define err(f,m,s) {if(f) errno= m; else f__fatal(m,s); return(m);} | ^ fio.h:67:26: note: expected 'char *' but argument is of type 'const char *' 67 | extern void f__fatal(int,char*); | ^~~~~ fmt.c: At top level: fmt.c:507:1: error: return type defaults to 'int' [-Wimplicit-int] 507 | en_fio(Void) | ^~~~~~ fmt.c: In function 'ne_d': fmt.c:144:23: warning: this statement may fall through [-Wimplicit-fallthrough=] 144 | case '-': sign=1; | ~~~~^~ fmt.c:145:9: note: here 145 | case '+': s++; /*OUTRAGEOUS CODING TRICK*/ | ^~~~ fmt.c:145:26: warning: this statement may fall through [-Wimplicit-fallthrough=] 145 | case '+': s++; /*OUTRAGEOUS CODING TRICK*/ | ~^~ fmt.c:146:9: note: here 146 | case '0': case '1': case '2': case '3': case '4': | ^~~~ fmt.c: In function 'e_d': fmt.c:216:26: warning: this statement may fall through [-Wimplicit-fallthrough=] 216 | case 'e': x=1; | ~^~ fmt.c:217:9: note: here 217 | case 'G': | ^~~~ make[6]: *** [Makefile:677: fmt.lo] Error 1 make[6]: Leaving directory '/tmp/BUILD.fc40.x86_64/trinity-digikam-14.1.2~pre17+8f0b4a3a/digikam/imageplugins/coreplugin/sharpnesseditor/clapack' make[5]: *** [Makefile:699: all-recursive] Error 1 make[5]: Leaving directory '/tmp/BUILD.fc40.x86_64/trinity-digikam-14.1.2~pre17+8f0b4a3a/digikam/imageplugins/coreplugin/sharpnesseditor' make[4]: *** [Makefile:837: all-recursive] Error 1 make[4]: Leaving directory '/tmp/BUILD.fc40.x86_64/trinity-digikam-14.1.2~pre17+8f0b4a3a/digikam/imageplugins/coreplugin' make[3]: *** [Makefile:562: all-recursive] Error 1 make[3]: Leaving directory '/tmp/BUILD.fc40.x86_64/trinity-digikam-14.1.2~pre17+8f0b4a3a/digikam/imageplugins' make[2]: *** [Makefile:615: all-recursive] Error 1 make[2]: Leaving directory '/tmp/BUILD.fc40.x86_64/trinity-digikam-14.1.2~pre17+8f0b4a3a/digikam' make[1]: *** [Makefile:615: all-recursive] Error 1 make[1]: Leaving directory '/tmp/BUILD.fc40.x86_64/trinity-digikam-14.1.2~pre17+8f0b4a3a' make: *** [Makefile:532: all] Error 2 ```

SlavekB referenced this issue from a commit 2 weeks ago

Add missing return type in function implementations.

SlavekB commented 2 weeks ago

Owner

PR updated, other iterations can continue.

PR updated, other iterations can continue.

Francois commented 2 weeks ago

Poster

Collaborator

make[6]: Entering directory '/tmp/BUILD.fc40.x86_64/trinity-digikam-14.1.2~pre17+8f0b4a3a/digikam/imageplugins/coreplugin/sharpnesseditor/clapack'
/bin/sh ../../../../../libtool  --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I. -I../../../../..   -DTQT_THREAD_SUPPORT  -D_REENTRANT  -W -Wall -Wchar-subscripts -Wshadow -Wpointer-arith -Wmissing-prototypes -Wwrite-strings -D_DEFAULT_SOURCE -DNDEBUG -O2  -O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-U_FORTIFY_SOURCE,-D_FORTIFY_SOURCE=3 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1  -m64 -march=x86-64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer  -Wformat-security -Wmissing-format-attribute -I/usr/include/tqt -c -o sfe.lo sfe.c
libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I../../../../.. -DTQT_THREAD_SUPPORT -D_REENTRANT -W -Wall -Wchar-subscripts -Wshadow -Wpointer-arith -Wmissing-prototypes -Wwrite-strings -D_DEFAULT_SOURCE -DNDEBUG -O2 -O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-U_FORTIFY_SOURCE,-D_FORTIFY_SOURCE=3 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -march=x86-64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -Wformat-security -Wmissing-format-attribute -I/usr/include/tqt -c sfe.c  -fPIC -DPIC -o .libs/sfe.o
sfe.c:7:9: warning: no previous prototype for 'e_rsfe' [-Wmissing-prototypes]
    7 | integer e_rsfe(Void)
      |         ^~~~~~
sfe.c:16:1: error: return type defaults to 'int' [-Wimplicit-int]
   16 | c_sfe(cilist *a) /* check */
      | ^~~~~
In file included from sfe.c:3:
sfe.c: In function 'c_sfe':
sfe.c:21:34: warning: passing argument 2 of 'f__fatal' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
   21 |                 err(a->cierr,101,"startio");
      |                                  ^~~~~~~~~
fio.h:88:53: note: in definition of macro 'err'
   88 | #define err(f,m,s) {if(f) errno= m; else f__fatal(m,s); return(m);}
      |                                                     ^
fio.h:67:26: note: expected 'char *' but argument is of type 'const char *'
   67 | extern void f__fatal(int,char*);
      |                          ^~~~~
sfe.c:22:73: warning: passing argument 2 of 'f__fatal' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
   22 |         if(p->ufd==NULL && fk_open(SEQ,FMT,a->ciunit)) err(a->cierr,114,"sfe")
      |                                                                         ^~~~~
fio.h:88:53: note: in definition of macro 'err'
   88 | #define err(f,m,s) {if(f) errno= m; else f__fatal(m,s); return(m);}
      |                                                     ^
fio.h:67:26: note: expected 'char *' but argument is of type 'const char *'
   67 | extern void f__fatal(int,char*);
      |                          ^~~~~
sfe.c:23:39: warning: passing argument 2 of 'f__fatal' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
   23 |         if(!p->ufmt) err(a->cierr,102,"sfe")
      |                                       ^~~~~
fio.h:88:53: note: in definition of macro 'err'
   88 | #define err(f,m,s) {if(f) errno= m; else f__fatal(m,s); return(m);}
      |                                                     ^
fio.h:67:26: note: expected 'char *' but argument is of type 'const char *'
   67 | extern void f__fatal(int,char*);
      |                          ^~~~~
sfe.c: At top level:
sfe.c:26:9: warning: no previous prototype for 'e_wsfe' [-Wmissing-prototypes]
   26 | integer e_wsfe(Void)
      |         ^~~~~~
make[6]: *** [Makefile:677: sfe.lo] Error 1
make[6]: Leaving directory '/tmp/BUILD.fc40.x86_64/trinity-digikam-14.1.2~pre17+8f0b4a3a/digikam/imageplugins/coreplugin/sharpnesseditor/clapack'
make[5]: *** [Makefile:699: all-recursive] Error 1
make[5]: Leaving directory '/tmp/BUILD.fc40.x86_64/trinity-digikam-14.1.2~pre17+8f0b4a3a/digikam/imageplugins/coreplugin/sharpnesseditor'
make[4]: *** [Makefile:837: all-recursive] Error 1
make[4]: Leaving directory '/tmp/BUILD.fc40.x86_64/trinity-digikam-14.1.2~pre17+8f0b4a3a/digikam/imageplugins/coreplugin'
make[3]: *** [Makefile:562: all-recursive] Error 1
make[3]: Leaving directory '/tmp/BUILD.fc40.x86_64/trinity-digikam-14.1.2~pre17+8f0b4a3a/digikam/imageplugins'
make[2]: *** [Makefile:615: all-recursive] Error 1
make[2]: Leaving directory '/tmp/BUILD.fc40.x86_64/trinity-digikam-14.1.2~pre17+8f0b4a3a/digikam'
make[1]: *** [Makefile:615: all-recursive] Error 1
make[1]: Leaving directory '/tmp/BUILD.fc40.x86_64/trinity-digikam-14.1.2~pre17+8f0b4a3a'
make: *** [Makefile:532: all] Error 2

``` make[6]: Entering directory '/tmp/BUILD.fc40.x86_64/trinity-digikam-14.1.2~pre17+8f0b4a3a/digikam/imageplugins/coreplugin/sharpnesseditor/clapack' /bin/sh ../../../../../libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I../../../../.. -DTQT_THREAD_SUPPORT -D_REENTRANT -W -Wall -Wchar-subscripts -Wshadow -Wpointer-arith -Wmissing-prototypes -Wwrite-strings -D_DEFAULT_SOURCE -DNDEBUG -O2 -O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-U_FORTIFY_SOURCE,-D_FORTIFY_SOURCE=3 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -march=x86-64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -Wformat-security -Wmissing-format-attribute -I/usr/include/tqt -c -o sfe.lo sfe.c libtool: compile: gcc -DHAVE_CONFIG_H -I. -I../../../../.. -DTQT_THREAD_SUPPORT -D_REENTRANT -W -Wall -Wchar-subscripts -Wshadow -Wpointer-arith -Wmissing-prototypes -Wwrite-strings -D_DEFAULT_SOURCE -DNDEBUG -O2 -O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-U_FORTIFY_SOURCE,-D_FORTIFY_SOURCE=3 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -march=x86-64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -Wformat-security -Wmissing-format-attribute -I/usr/include/tqt -c sfe.c -fPIC -DPIC -o .libs/sfe.o sfe.c:7:9: warning: no previous prototype for 'e_rsfe' [-Wmissing-prototypes] 7 | integer e_rsfe(Void) | ^~~~~~ sfe.c:16:1: error: return type defaults to 'int' [-Wimplicit-int] 16 | c_sfe(cilist *a) /* check */ | ^~~~~ In file included from sfe.c:3: sfe.c: In function 'c_sfe': sfe.c:21:34: warning: passing argument 2 of 'f__fatal' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers] 21 | err(a->cierr,101,"startio"); | ^~~~~~~~~ fio.h:88:53: note: in definition of macro 'err' 88 | #define err(f,m,s) {if(f) errno= m; else f__fatal(m,s); return(m);} | ^ fio.h:67:26: note: expected 'char *' but argument is of type 'const char *' 67 | extern void f__fatal(int,char*); | ^~~~~ sfe.c:22:73: warning: passing argument 2 of 'f__fatal' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers] 22 | if(p->ufd==NULL && fk_open(SEQ,FMT,a->ciunit)) err(a->cierr,114,"sfe") | ^~~~~ fio.h:88:53: note: in definition of macro 'err' 88 | #define err(f,m,s) {if(f) errno= m; else f__fatal(m,s); return(m);} | ^ fio.h:67:26: note: expected 'char *' but argument is of type 'const char *' 67 | extern void f__fatal(int,char*); | ^~~~~ sfe.c:23:39: warning: passing argument 2 of 'f__fatal' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers] 23 | if(!p->ufmt) err(a->cierr,102,"sfe") | ^~~~~ fio.h:88:53: note: in definition of macro 'err' 88 | #define err(f,m,s) {if(f) errno= m; else f__fatal(m,s); return(m);} | ^ fio.h:67:26: note: expected 'char *' but argument is of type 'const char *' 67 | extern void f__fatal(int,char*); | ^~~~~ sfe.c: At top level: sfe.c:26:9: warning: no previous prototype for 'e_wsfe' [-Wmissing-prototypes] 26 | integer e_wsfe(Void) | ^~~~~~ make[6]: *** [Makefile:677: sfe.lo] Error 1 make[6]: Leaving directory '/tmp/BUILD.fc40.x86_64/trinity-digikam-14.1.2~pre17+8f0b4a3a/digikam/imageplugins/coreplugin/sharpnesseditor/clapack' make[5]: *** [Makefile:699: all-recursive] Error 1 make[5]: Leaving directory '/tmp/BUILD.fc40.x86_64/trinity-digikam-14.1.2~pre17+8f0b4a3a/digikam/imageplugins/coreplugin/sharpnesseditor' make[4]: *** [Makefile:837: all-recursive] Error 1 make[4]: Leaving directory '/tmp/BUILD.fc40.x86_64/trinity-digikam-14.1.2~pre17+8f0b4a3a/digikam/imageplugins/coreplugin' make[3]: *** [Makefile:562: all-recursive] Error 1 make[3]: Leaving directory '/tmp/BUILD.fc40.x86_64/trinity-digikam-14.1.2~pre17+8f0b4a3a/digikam/imageplugins' make[2]: *** [Makefile:615: all-recursive] Error 1 make[2]: Leaving directory '/tmp/BUILD.fc40.x86_64/trinity-digikam-14.1.2~pre17+8f0b4a3a/digikam' make[1]: *** [Makefile:615: all-recursive] Error 1 make[1]: Leaving directory '/tmp/BUILD.fc40.x86_64/trinity-digikam-14.1.2~pre17+8f0b4a3a' make: *** [Makefile:532: all] Error 2 ```

SlavekB referenced this issue from a commit 2 weeks ago

Add missing return type in function implementations.

SlavekB commented 2 weeks ago

Owner

PR updated, other iterations can continue.

PR updated, other iterations can continue.

Francois commented 2 weeks ago

Poster

Collaborator

Nice @SlavekB , now digikam is built on Fedora 40. No more FTBFS.

Nice @SlavekB , now digikam is built on Fedora 40. No more FTBFS.

SlavekB commented 2 weeks ago

Owner

Great, thank you for your excellent cooperation.

Great, thank you for your excellent cooperation.

MicheleC commented 2 weeks ago

Owner

@Francois even though the FTBFS was already fixed by Slavek's code, I have added a second commit to the PR that removes old style unnecessary K&R function declarations. Could you test PR #24 one more time if you don't mind? It shouldn't cause any problem, but better to be sure.

@Francois even though the FTBFS was already fixed by Slavek's code, I have added a second commit to the PR that removes old style unnecessary K&R function declarations. Could you test PR #24 one more time if you don't mind? It shouldn't cause any problem, but better to be sure.

MicheleC referenced this issue from TDE/tde 2 weeks ago

Fix building with Fedora 40 #169

Francois commented 2 weeks ago

Poster

Collaborator

The latest patch still works on Fedora 40. Thanks @MicheleC .

The latest patch still works on Fedora 40. Thanks @MicheleC .

MicheleC commented 2 weeks ago

Owner

Thanks for the second test @Francois

Thanks for the second test @Francois

SlavekB referenced this issue from a commit 2 weeks ago

Add missing return type in function implementations.

SlavekB closed this issue 2 weeks ago

SlavekB added this to the R14.1.2 release milestone 2 weeks ago

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

r14.1.x

master

feat/digikam-usability

r14.0.x

v3.5.13-sru

r14.1.2

r14.1.1

r14.1.0

r14.0.13

r14.0.12

r14.0.11

r14.0.10

r14.0.9

r14.0.8

r14.0.7

r14.0.6

r14.0.5

r14.0.4

r14.0.3

r14.0.2

r14.0.1

r14.0.0

v3.5.13.2

v3.5.13.1

v3.5.13

Labels

Apply labels

Clear labels

GE/need-info
General - need additional info from contributor PR/keep-branch
Pull request - do not delete branch after merging PR/not-ok
Pull request - need fixing PR/rfc
Pull request - request for comments PR/update-trans
Pull request - update to translation files needed PR/wip
Pull request - work in progress RS/R14.0.x
Related to R14.0.x series RS/R14.1.x
Related to R14.1.x series SL/critical
Severity level - critical SL/major
Severity level - major SL/minor
Severity level - minor SL/normal
Severity level - normal SL/regression
Severity level - regression from previous version SL/trivial
Severity level - trivial SL/wishlist
Severity level - wishlist request ST/duplicate
Status - duplicate of another issue ST/invalid
Status - invalid report ST/notourproblem
Status - not our problem ST/rejected
Status - rejected ST/wontfix
Status - won't fix ST/worksforme
Status - works for me, unable to reproduce

No Label GE/need-info PR/keep-branch PR/not-ok PR/rfc PR/update-trans PR/wip RS/R14.0.x RS/R14.1.x SL/critical SL/major SL/minor SL/normal SL/regression SL/trivial SL/wishlist ST/duplicate ST/invalid ST/notourproblem ST/rejected ST/wontfix ST/worksforme

Milestone

Set milestone

Clear milestone

No items

No Milestone

R14.1.2 release

Assignees

Assign users

Clear assignees

No Assignees

3 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: TDE/digikam#23

Write Preview

Loading…

Cancel

Save

There is no content yet.