Add missing return type in function implementations. #24

Merged

SlavekB merged 2 commits from fix/23/ftbfs-on-fedora40 into master

SlavekB commented

Owner

This resolves issue #23.

It is necessary to test from @Francois if there are other problems to solve.

SlavekB added 1 commit

9dd8433608

Add missing return type in fk_open function implementation.

This resolves issue #23.

Signed-off-by: Slávek Banko <slavek.banko@axis.cz>

SlavekB added this to the R14.1.2 release milestone

SlavekB requested review from Owners

SlavekB requested review from Core

SlavekB referenced this pull request

Build issue: FTBFS on Fedora 40 #23

SlavekB force-pushed fix/23/ftbfs-on-fedora40 from 9dd8433608 to 4b338b845d

SlavekB changed title from ~~Add missing return type in fk_open function implementation.~~ to Add missing return type in function implementations.

SlavekB force-pushed fix/23/ftbfs-on-fedora40 from 4b338b845d to 49f4d44dd7

SlavekB force-pushed fix/23/ftbfs-on-fedora40 from 49f4d44dd7 to a79a29ef5c

SlavekB force-pushed fix/23/ftbfs-on-fedora40 from a79a29ef5c to 7bf4ecad4a

SlavekB force-pushed fix/23/ftbfs-on-fedora40 from 7bf4ecad4a to 9f8bda51db

MicheleC reviewed

digikam/imageplugins/coreplugin/sharpnesseditor/clapack/err.c

													
					#define MAXERR (sizeof(F_err)/sizeof(char *)+100)

					#ifdef KR_headers

MicheleC commented

Owner

Do we need KR header format at all? All modern compiler should be able to handle the alternate format, which is way more readable.

MicheleC added 1 commit

4dabefbee0

Drop old K&R style function declarations

Signed-off-by: Michele Calgaro <michele.calgaro@yahoo.it>

MicheleC commented

Owner

I added a commit removing all the old style K&R function declarations. Builds fine in Debian.

MicheleC referenced this pull request

Build issue: FTBFS on Fedora 40 #23

MicheleC referenced this pull request from TDE/tde

Fix building with Fedora 40 #169

MicheleC approved these changes

MicheleC left a comment

Owner

Looks good

SlavekB merged commit 4dabefbee0 into master 1 month ago

SlavekB deleted branch fix/23/ftbfs-on-fedora40

Reviewers

MicheleC approved these changes

TDE/Core was requested for review

The pull request has been merged as 4dabefbee0.

Sign in to join this conversation.

TDE/Core

No Assignees

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/digikam#24