This will add three new mimetypes (jar, txz, lzma) in order to browse through (double-click) those kind of archive files.
Tested with:
gjar cvf myfolder.jar myfolder (gjar from Oracle JDK)
tar cvJf myfolder.tar.xz myfolder
tar cvf myfolder.tar.lzma --lzma myfolder (legacy lzma)
This will add three new mimetypes (jar, txz, lzma) in order to browse through (double-click) those kind of archive files.
Tested with:
- gjar cvf myfolder.jar myfolder (gjar from Oracle JDK)
- tar cvJf myfolder.tar.xz myfolder
- tar cvf myfolder.tar.lzma --lzma myfolder (legacy lzma)
The patch is good but not enough. If we add support for .tar.XYZ extenstion, we need to add support also for simple .XYZ extension. For example, tlzma files are supported but lzma files still open ark.
Please fix the patch and submit again.
The patch is good but not enough. If we add support for .tar.XYZ extenstion, we need to add support also for simple .XYZ extension. For example, tlzma files are supported but lzma files still open ark.
Please fix the patch and submit again.
As far I understand this, the code is not meant to open (browse through) compressed files.
It has been written for two kind of archives (zip and tar) hence the famous zip.protocol and tar.protocol.
Might be as easy as adding a new mimetype (x-lzma) but I didn't test It, since this is not an archive.
As far I understand this, the code is not meant to open (browse through) compressed files.
It has been written for two kind of archives (zip and tar) hence the famous zip.protocol and tar.protocol.
Might be as easy as adding a new mimetype (x-lzma) but I didn't test It, since this is not an archive.
I tested other simple non-tarred extensions (.gz, .lzma, .bz2), they all open Ark. So the PR as it is at this moment, is consistent.
If would be worth adding support for those formats too, but better to treat that as a separate issue and separate PR.
I tested other simple non-tarred extensions (.gz, .lzma, .bz2), they all open Ark. So the PR as it is at this moment, is consistent.<br>
If would be worth adding support for those formats too, but better to treat that as a separate issue and separate PR.
This will add three new mimetypes (jar, txz, lzma) in order to browse through (double-click) those kind of archive files.
Tested with:
The patch is good but not enough. If we add support for .tar.XYZ extenstion, we need to add support also for simple .XYZ extension. For example, tlzma files are supported but lzma files still open ark.
Please fix the patch and submit again.
As far I understand this, the code is not meant to open (browse through) compressed files.
It has been written for two kind of archives (zip and tar) hence the famous zip.protocol and tar.protocol.
Might be as easy as adding a new mimetype (x-lzma) but I didn't test It, since this is not an archive.
I tested other simple non-tarred extensions (.gz, .lzma, .bz2), they all open Ark. So the PR as it is at this moment, is consistent.
If would be worth adding support for those formats too, but better to treat that as a separate issue and separate PR.
Approved after further discussion on tde-devs channel
merged to R14.1.0 branch. Since it is new functionality, it won't go into R14.0.6, as was done for .xz support in ark some years ago.
Solves issue #4
1cc8bb41d3
.