tqt-updates-2023 #8

Closed
deloptes wants to merge 1 commits from fix/pinentry-tqt-updates-2023 into master
Collaborator

Signed-off-by: Emanoil Kotsev deloptes@gmail.com

Please review the changes, as I did not check if all macros and conditionals were renamed. As mentioned before QT_H was not changed to TQT_H

Signed-off-by: Emanoil Kotsev <deloptes@gmail.com> Please review the changes, as I did not check if all macros and conditionals were renamed. As mentioned before QT_H was not changed to TQT_H
deloptes added the PR/rfc label 7 months ago
deloptes added 1 commit 7 months ago
601661272f
tqt-updates-2023
MicheleC requested changes 7 months ago
MicheleC left a comment
Owner

Some of the defines have not been renamed yet. PLease adjust as needed. I did not point out all usage of unrenamed defines, but at least one for each. Please grep and adjust accordingly.

Some of the defines have not been renamed yet. PLease adjust as needed. I did not point out all usage of unrenamed defines, but at least one for each. Please grep and adjust accordingly.
stop();
}
#ifdef QT_CHECK_STATE
#ifdef TQT_CHECK_STATE
Owner

Not renamed yet

Not renamed yet
deloptes marked this conversation as resolved
void deleteSelf();
TQChar *unicode;
#ifdef Q_OS_MAC9
#ifdef TQ_OS_MAC9
Owner

Not renamed yet

Not renamed yet
deloptes marked this conversation as resolved
// all this is not documented: We just say "like TQChar" and let it be.
#ifndef Q_QDOC
#ifndef TQ_QDOC
Owner

Not renamed yet

Not renamed yet
deloptes marked this conversation as resolved
deloptes added 1 commit 7 months ago
d2a5ee47ac
pinetry-tqt-updates-2023: Follow up on changed defines
deloptes requested review from MicheleC 7 months ago
Poster
Collaborator

Updated all files where these three defines occurred (commit: 80e5e59fdf). You can remove the RFC and merge.

BR

Updated all files where these three defines occurred (commit: 80e5e59fdf6183ed50c126a57e4856d78308d6f3). You can remove the RFC and merge. BR
deloptes force-pushed fix/pinentry-tqt-updates-2023 from d2a5ee47ac to 80e5e59fdf 7 months ago
SlavekB requested changes 7 months ago
SlavekB left a comment
Owner
  1. There are still some renaming QT_... => TQT_... that has not yet been done in TQt.
  2. You need to make a rebase to the current head.
  3. A slightly different rules apply to extra-dependencies repository. Source codes must remain the same according to the relevant orig.tar. Once the patch is final, then instead of changing the source code, the patch must be inserted as a separate patch to debian/patches/... and is needed to add a record and change the version in debian/changelog.
1. There are still some renaming `QT_...` => `TQT_...` that has not yet been done in TQt. 2. You need to make a rebase to the current head. 3. A slightly different rules apply to extra-dependencies repository. Source codes must remain the same according to the relevant `orig.tar`. Once the patch is final, then instead of changing the source code, the patch must be inserted as a separate patch to `debian/patches/...` and is needed to add a record and change the version in `debian/changelog`.
static TQCleanupHandler<TQPixmap> qdb_pixmap_cleanup;
#ifdef Q_WS_MACX
#ifdef TQ_WS_MACX
Owner

All Q_WS_... are still without T prefix.

All `Q_WS_...` are still without `T` prefix.
deloptes marked this conversation as resolved
#include "private/qtextlayout_p.h"
#include "ntqvaluevector.h"
#if defined(QT_ACCESSIBILITY_SUPPORT)
#if defined(TQT_ACCESSIBILITY_SUPPORT)
Owner

QT_ACCESSIBILITY_SUPPORT is still without T prefix.

`QT_ACCESSIBILITY_SUPPORT` is still without `T` prefix.
deloptes marked this conversation as resolved
case Key_Left:
case Key_Right:
#if defined (Q_WS_WIN)
#if defined (TQ_WS_WIN)
Owner

All Q_WS_... are still without T prefix.

All `Q_WS_...` are still without `T` prefix.
deloptes marked this conversation as resolved
deloptes force-pushed fix/pinentry-tqt-updates-2023 from 80e5e59fdf to 7b5fee0278 7 months ago
deloptes force-pushed fix/pinentry-tqt-updates-2023 from 7b5fee0278 to 2ff0c6bca8 7 months ago
deloptes force-pushed fix/pinentry-tqt-updates-2023 from 2ff0c6bca8 to 551d331e7e 7 months ago
Poster
Collaborator

Hi Slavek,
thank you for pointing this out. I double checked against the headers in /usr/include and I think this is OK.

Please review and give OK. I will prepare the patch/quilt. It happened so that I read recently the howto and I think I can do it. It means I will create another PR.

BR

Hi Slavek, thank you for pointing this out. I double checked against the headers in /usr/include and I think this is OK. Please review and give OK. I will prepare the patch/quilt. It happened so that I read recently the howto and I think I can do it. It means I will create another PR. BR
deloptes requested review from SlavekB 7 months ago
SlavekB approved these changes 7 months ago
SlavekB left a comment
Owner

Everything looks good. I will formally approve it, although we know that it is not intended to be merged in this form.

Everything looks good. I will formally approve it, although we know that it is not intended to be merged in this form.
Owner

I think we should add WIP in the title and close it, to prevent accidental merging.

I think we should add WIP in the title and close it, to prevent accidental merging.
Owner

For reference see PR #10.

For reference see PR #10.
Poster
Collaborator

We can delete this PR

We can delete this PR
deloptes closed this pull request 7 months ago
deloptes deleted branch fix/pinentry-tqt-updates-2023 7 months ago

Reviewers

MicheleC was requested for review 7 months ago
SlavekB approved these changes 7 months ago
This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
No Milestone
No Assignees
3 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/extra-dependencies#8
Loading…
There is no content yet.