Removed HAL dependant code. #13

Merged
MicheleC merged 1 commits from drop/hal-support into master 2 years ago
Owner

Beside the code removal, there has been some class and enum renaming.
Build fine here in bullseye, suggest we test on other distros too.

Beside the code removal, there has been some class and enum renaming. Build fine here in bullseye, suggest we test on other distros too.
MicheleC added 1 commit 2 years ago
f61e3574e7
Removed HAL dependant code.
MicheleC added this to the R14.1.0 release milestone 2 years ago
MicheleC requested review from SlavekB 2 years ago
SlavekB reviewed 2 years ago
SlavekB left a comment
Owner

Tested building on Bullseye@i386 and Xenial@i386 – both successfully.
There is one note for consideration, see below.

Tested building on Bullseye@i386 and Xenial@i386 – both successfully. There is one note for consideration, see below.
* Error codes named as the deamon raises them
*/
enum ErrorCodes {
org_freedesktop_Success = 0, //*< The operation was successful.
Owner

Leaving org_freedesktop_, which is directly related to HAL looks weird. There might be, for example, state_?

Leaving `org_freedesktop_`, which is directly related to HAL looks weird. There might be, for example, `state_`?
Poster
Owner

That's a good idea, I will update accordingly.

That's a good idea, I will update accordingly.
MicheleC marked this conversation as resolved
MicheleC force-pushed drop/hal-support from f61e3574e7 to ce3d9531b6 2 years ago
MicheleC merged commit ce3d9531b6 into master 2 years ago
MicheleC deleted branch drop/hal-support 2 years ago
Poster
Owner

Done, thanks for testing on old distros.

Done, thanks for testing on old distros.

Reviewers

SlavekB was requested for review 2 years ago
The pull request has been merged as ce3d9531b6.
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/k3b#13
Loading…
There is no content yet.