TDE
/
k9copy
6
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
Labels Milestones

Normalize doc structure and remove unused files #11

Merged
MicheleC merged 4 commits from fix/doc-structure into master 9 months ago
Conversation 1 Commits 4 Files Changed 47
MicheleC commented 10 months ago
Owner

The changes to the doc folder are required so that we can use the 'tde_conditional_add_project_docs' macro in cmake conversion. index.xml is an older version of index.docbook.

dvdread.c is not used in automake builds and would FTBFS due to unknown data type DvdreadFunctions_t.

The second commits fixes TQString-related code that causes FTBFS with cmake (can't convert from TQString to const char*).

On deb distros to be build with TDE/tde-packaging#241.

The changes to the `doc` folder are required so that we can use the 'tde_conditional_add_project_docs' macro in cmake conversion. `index.xml` is an older version of `index.docbook`. `dvdread.c` is not used in automake builds and would FTBFS due to unknown data type `DvdreadFunctions_t`. The second commits fixes TQString-related code that causes FTBFS with cmake (can't convert from TQString to const char*). On deb distros to be build with TDE/tde-packaging#241.
MicheleC added this to the R14.1.1 release milestone 10 months ago
MicheleC added 1 commit 10 months ago
MicheleC requested review from Core 10 months ago
MicheleC requested review from Owners 10 months ago
MicheleC force-pushed fix/doc-structure from cd44708852 to 82ce6a04cd 10 months ago
MicheleC changed title from Normalize doc structure and remove outdated index.xml file (index.docbook is a more recent version) to Normalize doc structure and remove unused files 10 months ago
MicheleC added 1 commit 10 months ago
a1e46ff5ee
Fix usage of TQString where const chat* is required
MicheleC force-pushed fix/doc-structure from a1e46ff5ee to 668f78446e 10 months ago
MicheleC force-pushed fix/doc-structure from 668f78446e to dd98439deb 10 months ago
SlavekB approved these changes 9 months ago
SlavekB left a comment
Owner

Ok, everything seems to be fine.

Ok, everything seems to be fine.
MicheleC commented 9 months ago
Poster
Owner

I will hold merging this PR till I complete the cmake conversion, in case I need to add some more changes related to string conversions.
In case of more changes, I will ask for a new review. In case of no more changes, I will merge when done.

I will hold merging this PR till I complete the cmake conversion, in case I need to add some more changes related to string conversions. In case of more changes, I will ask for a new review. In case of no more changes, I will merge when done.
MicheleC force-pushed fix/doc-structure from dd98439deb to 09670a009d 9 months ago
MicheleC added 1 commit 9 months ago
27fabe3494
Move icons folder to main level.
MicheleC force-pushed fix/doc-structure from 27fabe3494 to fc2f5dbb3d 9 months ago
MicheleC force-pushed fix/doc-structure from fc2f5dbb3d to 75ba9287ea 9 months ago
MicheleC force-pushed fix/doc-structure from 75ba9287ea to 9bd9ef8bf4 9 months ago
SlavekB requested changes 9 months ago
SlavekB left a comment
Owner

It looks good, but there's one problem.
See the comment below.

It looks good, but there's one problem. See the comment below.
NEWS
SlavekB commented 9 months ago
Owner

Some files are strictly required for automake build. NEWS is one of these necessary files, otherwise it leads to FTBFS with automake building.

Some files are strictly required for automake build. `NEWS` is one of these necessary files, otherwise it leads to FTBFS with automake building.
MicheleC commented 9 months ago
Poster
Owner

The code from this PR can be successfully built on trixie with the associated debian PR. So it does not seems NEWS is strictly required.

The code from this PR can be successfully built on trixie with the associated debian PR. So it does not seems `NEWS` is strictly required.
SlavekB commented 9 months ago
Owner

I did test on Buster and it caused FTBFS without NEWS. That was why I did a test and why I reported it as a problem.

I did test on Buster and it caused FTBFS without `NEWS`. That was why I did a test and why I reported it as a problem.
MicheleC commented 9 months ago
Poster
Owner

NEWS and TODO restored as discussed. TDE/tde-packaging#241 no longer needed.

NEWS and TODO restored as discussed. TDE/tde-packaging#241 no longer needed.
MicheleC marked this conversation as resolved
MicheleC force-pushed fix/doc-structure from 9bd9ef8bf4 to f0853effc6 9 months ago
MicheleC force-pushed fix/doc-structure from f0853effc6 to 4dcfa83500 9 months ago
MicheleC requested review from SlavekB 9 months ago
SlavekB approved these changes 9 months ago
SlavekB left a comment
Owner

All seems good.

All seems good.
MicheleC merged commit 4dcfa83500 into master 9 months ago
MicheleC deleted branch fix/doc-structure 9 months ago

Reviewers

SlavekB approved these changes 9 months ago
TDE/Core was requested for review 10 months ago
The pull request has been merged as 4dcfa83500.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
SlavekB
TDE/Core
Labels
Apply labels
Clear labels
GE/need-info
General - need additional info from contributor PR/keep-branch
Pull request - do not delete branch after merging PR/not-ok
Pull request - need fixing PR/rfc
Pull request - request for comments PR/update-trans
Pull request - update to translation files needed PR/wip
Pull request - work in progress RS/R14.0.x
Related to R14.0.x series RS/R14.1.x
Related to R14.1.x series SL/critical
Severity level - critical SL/major
Severity level - major SL/minor
Severity level - minor SL/normal
Severity level - normal SL/regression
Severity level - regression from previous version SL/trivial
Severity level - trivial SL/wishlist
Severity level - wishlist request ST/duplicate
Status - duplicate of another issue ST/invalid
Status - invalid report ST/notourproblem
Status - not our problem ST/rejected
Status - rejected ST/wontfix
Status - won't fix ST/worksforme
Status - works for me, unable to reproduce
No Label GE/need-info PR/keep-branch PR/not-ok PR/rfc PR/update-trans PR/wip RS/R14.0.x RS/R14.1.x SL/critical SL/major SL/minor SL/normal SL/regression SL/trivial SL/wishlist ST/duplicate ST/invalid ST/notourproblem ST/rejected ST/wontfix ST/worksforme
Milestone
Set milestone
Clear milestone
No items
No Milestone
R14.1.1 release
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/k9copy#11
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'fix/doc-structure'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes