Rename installed files to kbookreader, used common tde_add_project_* macros #3

Merged
SlavekB merged 2 commits from feat/cmake-update into master 3 years ago
Owner

Because all installed components use the bookreader name (it is also necessary for translations that were previously installed as kbookreader and therefore ignored), here it seems no doubt about renaming CMake project to bookreader instead of kbookreader?

Because all installed components use the _bookreader_ name (it is also necessary for translations that were previously installed as _kbookreader_ and therefore ignored), here it seems no doubt about renaming CMake project to `bookreader` instead of `kbookreader`?
SlavekB added this to the R14.0.11 release milestone 3 years ago
SlavekB added the PR/rfc label 3 years ago
SlavekB added 2 commits 3 years ago
bac831945a
Changed the CMake project name to bookreader.
MicheleC approved these changes 3 years ago
MicheleC left a comment
Owner

It seems to make sense, given in the source there are continuous references to bookreader instead of kbookreader.
We should also rename the repository to bookreader then, it makes no sense to still call it kbookreader.

It seems to make sense, given in the source there are continuous references to bookreader instead of kbookreader. We should also rename the repository to bookreader then, it makes no sense to still call it kbookreader.
Poster
Owner

The original project we took over was named kbookreader and therefore we used this name for repository and package. It is true that there was a contradiction between the name of the project and the names of the installed files from the beginning.

So here it makes sense to think about the unification of the name. However, the name bookreader seems to be too general to use it for the name of the repository and the package.

The original project we took over was named _kbookreader_ and therefore we used this name for repository and package. It is true that there was a contradiction between the name of the project and the names of the installed files from the beginning. So here it makes sense to think about the unification of the name. However, the name _bookreader_ seems to be too general to use it for the name of the repository and the package.
Owner

I agree on the fact thet a name "bookreader" is probably too generic. kbookreader or tdebookreader is more appropriate.

Naming the project differently from the repo is probably not a good idea though, so I favor the unification idea. Perhaps we can rename the executable/desktop file/other files into kbookreader instead?

I agree on the fact thet a name "bookreader" is probably too generic. kbookreader or tdebookreader is more appropriate. Naming the project differently from the repo is probably not a good idea though, so I favor the unification idea. Perhaps we can rename the executable/desktop file/other files into kbookreader instead?
Poster
Owner

Yes, there seems to be good time to rename the binary and other files to kboookreader to do this consistent with the module name.

Yes, there seems to be good time to rename the binary and other files to kboookreader to do this consistent with the module name.
SlavekB force-pushed feat/cmake-update from c5fbfcb78f to d45ce923db 3 years ago
SlavekB changed title from Changed CMake project name to bookreader, used common tde_add_project_* macros to Rename installed files to kbookreader, used common tde_add_project_* macros 3 years ago
SlavekB requested review from MicheleC 3 years ago
Poster
Owner

I tried to go through the smallest range of changes. Therefore, I renamed only the files for which it is necessary.

I tried to go through the smallest range of changes. Therefore, I renamed only the files for which it is necessary.
MicheleC approved these changes 3 years ago
MicheleC left a comment
Owner

Looks good 👍

Looks good :+1:
SlavekB removed the PR/rfc label 3 years ago
SlavekB merged commit d45ce923db into master 3 years ago
SlavekB deleted branch feat/cmake-update 3 years ago

Reviewers

MicheleC approved these changes 3 years ago
The pull request has been merged as d45ce923db.
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/kbookreader#3
Loading…
There is no content yet.