Rename installed files to kbookreader, used common tde_add_project_* macros #3
Merged
SlavekB
merged 2 commits from feat/cmake-update
into master
3 years ago
Loading…
Reference in new issue
There is no content yet.
Delete Branch 'feat/cmake-update'
Deleting a branch is permanent. It CANNOT be undone. Continue?
Because all installed components use the bookreader name (it is also necessary for translations that were previously installed as kbookreader and therefore ignored), here it seems no doubt about renaming CMake project to
bookreader
instead ofkbookreader
?It seems to make sense, given in the source there are continuous references to bookreader instead of kbookreader.
We should also rename the repository to bookreader then, it makes no sense to still call it kbookreader.
The original project we took over was named kbookreader and therefore we used this name for repository and package. It is true that there was a contradiction between the name of the project and the names of the installed files from the beginning.
So here it makes sense to think about the unification of the name. However, the name bookreader seems to be too general to use it for the name of the repository and the package.
I agree on the fact thet a name "bookreader" is probably too generic. kbookreader or tdebookreader is more appropriate.
Naming the project differently from the repo is probably not a good idea though, so I favor the unification idea. Perhaps we can rename the executable/desktop file/other files into kbookreader instead?
Yes, there seems to be good time to rename the binary and other files to kboookreader to do this consistent with the module name.
c5fbfcb78f
tod45ce923db
3 years agoChanged CMake project name to bookreader, used common tde_add_project_* macrosto Rename installed files to kbookreader, used common tde_add_project_* macros 3 years agoI tried to go through the smallest range of changes. Therefore, I renamed only the files for which it is necessary.
Looks good 👍
d45ce923db
into master 3 years agoReviewers
d45ce923db
.