cmake conversion #1

Fusionnée
SlavekB a fusionné 1 révision(s) à partir de feat/cmakeConv vers master il y a 5 ans
Ghost a commenté il y a 5 ans

Don't feel at ease with this one.
I couldn't build It with automake, so this is built with cmake right from the get-go.
The heimdal package (which is needed for libtdeldap) provided by slackbuilds locked me out of my root account through the 'su' command till I figured out what was going on.
The 'doc' folder is actually empty.
There is no *.po files in the 'po' folder, I've added a CMakeLists.txt nonetheless.
Waiting for your comments Slavek.

I'll change 'requested' to 'required' after your comments.

Don't feel at ease with this one. I couldn't build It with automake, so this is built with cmake right from the get-go. The heimdal package (which is needed for libtdeldap) provided by slackbuilds locked me out of my root account through the 'su' command till I figured out what was going on. The 'doc' folder is actually empty. There is no *.po files in the 'po' folder, I've added a CMakeLists.txt nonetheless. Waiting for your comments Slavek. I'll change 'requested' to 'required' after your comments.
Ghost a ajouté l'étiquette PR/rfc il y a 5 ans
Propriétaire

Yes, right, requested => required would have my comment 😸 However, because I encountered some other problems, I solved it in a subsequent patch:

  1. On Debian, some include are still in the subdirectory ${TDE_INCLUDE_DIR}/tde.

  2. Include files for kerberos may be in a special directory – for example, to allow both MIT and Heimdal to be installed concurrently. So I added the KRB5 library detection and ${KRB5_INCLUDE_DIRS}.

  3. Traditional problem with includes in UI files.

  4. Occasional problem with improper automoc.

  5. Unexpectedly different solution for TQT_NO_ASCII_CAST.

In any case, your base was good.

Yes, right, requested => required would have my comment :smile_cat: However, because I encountered some other problems, I solved it in a subsequent patch: 1. On Debian, some include are still in the subdirectory ${TDE_INCLUDE_DIR}/tde. 2. Include files for kerberos may be in a special directory – for example, to allow both MIT and Heimdal to be installed concurrently. So I added the KRB5 library detection and ${KRB5_INCLUDE_DIRS}. 3. Traditional problem with includes in UI files. 4. Occasional problem with improper automoc. 5. Unexpectedly different solution for TQT_NO_ASCII_CAST. In any case, your base was good.
SlavekB a supprimé l'étiquette PR/rfc il y a 5 ans
SlavekB a fermé cette pull request il y a 5 ans
SlavekB a supprimé la branche feat/cmakeConv il y a 5 ans
SlavekB a ajouté cela au jalon R14.0.6 release il y a 5 ans
La demande d'ajout a été fusionnée en 43342288ee.
Connectez-vous pour rejoindre cette conversation.
Aucune évaluation
Aucun jalon
Pas d'assignataires
2 participants
Notifications
Échéance

Aucune échéance n'a été définie.

Dépendances

No dependencies set.

Reference: TDE/kcmldap#1
Chargement…
Il n'existe pas encore de contenu.