Remove "minimum version of KDE needed" check of Kiosktool. #4

Marked as translation update required, since we need to remove the string from the translation files too.

The question is whether updating of translations needs to be addressed. After the next update of the POT files, the string will automatically disappear from the template and will then be moved as "outdated" in the PO files.

I think we should still need to update translation. Since the strings would disappear from the .pot file, I see no reasons to keep the now-unused strings in the .po files 😄

Yes, it is true that it will not be useful for this string to be kept as obsolete in PO files 😸

Michele, that is a good thing to talk about. I just had the same idea to remove them. But we did not do it for other commits, so I thought it would be unneeded.

From Slavek I learned what he wrote above and so thought that there are maybe a good bunch of unused strings in the *.po files already. That might be a good thing to review at some point. I don't know.

I will remove the unused strings from the *.pot and *.po files anyway today or tomorrow. 👍

IMO, if a string is not in a pot file and we are aware of that, it makes no sense to keep it in the po files.
@Chris: thanks for the excellent work you are doing in polishing the brand thing.

With PO files, this is done as follows:

When the string disappears from the template (ie POT) file and its translation has been included in the existing PO files, such translation is pushed to the end of the file and is marked as obsolete with the #~ tag.

The idea is that older translations do not disappear immediately, but could be useful for translators if a similar string or part of it appears again and the translation or part of it can be reused. Such strings are not included in binary mo files, but can save time for translators.

Therefore, it is usually expedient to leave the original translations to be processed by this mechanism. However, in this case it seems quite certain that a similar translation will not be used here, so it can be removed.

@SlavekB yes, I understand your point and it makes sense. On the otherhand, I have two observations to do:

would those obsolete strings be available through weblate for the translators, since the original string is no longer in the .pot file?
it is more likely that a translator simply work on strings one after another insteand of looking around (weblate or source code) to compare to other strings. Just my two cents on this.

Yes, you're right. These obsolete strings are not visible on the Weblate, so translators would have to search the source PO files, which they usually won't do.