Change default backend from Nettools to Sys. #4
Merged
MicheleC
merged 1 commits from feat/sys_backend into master 3 years ago
MicheleC
Loading…
Reference in new issue
There is no content yet.
Delete Branch 'feat/sys_backend'
Deleting a branch is permanent. It CANNOT be undone. Continue?
The Sys backend works contrary to the Nettools backend so I'm changing the default backend.
It is a tweak (or a pita one may say...) because the net-tools should be working, but at least Knemo will work from the "get-go" from now on.
Looks good and I think it is a good idea to have "sys" as default backend. Will work in many systems out of the box.
7e5ea16f1ato0bbb027ba53 years agoWIP:Change default backend from Nettools to Sys.to Change default backend from Nettools to Sys. 3 years ago0bbb027ba5to3ee43d19a03 years ago3ee43d19a0to32e1e2a0903 years agoNeeds removal of CMakeLists.txt changes, which belong to a different PR (#5).
Other than that, it is good to go, as was commit
7e5ea16f1a.##### optional stuffoption( WITH_ALL_OPTIONS "Enable all optional support" OFF )option( WITH_ALL_OPTIONS "Enable all optional support" OFF )Hi Greg,
I guess when the new forced-pushed commit was done, this CMakeLists.txt stuff slipt through by mistake. It was not there in the original commit (
7e5ea16f1a)Could you clean up this commit again if you don't mind? Then I will merge.
yes my bad I pushed in the wrong branch by mistake, but unless I've been missing something, this does not add or remove anything It is just some indentation changes, furthermore I'll be using this indent in my next PR because CMakeLists.txt files are more readable that way.
Correct, there is no issues with that. Just that is was also used in PR #5. As long as you rebase #5 after this PR is merged, then no problem.
I will merge as is then.
32e1e2a090toa9e1d50df43 years agoa9e1d50df4into master 3 years agoThanks Greg!
Reviewers
a9e1d50df4.