TDE
/
knights
6
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
Labels Milestones

Replace Qt with TQt #10

Merged
MicheleC merged 1 commits from replace/qt-tqt into master 6 months ago
Conversation 1 Commits 1 Files Changed 18
MicheleC commented 6 months ago
Owner

Qt class object will later be removed from tqtinterface.

Qt class object will later be removed from tqtinterface.
MicheleC added this to the R14.1.2 release milestone 6 months ago
MicheleC added 1 commit 6 months ago
de5a964982
Replace Qt with TQt
MicheleC requested review from Core 6 months ago
MicheleC requested review from Owners 6 months ago
SlavekB requested changes 6 months ago
SlavekB left a comment
Owner

Here it is advisable to make minor adjustments – see the comments below.

Here it is advisable to make minor adjustments – see the comments below.
knights/board_2d.cpp
return;
/* Set Qt::Orientation */
/* Set TQt::Orientation */
SlavekB commented 6 months ago
Owner

Here was Qt:: added inadvertently during earlier automatic renaming. Therefore, instead of changing to TQt:: makes sense to remove it.

Here was `Qt::` added inadvertently during earlier automatic renaming. Therefore, instead of changing to `TQt::` makes sense to remove it.
MicheleC marked this conversation as resolved
knights/core.cpp
currentMatch->requestHint();
break;
/* Qt::Orientation */
/* TQt::Orientation */
SlavekB commented 6 months ago
Owner

Here was Qt:: added inadvertently during earlier automatic renaming. Therefore, instead of changing to TQt:: makes sense to remove it.

Here was `Qt::` added inadvertently during earlier automatic renaming. Therefore, instead of changing to `TQt::` makes sense to remove it.
MicheleC marked this conversation as resolved
MicheleC force-pushed replace/qt-tqt from de5a964982 to 1d296b0a23 6 months ago
MicheleC commented 6 months ago
Poster
Owner

PR updated

PR updated
MicheleC requested review from SlavekB 6 months ago
SlavekB approved these changes 6 months ago
SlavekB left a comment
Owner

It looks good.

It looks good.
MicheleC merged commit 1d296b0a23 into master 6 months ago
MicheleC deleted branch replace/qt-tqt 6 months ago

Reviewers

SlavekB approved these changes 6 months ago
TDE/Core was requested for review 6 months ago
The pull request has been merged as 1d296b0a23.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
SlavekB
TDE/Core
Labels
Apply labels
Clear labels
GE/need-info
General - need additional info from contributor PR/keep-branch
Pull request - do not delete branch after merging PR/not-ok
Pull request - need fixing PR/rfc
Pull request - request for comments PR/update-trans
Pull request - update to translation files needed PR/wip
Pull request - work in progress RS/R14.0.x
Related to R14.0.x series RS/R14.1.x
Related to R14.1.x series SL/critical
Severity level - critical SL/major
Severity level - major SL/minor
Severity level - minor SL/normal
Severity level - normal SL/regression
Severity level - regression from previous version SL/trivial
Severity level - trivial SL/wishlist
Severity level - wishlist request ST/duplicate
Status - duplicate of another issue ST/invalid
Status - invalid report ST/notourproblem
Status - not our problem ST/rejected
Status - rejected ST/wontfix
Status - won't fix ST/worksforme
Status - works for me, unable to reproduce
No Label GE/need-info PR/keep-branch PR/not-ok PR/rfc PR/update-trans PR/wip RS/R14.0.x RS/R14.1.x SL/critical SL/major SL/minor SL/normal SL/regression SL/trivial SL/wishlist ST/duplicate ST/invalid ST/notourproblem ST/rejected ST/wontfix ST/worksforme
Milestone
Set milestone
Clear milestone
No items
No Milestone
R14.1.2 release
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/knights#10
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'replace/qt-tqt'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes