TDE
/
knmap
6
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
Labels Milestones

cmake conversion #2

Merged
SlavekB merged 1 commits from feat/cmakeConv into master 6 years ago
Conversation 4 Commits 1 Files Changed 3
Ghost commented 6 years ago
There is no content yet.
Ghost added the PR/wip label 6 years ago
SlavekB commented 6 years ago
Owner

Probably inadvertently, some files for CMake had a set executable flag. Corrected.

At the same time I prepared patches for TQT_NO_COMPAT and TQT_NO_ASCII_CAST. It's nice to see that turning these definitions off signifies that something is wrong in the code 😄

Probably inadvertently, some files for CMake had a set executable flag. Corrected. At the same time I prepared patches for TQT_NO_COMPAT and TQT_NO_ASCII_CAST. It's nice to see that turning these definitions off signifies that something is wrong in the code :smile:
Ghost commented 6 years ago
Poster

I did notice the flags on these 3 files when I committed, git displayed them with chmod 755 and then I asked myself, Is it normal behavior? Let's push, see what Slavek will say.

It must have happen because I used these files to build the apps, I'll change that for a copy next time or check for that execute bit.

I did notice the flags on these 3 files when I committed, git displayed them with chmod 755 and then I asked myself, Is it normal behavior? Let's push, see what Slavek will say. It must have happen because I used these files to build the apps, I'll change that for a copy next time or check for that execute bit.
SlavekB commented 6 years ago
Owner

Everything seems to be ready to merge.

Everything seems to be ready to merge.
SlavekB removed the PR/wip label 6 years ago
SlavekB closed this pull request 6 years ago
SlavekB commented 6 years ago
Owner

Merged and pushed upstream.

Merged and pushed upstream.
SlavekB deleted branch feat/cmakeConv 6 years ago
SlavekB added this to the R14.0.6 release milestone 6 years ago
The pull request has been merged as 5c55403336.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
Labels
Apply labels
Clear labels
GE/need-info
General - need additional info from contributor PR/keep-branch
Pull request - do not delete branch after merging PR/not-ok
Pull request - need fixing PR/rfc
Pull request - request for comments PR/update-trans
Pull request - update to translation files needed PR/wip
Pull request - work in progress RS/R14.0.x
Related to R14.0.x series RS/R14.1.x
Related to R14.1.x series SL/critical
Severity level - critical SL/major
Severity level - major SL/minor
Severity level - minor SL/normal
Severity level - normal SL/regression
Severity level - regression from previous version SL/trivial
Severity level - trivial SL/wishlist
Severity level - wishlist request ST/duplicate
Status - duplicate of another issue ST/invalid
Status - invalid report ST/notourproblem
Status - not our problem ST/rejected
Status - rejected ST/wontfix
Status - won't fix ST/worksforme
Status - works for me, unable to reproduce
No Label GE/need-info PR/keep-branch PR/not-ok PR/rfc PR/update-trans PR/wip RS/R14.0.x RS/R14.1.x SL/critical SL/major SL/minor SL/normal SL/regression SL/trivial SL/wishlist ST/duplicate ST/invalid ST/notourproblem ST/rejected ST/wontfix ST/worksforme
Milestone
Set milestone
Clear milestone
No items
No Milestone
R14.0.6 release
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/knmap#2
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'feat/cmakeConv'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes