TDE
/
koffice-i18n
6
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
Labels Milestones

Fix syntax errors from #10. #13

Merged
SlavekB merged 1 commits from fix/syntax-errors-from-pr10 into master 1 month ago
Conversation 1 Commits 1 Files Changed 2
SlavekB commented 1 month ago
Owner

Small errors of syntax resulting from renaming in PR #10 cause FTBFS. Here are fixes.

Small errors of syntax resulting from renaming in PR #10 cause FTBFS. Here are fixes.
SlavekB added 1 commit 1 month ago
b892f66bbd
Fix syntax errors from #10.
SlavekB added this to the R14.1.2 release milestone 1 month ago
SlavekB requested review from Owners 1 month ago
SlavekB requested review from Core 1 month ago
MicheleC approved these changes 1 month ago
MicheleC left a comment
Owner

Looks good. I tried carefully to avoid those kind of mistakes in PR #10, but obviously a couple made it through.

Looks good. I tried carefully to avoid those kind of mistakes in PR #10, but obviously a couple made it through.
SlavekB commented 1 month ago
Poster
Owner

Looks good. I tried carefully to avoid those kind of mistakes in PR #10, but obviously a couple made it through.

There were many changes and as you can see, there was only a negligible number of mistakes. So you did it very successfully.

> Looks good. I tried carefully to avoid those kind of mistakes in PR #10, but obviously a couple made it through. There were many changes and as you can see, there was only a negligible number of mistakes. So you did it very successfully.
SlavekB merged commit b892f66bbd into master 1 month ago
SlavekB deleted branch fix/syntax-errors-from-pr10 1 month ago

Reviewers

MicheleC approved these changes 1 month ago
TDE/Core was requested for review 1 month ago
The pull request has been merged as b892f66bbd.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
MicheleC
TDE/Core
Labels
Apply labels
Clear labels
GE/need-info
General - need additional info from contributor PR/keep-branch
Pull request - do not delete branch after merging PR/not-ok
Pull request - need fixing PR/rfc
Pull request - request for comments PR/update-trans
Pull request - update to translation files needed PR/wip
Pull request - work in progress RS/R14.0.x
Related to R14.0.x series RS/R14.1.x
Related to R14.1.x series SL/critical
Severity level - critical SL/major
Severity level - major SL/minor
Severity level - minor SL/normal
Severity level - normal SL/regression
Severity level - regression from previous version SL/trivial
Severity level - trivial SL/wishlist
Severity level - wishlist request ST/duplicate
Status - duplicate of another issue ST/invalid
Status - invalid report ST/notourproblem
Status - not our problem ST/rejected
Status - rejected ST/wontfix
Status - won't fix ST/worksforme
Status - works for me, unable to reproduce
No Label GE/need-info PR/keep-branch PR/not-ok PR/rfc PR/update-trans PR/wip RS/R14.0.x RS/R14.1.x SL/critical SL/major SL/minor SL/normal SL/regression SL/trivial SL/wishlist ST/duplicate ST/invalid ST/notourproblem ST/rejected ST/wontfix ST/worksforme
Milestone
Set milestone
Clear milestone
No items
No Milestone
R14.1.2 release
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/koffice-i18n#13
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'fix/syntax-errors-from-pr10'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes