TDE
/
koffice
7
0
Fork 0
Code Issues 1 Pull Requests 1 Releases Wiki Activity
Labels Milestones

Replace _OBJECT_NAME_STRING defines with actual strings. This relates to the merging of tqtinterface with tqt3. #39

Merged
MicheleC merged 1 commits from replace/object_strings_defines into master 10 months ago
Conversation 1 Commits 1 Files Changed 69
MicheleC commented 10 months ago
Owner

Refer to these defines, which will later be removed from tqtinterface.
Can be safely backported to R14.1.1.

Refer to [these](https://mirror.git.trinitydesktop.org/gitea/TDE/tqtinterface/src/branch/master/qtinterface/tqt.h.cmake#L126-L249) defines, which will later be removed from tqtinterface. Can be safely backported to R14.1.1.
MicheleC added this to the R14.1.1 release milestone 10 months ago
MicheleC added 1 commit 10 months ago
MicheleC requested review from SlavekB 10 months ago
SlavekB approved these changes 10 months ago
SlavekB left a comment
Owner

Yes, it makes sense.
BTW, I assume that the use of constants *_OBJECT_NAME_STRING in Python script, SQL query or XML files could never work.

Yes, it makes sense. BTW, I assume that the use of constants `*_OBJECT_NAME_STRING` in Python script, SQL query or XML files could never work.
MicheleC commented 10 months ago
Poster
Owner

BTW, I assume that the use of constants *_OBJECT_NAME_STRING in Python script, SQL query or XML files could never work.

Exactly, it seems like a bug introduced in the original replacement

> BTW, I assume that the use of constants *_OBJECT_NAME_STRING in Python script, SQL query or XML files could never work. Exactly, it seems like a bug introduced in the original replacement
MicheleC merged commit 20e4a19b0d into master 10 months ago
MicheleC deleted branch replace/object_strings_defines 10 months ago

Reviewers

SlavekB approved these changes 10 months ago
The pull request has been merged as 20e4a19b0d.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
SlavekB
Labels
Apply labels
Clear labels
GE/need-info
General - need additional info from contributor PR/keep-branch
Pull request - do not delete branch after merging PR/not-ok
Pull request - need fixing PR/rfc
Pull request - request for comments PR/update-trans
Pull request - update to translation files needed PR/wip
Pull request - work in progress RS/R14.0.x
Related to R14.0.x series RS/R14.1.x
Related to R14.1.x series SL/critical
Severity level - critical SL/major
Severity level - major SL/minor
Severity level - minor SL/normal
Severity level - normal SL/regression
Severity level - regression from previous version SL/trivial
Severity level - trivial SL/wishlist
Severity level - wishlist request ST/duplicate
Status - duplicate of another issue ST/invalid
Status - invalid report ST/notourproblem
Status - not our problem ST/rejected
Status - rejected ST/wontfix
Status - won't fix ST/worksforme
Status - works for me, unable to reproduce
No Label GE/need-info PR/keep-branch PR/not-ok PR/rfc PR/update-trans PR/wip RS/R14.0.x RS/R14.1.x SL/critical SL/major SL/minor SL/normal SL/regression SL/trivial SL/wishlist ST/duplicate ST/invalid ST/notourproblem ST/rejected ST/wontfix ST/worksforme
Milestone
Set milestone
Clear milestone
No items
No Milestone
R14.1.1 release
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/koffice#39
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'replace/object_strings_defines'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes