Replace Qt with TQt #63

Merged
MicheleC merged 1 commits from cmake/lower-case into master 2 months ago
Owner

As per title.

As per title.
MicheleC added this to the R14.1.2 release milestone 2 months ago
MicheleC added 1 commit 2 months ago
c477b73e0a
cmake files: change keywords to lower case
MicheleC requested review from Fat-Zer 2 months ago
MicheleC requested review from Core 2 months ago
MicheleC requested review from Owners 2 months ago
MicheleC force-pushed cmake/lower-case from c477b73e0a to 94a5c335ae 2 months ago
Fat-Zer requested changes 2 months ago
A word on compatibility: &chalk; is still in development. From &chalk; 1.5 to
1.6 not many API changes are expected, but there may be some. From &chalk; 1.6
to 2.0 we will move from &Qt;3 to &Qt;4, from &tde;3 to &tde;4, from
to 2.0 we will move from &TQt;3 to &TQt;4, from &tde;3 to &tde;4, from
Collaborator

This one should probably stay as is, and probably even reverted: tde->kde.

This one should probably stay as is, and probably even reverted: tde->kde.
Collaborator

This one should probably stay as is, and probably even reverted: tde->kde.

This one should probably stay as is, and probably even reverted: tde->kde.
Poster
Owner

ah nice. I will remove that, since I did it for the i-18n translation. I should have double checked here too.
Unless you think it is better to keep it for historical reasons.

ah nice. I will remove that, since I did it for the i-18n translation. I should have double checked here too. Unless you think it is better to keep it for historical reasons.
Collaborator

I'm ok with removal

I'm ok with removal
Fat-Zer marked this conversation as resolved
</para></listitem>
<listitem><para>
The &Qt; 3.3 libraries from Trolltech. See
The &TQt; 3.3 libraries from Trolltech. See
Collaborator

should probably be rephrased or kept as-is

should probably be rephrased or kept as-is
Poster
Owner

Rephrased

Rephrased
MicheleC marked this conversation as resolved
</para></listitem>
<listitem><para>
Troll Tech's &Qt; 3.3 development packages. If these packages are not installed on
Troll Tech's &TQt; 3.3 development packages. If these packages are not installed on
Collaborator

should probably be rephrased or kept as-is

should probably be rephrased or kept as-is
Poster
Owner

Rephrased

Rephrased
MicheleC marked this conversation as resolved
<tip><para>While &koffice; will compile and run with any version of &Qt; 3.2 or later, it is recommended that you compile and install
&Qt; 3.3.4 to take advantage of all the bug fixes (including some security fixes) that have occurred.</para></tip>
<tip><para>While &koffice; will compile and run with any version of &TQt; 3.2 or later, it is recommended that you compile and install
&TQt; 3.3.4 to take advantage of all the bug fixes (including some security fixes) that have occurred.</para></tip>
Collaborator

References specific versions. this one should be heavily rephrased or kept as-is

References specific versions. this one should be heavily rephrased or kept as-is
Poster
Owner

Yes, this one I wasn't really sure about it. The main issue of rephrasing it would be the translations in non common languages will be difficult to adapt perhaps. Should we just leave it as Qt in such case?

Yes, this one I wasn't really sure about it. The main issue of rephrasing it would be the translations in non common languages will be difficult to adapt perhaps. Should we just leave it as Qt in such case?
Collaborator

Should we just leave it as Qt in such case?

Probably, yes...

> Should we just leave it as Qt in such case? Probably, yes...
Poster
Owner

I am going to rephrase it. It is only in few files where it is needed and I think I can manage the translation part. We shall not merge the PR till we are happy with the i18n PR too.

I am going to rephrase it. It is only in few files where it is needed and I think I can manage the translation part. We shall not merge the PR till we are happy with the i18n PR too.
Poster
Owner

Rephrasing done in last update

Rephrasing done in last update
MicheleC marked this conversation as resolved
1. Parsing
1a parsing documentinfo,xml (done classicaly with QDom)
1b parsing maindoc.xml (class KWord13Parser, done with Qt's SAX parser: QXml)
1b parsing maindoc.xml (class KWord13Parser, done with TQt's SAX parser: QXml)
Collaborator

s/QXml/TQXml/

s/QXml/TQXml/
Poster
Owner

Sounds good.

Sounds good.
MicheleC marked this conversation as resolved
# kde_styledir Where Qt/KDE widget styles should go to (new in KDE 3).
# kde_designerdir Where Qt Designer plugins should go to (new in KDE 3).
# kde_styledir Where TQt/TDE widget styles should go to (new in TDE 3).
# kde_designerdir Where TQt Designer plugins should go to (new in TDE 3).
Collaborator

s/QtSQL/TQSQL/, probably...

s/QtSQL/TQSQL/, probably...
Poster
Owner

Not in Makefile.am, unless we also rename the file CopyCenterPluginQtSQL.py to CopyCenterPluginTQtSQL.py

Not in Makefile.am, unless we also rename the file `CopyCenterPluginQtSQL.py` to `CopyCenterPluginTQtSQL.py`
Collaborator

Yep, the comment was on the wrong line, should have been:

new in KDE 3 should stay probably

Yep, the comment was on the wrong line, should have been: > `new in KDE 3` should stay probably
Poster
Owner

new in TDE 3 removed in the last update.

`new in TDE 3` removed in the last update.
MicheleC marked this conversation as resolved
# kde_styledir Where Qt/KDE widget styles should go to (new in KDE 3).
# kde_designerdir Where Qt Designer plugins should go to (new in KDE 3).
# kde_styledir Where TQt/TDE widget styles should go to (new in TDE 3).
# kde_designerdir Where TQt Designer plugins should go to (new in TDE 3).
Collaborator

new in KDE 3 should stay probably

`new in KDE 3` should stay probably
Poster
Owner

How about removing (new in TDE 3) instead?

How about removing `(new in TDE 3)` instead?
Collaborator

yep, remove sound fine by me...

yep, remove sound fine by me...
Fat-Zer marked this conversation as resolved
Idea 2
Look at QSQL module from QT. E.g. there is efficient cursor feature (it works quite good with mysql).
Look at QSQL module from TQt. E.g. there is efficient cursor feature (it works quite good with mysql).
Collaborator

s/QSQL/TQSQL/, probably...

s/QSQL/TQSQL/, probably...
Poster
Owner

I guess the comment is on the wrong line, but I found the correct place. Thanks.

I guess the comment is on the wrong line, but I found the correct place. Thanks.
MicheleC marked this conversation as resolved
# kde_styledir Where Qt/KDE widget styles should go to (new in KDE 3).
# kde_designerdir Where Qt Designer plugins should go to (new in KDE 3).
# kde_styledir Where TQt/TDE widget styles should go to (new in TDE 3).
# kde_designerdir Where TQt Designer plugins should go to (new in TDE 3).
Collaborator

new in KDE 3 should stay probably

`new in KDE 3` should stay probably
MicheleC marked this conversation as resolved
<ul>
<li>Read+write Kexi Databases. This includes all database backends supported by Kexi (like SQLite, MySQL or PostgreSQL).</li>
<li>Read+write QtSQL Databases. MySQL, PostgreSQL and UnixODBC are supported. There might even be more like Oracle in the commercial Qt version or 3rd party backends.</li>
<li>Read+write QtSQL Databases. MySQL, PostgreSQL and UnixODBC are supported. There might even be more like Oracle in the commercial TQt version or 3rd party backends.</li>
Collaborator
  • s/QtSQL/TQSQL/, probably...
  • the sentence about commercial version should probably be rephrased or removed... suggestion:
    There are might be others provided by 3rd party backends or later TQt versions.
- s/QtSQL/TQSQL/, probably... - the sentence about `commercial version` should probably be rephrased or removed... suggestion: `There are might be others provided by 3rd party backends or later TQt versions.`
Poster
Owner

I agree

I agree
MicheleC marked this conversation as resolved
# kde_styledir Where Qt/KDE widget styles should go to (new in KDE 3).
# kde_designerdir Where Qt Designer plugins should go to (new in KDE 3).
# kde_styledir Where TQt/TDE widget styles should go to (new in TDE 3).
# kde_designerdir Where TQt Designer plugins should go to (new in TDE 3).
Collaborator

new in KDE 3 should stay probably

new in KDE 3 should stay probably
MicheleC marked this conversation as resolved
# kde_styledir Where Qt/KDE widget styles should go to (new in KDE 3).
# kde_designerdir Where Qt Designer plugins should go to (new in KDE 3).
# kde_styledir Where TQt/TDE widget styles should go to (new in TDE 3).
# kde_designerdir Where TQt Designer plugins should go to (new in TDE 3).
Collaborator

new in KDE 3 should stay probably

new in KDE 3 should stay probably
MicheleC marked this conversation as resolved
# kde_styledir Where Qt/KDE widget styles should go to (new in KDE 3).
# kde_designerdir Where Qt Designer plugins should go to (new in KDE 3).
# kde_styledir Where TQt/TDE widget styles should go to (new in TDE 3).
# kde_designerdir Where TQt Designer plugins should go to (new in TDE 3).
Collaborator

new in KDE 3 should stay probably

`new in KDE 3` should stay probably
MicheleC marked this conversation as resolved
*
* DIRTY HACK FOR SOME INFLEXIBILITY IN QT3's SQL stuff
*
* This class is rom some Trolltech guy on QT-interest
Collaborator

probably we can keep this vague credit as-is =))

probably we can keep this vague credit as-is =))
Poster
Owner

Ok, makes sense.

Ok, makes sense.
MicheleC marked this conversation as resolved
MicheleC force-pushed cmake/lower-case from 94a5c335ae to 1974d29c6b 2 months ago
Poster
Owner

PR updated based on some of the feedback. For some points please see my comments and let me know your opinion.

PR updated based on some of the feedback. For some points please see my comments and let me know your opinion.
MicheleC force-pushed cmake/lower-case from 1974d29c6b to 7df8c349e3 2 months ago
MicheleC force-pushed cmake/lower-case from 7df8c349e3 to 0d40dea0b6 2 months ago
MicheleC requested review from Fat-Zer 2 months ago
Poster
Owner

This PR should now be good (hopefully).

This PR should now be good (hopefully).
Fat-Zer approved these changes 2 months ago
Fat-Zer left a comment
Collaborator

LGTM now

LGTM now
else if (isTextNS && tag == "time")
{
// Use TQDateTime to work around a possible problem of TQTime::FromString in TQt 3.2.2
// Use TQDateTime to work around a possible problem of TQTime::FromString in Qt 3.2.2
Collaborator

Good catch

Good catch
Fat-Zer marked this conversation as resolved
Poster
Owner

I will wait merging this PR till we finalize TDE/koffice-i18n#10. I am planning to update that tomorrow

I will wait merging this PR till we finalize TDE/koffice-i18n#10. I am planning to update that tomorrow
MicheleC force-pushed cmake/lower-case from 0d40dea0b6 to b1f8a29f2f 2 months ago
MicheleC force-pushed cmake/lower-case from b1f8a29f2f to 7a7827396f 2 months ago
MicheleC merged commit 7a7827396f into master 2 months ago
MicheleC deleted branch cmake/lower-case 2 months ago

Reviewers

Fat-Zer approved these changes 2 months ago
TDE/Core was requested for review 2 months ago
TDE/Owners was requested for review 2 months ago
The pull request has been merged as 7a7827396f.
Sign in to join this conversation.
No reviewers
TDE/Core
TDE/Owners
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/koffice#63
Loading…
There is no content yet.