Replace Qt with TQt #63
Merged
MicheleC
merged 1 commits from cmake/lower-case
into master
2 months ago
Loading…
Reference in new issue
There is no content yet.
Delete Branch 'cmake/lower-case'
Deleting a branch is permanent. It CANNOT be undone. Continue?
As per title.
c477b73e0a
to94a5c335ae
2 months agoA word on compatibility: &chalk; is still in development. From &chalk; 1.5 to
1.6 not many API changes are expected, but there may be some. From &chalk; 1.6
to 2.0 we will move from &Qt;3 to &Qt;4, from &tde;3 to &tde;4, from
to 2.0 we will move from &TQt;3 to &TQt;4, from &tde;3 to &tde;4, from
This one should probably stay as is, and probably even reverted: tde->kde.
This one should probably stay as is, and probably even reverted: tde->kde.
ah nice. I will remove that, since I did it for the i-18n translation. I should have double checked here too.
Unless you think it is better to keep it for historical reasons.
I'm ok with removal
</para></listitem>
<listitem><para>
The &Qt; 3.3 libraries from Trolltech. See
The &TQt; 3.3 libraries from Trolltech. See
should probably be rephrased or kept as-is
Rephrased
</para></listitem>
<listitem><para>
Troll Tech's &Qt; 3.3 development packages. If these packages are not installed on
Troll Tech's &TQt; 3.3 development packages. If these packages are not installed on
should probably be rephrased or kept as-is
Rephrased
<tip><para>While &koffice; will compile and run with any version of &Qt; 3.2 or later, it is recommended that you compile and install
&Qt; 3.3.4 to take advantage of all the bug fixes (including some security fixes) that have occurred.</para></tip>
<tip><para>While &koffice; will compile and run with any version of &TQt; 3.2 or later, it is recommended that you compile and install
&TQt; 3.3.4 to take advantage of all the bug fixes (including some security fixes) that have occurred.</para></tip>
References specific versions. this one should be heavily rephrased or kept as-is
Yes, this one I wasn't really sure about it. The main issue of rephrasing it would be the translations in non common languages will be difficult to adapt perhaps. Should we just leave it as Qt in such case?
Probably, yes...
I am going to rephrase it. It is only in few files where it is needed and I think I can manage the translation part. We shall not merge the PR till we are happy with the i18n PR too.
Rephrasing done in last update
1. Parsing
1a parsing documentinfo,xml (done classicaly with QDom)
1b parsing maindoc.xml (class KWord13Parser, done with Qt's SAX parser: QXml)
1b parsing maindoc.xml (class KWord13Parser, done with TQt's SAX parser: QXml)
s/QXml/TQXml/
Sounds good.
# kde_styledir Where Qt/KDE widget styles should go to (new in KDE 3).
# kde_designerdir Where Qt Designer plugins should go to (new in KDE 3).
# kde_styledir Where TQt/TDE widget styles should go to (new in TDE 3).
# kde_designerdir Where TQt Designer plugins should go to (new in TDE 3).
s/QtSQL/TQSQL/, probably...
Not in Makefile.am, unless we also rename the file
CopyCenterPluginQtSQL.py
toCopyCenterPluginTQtSQL.py
Yep, the comment was on the wrong line, should have been:
new in TDE 3
removed in the last update.# kde_styledir Where Qt/KDE widget styles should go to (new in KDE 3).
# kde_designerdir Where Qt Designer plugins should go to (new in KDE 3).
# kde_styledir Where TQt/TDE widget styles should go to (new in TDE 3).
# kde_designerdir Where TQt Designer plugins should go to (new in TDE 3).
new in KDE 3
should stay probablyHow about removing
(new in TDE 3)
instead?yep, remove sound fine by me...
Idea 2
Look at QSQL module from QT. E.g. there is efficient cursor feature (it works quite good with mysql).
Look at QSQL module from TQt. E.g. there is efficient cursor feature (it works quite good with mysql).
s/QSQL/TQSQL/, probably...
I guess the comment is on the wrong line, but I found the correct place. Thanks.
# kde_styledir Where Qt/KDE widget styles should go to (new in KDE 3).
# kde_designerdir Where Qt Designer plugins should go to (new in KDE 3).
# kde_styledir Where TQt/TDE widget styles should go to (new in TDE 3).
# kde_designerdir Where TQt Designer plugins should go to (new in TDE 3).
new in KDE 3
should stay probably<ul>
<li>Read+write Kexi Databases. This includes all database backends supported by Kexi (like SQLite, MySQL or PostgreSQL).</li>
<li>Read+write QtSQL Databases. MySQL, PostgreSQL and UnixODBC are supported. There might even be more like Oracle in the commercial Qt version or 3rd party backends.</li>
<li>Read+write QtSQL Databases. MySQL, PostgreSQL and UnixODBC are supported. There might even be more like Oracle in the commercial TQt version or 3rd party backends.</li>
commercial version
should probably be rephrased or removed... suggestion:There are might be others provided by 3rd party backends or later TQt versions.
I agree
# kde_styledir Where Qt/KDE widget styles should go to (new in KDE 3).
# kde_designerdir Where Qt Designer plugins should go to (new in KDE 3).
# kde_styledir Where TQt/TDE widget styles should go to (new in TDE 3).
# kde_designerdir Where TQt Designer plugins should go to (new in TDE 3).
new in KDE 3 should stay probably
# kde_styledir Where Qt/KDE widget styles should go to (new in KDE 3).
# kde_designerdir Where Qt Designer plugins should go to (new in KDE 3).
# kde_styledir Where TQt/TDE widget styles should go to (new in TDE 3).
# kde_designerdir Where TQt Designer plugins should go to (new in TDE 3).
new in KDE 3 should stay probably
# kde_styledir Where Qt/KDE widget styles should go to (new in KDE 3).
# kde_designerdir Where Qt Designer plugins should go to (new in KDE 3).
# kde_styledir Where TQt/TDE widget styles should go to (new in TDE 3).
# kde_designerdir Where TQt Designer plugins should go to (new in TDE 3).
new in KDE 3
should stay probably*
* DIRTY HACK FOR SOME INFLEXIBILITY IN QT3's SQL stuff
*
* This class is rom some Trolltech guy on QT-interest
probably we can keep this vague credit as-is =))
Ok, makes sense.
94a5c335ae
to1974d29c6b
2 months agoPR updated based on some of the feedback. For some points please see my comments and let me know your opinion.
1974d29c6b
to7df8c349e3
2 months ago7df8c349e3
to0d40dea0b6
2 months agoThis PR should now be good (hopefully).
LGTM now
else if (isTextNS && tag == "time")
{
// Use TQDateTime to work around a possible problem of TQTime::FromString in TQt 3.2.2
// Use TQDateTime to work around a possible problem of TQTime::FromString in Qt 3.2.2
Good catch
I will wait merging this PR till we finalize TDE/koffice-i18n#10. I am planning to update that tomorrow
0d40dea0b6
tob1f8a29f2f
2 months agob1f8a29f2f
to7a7827396f
2 months ago7a7827396f
into master 2 months agoReviewers
7a7827396f
.