TDE
/
kshowmail
6
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
Labels Milestones

Remove .moc source files documentation #3

Merged
MicheleC merged 1 commits from drop/tqt-no-compat into master 11 months ago
Conversation 2 Commits 1 Files Changed 24
MicheleC commented 11 months ago
Owner

Cosmetic changes to html documentation.

Cosmetic changes to html documentation.
MicheleC added this to the R14.1.1 release milestone 11 months ago
MicheleC added 1 commit 11 months ago
d3a29d3802
Drop use of TQT_NO_COMPAT define
MicheleC requested review from SlavekB 11 months ago
SlavekB reviewed 11 months ago
SlavekB left a comment
Owner

Although it is formally fine, the question arises, why the documentation should include descriptions for files that are generated automatically and are currently not part of the source code? Would it make sense to remove the documentation for all moc files?

Although it is formally fine, the question arises, why the documentation should include descriptions for files that are generated automatically and are currently not part of the source code? Would it make sense to remove the documentation for all `moc` files?
MicheleC commented 11 months ago
Poster
Owner

Yup, I was very surprised too.
I think the idea of removing the moc file documentation is probably a better idea. I will rework this PR

Yup, I was very surprised too. I think the idea of removing the moc file documentation is probably a better idea. I will rework this PR
MicheleC force-pushed drop/tqt-no-compat from d3a29d3802 to 687f1188f4 11 months ago
MicheleC commented 11 months ago
Poster
Owner

PR updated

PR updated
MicheleC changed title from Drop use of TQT_NO_COMPAT define to Remove .moc source files documentation 11 months ago
SlavekB approved these changes 11 months ago
SlavekB left a comment
Owner

It looks good.

It looks good.
MicheleC merged commit 687f1188f4 into master 11 months ago
MicheleC deleted branch drop/tqt-no-compat 11 months ago

Reviewers

SlavekB approved these changes 11 months ago
The pull request has been merged as 687f1188f4.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
SlavekB
Labels
Apply labels
Clear labels
GE/need-info
General - need additional info from contributor PR/keep-branch
Pull request - do not delete branch after merging PR/not-ok
Pull request - need fixing PR/rfc
Pull request - request for comments PR/update-trans
Pull request - update to translation files needed PR/wip
Pull request - work in progress RS/R14.0.x
Related to R14.0.x series RS/R14.1.x
Related to R14.1.x series SL/critical
Severity level - critical SL/major
Severity level - major SL/minor
Severity level - minor SL/normal
Severity level - normal SL/regression
Severity level - regression from previous version SL/trivial
Severity level - trivial SL/wishlist
Severity level - wishlist request ST/duplicate
Status - duplicate of another issue ST/invalid
Status - invalid report ST/notourproblem
Status - not our problem ST/rejected
Status - rejected ST/wontfix
Status - won't fix ST/worksforme
Status - works for me, unable to reproduce
No Label GE/need-info PR/keep-branch PR/not-ok PR/rfc PR/update-trans PR/wip RS/R14.0.x RS/R14.1.x SL/critical SL/major SL/minor SL/normal SL/regression SL/trivial SL/wishlist ST/duplicate ST/invalid ST/notourproblem ST/rejected ST/wontfix ST/worksforme
Milestone
Set milestone
Clear milestone
No items
No Milestone
R14.1.1 release
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TDE/kshowmail#3
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'drop/tqt-no-compat'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes