6
0
Fork 0

cmake conversion #1

Merge aplicado
SlavekB aplicou merge dos 1 commits de feat/cmakeConv em master 5 anos atrás

I've added a man page taken from your Debian packaging system.

I've added a man page taken from your Debian packaging system.
SlavekB revisou 5 anos atrás
SlavekB deixou um comentário
Proprietário

Please, give attention to my comments below. For now, I did not test it but it looks good.

Please, give attention to my comments below. For now, I did not test it but it looks good.
ConfigureChecks.cmake Desatualizado
include(TestBigEndian)
test_big_endian(WORDS_BIGENDIAN)
Proprietário

Please add here as another standard test:

tde_setup_largefiles( )
Please add here as another standard test: ``` tde_setup_largefiles( ) ```
set( __KDE_HAVE_GCC_VISIBILITY 1 )
set( CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -fvisibility=hidden -fvisibility-inlines-hidden")
set( CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fvisibility=hidden -fvisibility-inlines-hidden")
endif( WITH_GCC_VISIBILITY )
Proprietário

Please use a new common test:

tde_setup_gcc_visibility( )
Please use a new common test: ``` tde_setup_gcc_visibility( ) ```
if( NOT MSGFMT_EXECUTABLE )
tde_message_fatal( "msgfmt is required but was not found on your system." )
endif( NOT MSGFMT_EXECUTABLE )
endif( BUILD_TRANSLATIONS )
Proprietário

This is no longer needed – it is automatically served by the new common test tde_setup_msgfmt( ).

This is no longer needed – it is automatically served by the new common test `tde_setup_msgfmt( )`.
Ghost adicionou o rótulo PR/wip 5 anos atrás
Ghost adicionou o(s) rótulo(s) ST/wontfix e removeu PR/wip 5 anos atrás
Ghost comentou 5 anos atrás
Autor

So many change in the cmake modules, I get lost.
Feel free to add/change anything, I won't work on kshudown anymore.

So many change in the cmake modules, I get lost. Feel free to add/change anything, I won't work on kshudown anymore.
Proprietário

Okay, that's no problem. Changes in the common cmake module are not large and most represent simplification for individual projects. I'll finish it.

Okay, that's no problem. Changes in the common cmake module are not large and most represent simplification for individual projects. I'll finish it.
SlavekB removeu o rótulo ST/wontfix 5 anos atrás
SlavekB se auto atribuiu para esta issue 5 anos atrás
SlavekB adicionou o rótulo PR/wip 5 anos atrás
SlavekB removeu o rótulo PR/wip 5 anos atrás
SlavekB fechou este pull request 5 anos atrás
SlavekB excluiu branch feat/cmakeConv 5 anos atrás
SlavekB adicionou esta issue para o marco R14.0.6 release 5 anos atrás
O pull request teve merge aplicado como ffbcad84f2.
Acesse para participar desta conversação.
Sem revisor
Sem responsável
2 participante(s)
Notificações
Data limite

Data limite não informada.

Dependências

Nenhuma dependência definida.

Referência: TDE/kshutdown#1
Carregando…
Ainda não há conteúdo.